Merge pull request #2323 from gavenren/fix/timezone-float-formatting

fix: format float timezone offsets as integer fields

Author: Byron

git/objects/util.py

@@ -161,8 +161,7 @@ def altz_to_utctz_str(altz: float) -> str:
     :param altz:
         Timezone offset in seconds west of UTC.
     """
-    hours = abs(altz) // 3600
-    minutes = (abs(altz) % 3600) // 60
+    hours, minutes = divmod(int(abs(altz) // 60), 60)
     sign = "-" if altz >= 60 else "+"
     return "{}{:02}{:02}".format(sign, hours, minutes)
 

test/test_util.py

@@ -301,6 +301,17 @@ def __repr__(self):
         return f"{type(self).__name__}({self.name!r})"
 
 
+@pytest.mark.parametrize(
+    "offset, expected",
+    [(0.0, "+0000"), (19800.0, "-0530"), (-19800.0, "+0530"), (34200.9, "-0930"), (60.1, "-0001"), (-59.9, "+0000")],
+)
+def test_altz_to_utctz_str_accepts_float_seconds(offset, expected):
+    result = altz_to_utctz_str(offset)
+    assert result == expected
+    assert verify_utctz(result) == result
+    assert utctz_to_altz(result) == utctz_to_altz(expected)
+
+
 @ddt.ddt
 class TestUtils(TestBase):
     """Tests for most utilities in :mod:`git.util`."""