Skip to content

[BUG] Expo plugin breaking due to override keyword not supported in version 54 #91

Description

@survivorsam

Describe the bug
When loading the plugin in version 54, compilation fails due to the override keyword used.
It is needed in version 52, not in > 53 anymore.

Expected behavior
It should use the override keyword in version 52 and avoid it in version > 53.

Additional information
It looks like this is how the previous bug report #85 was implemented:
plugin/src/withRNOrientationAppDelegate.ts
line 62:
const methodPrefix = !sdkVersion?.includes('53') ? 'override' : '';

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

bugSomething isn't working

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions