You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Fix code samples that do not compile against the shipped SDKs (#2194)
* Fix code samples that do not compile against the shipped SDKs
Checked the code samples against the real published libraries and corrected
what does not compile or resolve. Verified against google-adk 2.8.0 for
Python, @google/adk 2.0.0 for TypeScript, google-adk 1.6.0 for Java,
adk-kotlin 0.8.0 for Kotlin, and adk/v2 2.3.0 for Go.
Go: tool.Context does not exist in the v2 line and never has. The type is
agent.Context, which this repository's own Go examples already use. Nine
sites. Four import blocks also omitted the fmt they call.
Java: two imports naming packages that do not exist, com.google.adk.agent
(the package is agents) and com.google.adk.agents.Content (it is a genai
type). Four wrong types, each confirmed against the jar with javap:
EventActions.stateDelta returns Map not ConcurrentMap, artifactDelta returns
Map<String, Integer> rather than ConcurrentMap<String, Part>,
FunctionResponse.response yields Map<String, Object>, and loadArtifact takes
the version as an int so the Optional argument matched no overload.
Python: four coroutines used without await, which also masked a
SearchMemoryResponse.results field that does not exist. The field is
memories, holding MemoryEntry objects; the TypeScript and Java tabs of the
same example had the same mistake. Also CodeExecutionInput imported from the
wrong module, a calendar_tool_set object that does not exist in place of
CalendarToolset, two positional Part.from_text calls against a keyword-only
signature, five LlmAgent samples missing the required name, and an external
access token sample built on an enum member and a field that the package does
not define.
Also corrects samples that could not parse at all: an unindented plugin class
body, bracket and text block typos, a truncated call, an await in a non-async
function, an await dedented out of the condition meant to guard it, a mid-file
Java import, and a fence that opened at six spaces and closed at eight, which
made a page render a literal code fence as body text.
* Yield the workflow node's result instead of returning it
code_workflow yields, which makes it an async generator, and returning a
value from one is a syntax error. A generator node conveys its result by
yielding an event whose output the runner copies to the context, which is the
form the data handling page already uses.
* docs(tools): simplify the toolset headings per review
Drop the parenthetical class lists from the two toolset headings in the
authentication page. Nothing links to either anchor.
---------
Co-authored-by: Joe Fernandez <931947+joefernandez@users.noreply.github.com>
0 commit comments