From c9bd3582ba31feacb595043dc7d4fff799947424 Mon Sep 17 00:00:00 2001 From: Jin Seop Kim Date: Mon, 16 Nov 2026 22:02:52 -0500 Subject: [PATCH] fix(bigquery): clarify Acl append and modify semantics in DatasetInfo.getAcl() --- .../com/google/cloud/bigquery/DatasetInfo.java | 14 ++++++++++++-- 1 file changed, 12 insertions(+), 2 deletions(-) diff --git a/java-bigquery/google-cloud-bigquery/src/main/java/com/google/cloud/bigquery/DatasetInfo.java b/java-bigquery/google-cloud-bigquery/src/main/java/com/google/cloud/bigquery/DatasetInfo.java index 91876199514b..5dcd91c6349c 100644 --- a/java-bigquery/google-cloud-bigquery/src/main/java/com/google/cloud/bigquery/DatasetInfo.java +++ b/java-bigquery/google-cloud-bigquery/src/main/java/com/google/cloud/bigquery/DatasetInfo.java @@ -448,7 +448,15 @@ public DatasetId getDatasetId() { /** * Returns the dataset's access control configuration. * - *

Update the ACLs for a dataset. + *

Each {@link Acl} entry is immutable. Calling {@code acls.add(...)} appends a new entry to + * the dataset's access list; to modify an existing {@link Acl} (for example, to change its {@link + * Acl.Role} or {@link Acl.Expr} condition), remove the existing entry from the copied list and + * add a new {@link Acl} before calling {@link BigQuery#update(DatasetInfo, + * BigQuery.DatasetOption...)}. When reading or updating conditional ACLs ({@link Acl.Expr}), pass + * {@link BigQuery.DatasetOption#accessPolicyVersion(Integer) + * DatasetOption.accessPolicyVersion(3)} to {@code getDataset} and {@code update}. + * + *

Append a new ACL entry to a dataset: * *

{@code
    * Dataset dataset = bigquery.getDataset(DatasetId.of("my_dataset"));
@@ -463,7 +471,9 @@ public DatasetId getDatasetId() {
    * bigquery.update(builder.build());  // API request.
    * }
* - * @see Access Control + * @see Access Control + * @see Control access with IAM + * Conditions */ public List getAcl() { return acl;