Cannot parse boolean options

[sliekens]

Version 2.0.261-beta

My option looks like this

[Option('t', "trusted", Default = true, SetName = "noconnectionstring", HelpText = "Specify whether the connection uses integrated security.")]
public bool IntegratedSecurity { get; set; }

No matter what I try, the parser always sets ÌntegratedSecurity to its default value true.

ConsoleApplication.exe -t false
ConsoleApplication.exe -t False
ConsoleApplication.exe -t 0

Even if I remove the part Default = true, I still get value true.

Is this a type conversion bug?

[sliekens]

Just a thought, but maybe there should be an extension mechanism for custom type converters. Something along the lines of a custom class that implements a given interface IArgumentConverter<T>.

// namespace CommandLine
interface IArgumentConverter<T>
{
    T ConvertArgument(string argument);
}

// custom namespace
class BooleanConverter : IArgumentConverter<bool>
{
    bool ConvertArgument(string argument)
    {
        return bool.Parse(argument);
    }
}

Then let us inject the type converter using either the Action<ParserSettings> delegate or by setting it on the OptionAttribute directly.

var parser = new Parser(
                parserSettings =>
                {
                    // TypeConverters : IDictionary<Type, IArgumentConverter>
                    parserSettings.TypeConverters[typeof(bool)] = new BooleanConverter();
                });

[Option('t', "trusted", Default = true, ..., TypeConverter = typeof(BooleanConverter))]
public bool IntegratedSecurity { get; set; }

[gsscoder]

@StevenLiekens, this is covered by a variety of issues. Please check! :)

As in #213, no enhancemente will be added until stable is reached.

[sliekens]

Okay but what about the original question? I still can't parse arguments as boolean.

[gsscoder]

More references: #115 and #133 for example.

The problem is that the parser has its own logic of parsing booleans directly grasped from getopt() \ *nix terminal style.

Having:

class Options {
  [Option('v')]
  public bool Verbose { get; set; }
}

For the moment you can't explictely set Verbose to false. This is done, by design, omitting it:

$ app

But you can enable it explitely:

$ app -v

In fact this kind of options are internally treated as Switch.

Anyway it's possible that after 2.0 reaches stable status, I'll add some pre/post processing machinery that will add allow explicit setting of boolean with syntax like app -v true or using custom tokens like app -v+. (See quoted issues/pr for discussion).

[sliekens]

Oh, I get it now. :) Thanks.

[gsscoder]

Perfect! :)