diff --git a/.claude/CLAUDE.md b/.claude/CLAUDE.md index 49cad46c..a6a3d7d2 100644 --- a/.claude/CLAUDE.md +++ b/.claude/CLAUDE.md @@ -272,13 +272,20 @@ resolved; kept here with current status so agents don't re-investigate: root files. A real new finding shows as a *delta in your changed files*; otherwise ignore. (The Hypatia *check run* gates separately and is green.) -**CI is now standalone and green on `main` (since #604 / `c7922cf`).** Two -`startup_failure` classes bit `ci` / `governance` / `secret-scanner` for days -(and `main` itself) — worth knowing so they aren't reintroduced: - -1. The repo's Actions "allowed actions" policy **rejects tag-pinned action - refs at run-creation** (a `startup_failure` with zero jobs). **Pin every - `uses:` to a full commit SHA** — `actions/foo@v4` will fail to start. +**CI is standalone (since #604 / `c7922cf`).** Two `startup_failure` classes +(a run that never starts, with zero jobs) have bitten `ci` / `governance` / +`secret-scanner` and `main` itself. `ci` did not run at all from +2026-10-11 until the actions.lock fix. Know them so they aren't reintroduced: + +1. **`.github/workflows/actions.lock` is the pin authority** (GitHub's actions + lockfile, `gh actions-lock`). Workflows reference actions by tag + (`actions/checkout@v7.0.1`) and the lock maps each to a commit SHA. A + workflow whose `uses:` refs do not match the lock does not start. A + Dependabot bump that does not regenerate the lock causes exactly this + (#782 stopped `ci`). **After any change to a `uses:` ref, regenerate + `actions.lock`.** `tools/ci/check-actions-lock.sh` (governance check 4) + fails on a mismatch. (An older note here said tag pins themselves were + rejected; the run history shows tag pins that match the lock start fine.) 2. A reusable-workflow *caller* that declares `concurrency:` on the same key the reusable also declares is rejected at run-creation (BP008 — see `.github/workflows/spark-theatre-gate.yml`). diff --git a/.github/workflows/actions.lock b/.github/workflows/actions.lock index e3212b8d..4c745e84 100644 --- a/.github/workflows/actions.lock +++ b/.github/workflows/actions.lock @@ -11,11 +11,11 @@ workflows: - 'actions/configure-pages@v6.0.0' - 'actions/deploy-pages@v5.0.1' - 'actions/upload-pages-artifact@v5.0.0' - - 'haskell-actions/setup@v2.12.0' + - 'haskell-actions/setup@v2.12.1' '.github/workflows/ci.yml': - 'actions/checkout@v7.0.1' - - 'actions/setup-node@v7.0.0' - - 'actions/upload-artifact@v7.0.1' + - 'actions/setup-node@v7.1.0' + - 'actions/upload-artifact@v7.0.2' '.github/workflows/codeql.yml': - 'actions/checkout@v7.0.1' - 'github/codeql-action@v4.39.3' @@ -40,7 +40,7 @@ workflows: - 'actions/upload-pages-artifact@v5.0.0' '.github/workflows/panic-attack.yml': - 'actions/checkout@v7.0.1' - - 'actions/upload-artifact@v7.0.1' + - 'actions/upload-artifact@v7.0.2' - 'dtolnay/rust-toolchain@master' '.github/workflows/publish-jsr.yml': - 'actions/checkout@v7.0.1' @@ -92,9 +92,9 @@ dependencies: commit: 'sha1-368f82528645a54fb793d4d04e342629a3f51346' owner_id: 44036562 repo_id: 438112499 - 'actions/setup-node@v7.0.0': - ref: 'v7.0.0' - commit: 'sha1-820762786026740c76f36085b0efc47a31fe5020' + 'actions/setup-node@v7.1.0': + ref: 'v7.1.0' + commit: 'sha1-949feb2413d6458794dcd2491c4babbbce0c15c1' owner_id: 44036562 repo_id: 189476904 'actions/upload-artifact@bbbca2ddaa5d8feaa63e36b76fdaad77386f024f': @@ -102,9 +102,9 @@ dependencies: commit: 'sha1-bbbca2ddaa5d8feaa63e36b76fdaad77386f024f' owner_id: 44036562 repo_id: 192625955 - 'actions/upload-artifact@v7.0.1': - ref: 'v7.0.1' - commit: 'sha1-043fb46d1a93c77aae656e7c1c64a875d1fc6a0a' + 'actions/upload-artifact@v7.0.2': + ref: 'v7.0.2' + commit: 'sha1-cf430e030ddbb5b0abf93d22962f4752f3646cd9' owner_id: 44036562 repo_id: 192625955 'actions/upload-pages-artifact@v5.0.0': @@ -129,9 +129,9 @@ dependencies: commit: 'sha1-33d7b85da1a04171e211befe2c739303b9a4c066' owner_id: 9919 repo_id: 259445878 - 'haskell-actions/setup@v2.12.0': - ref: 'v2.12.0' - commit: 'sha1-6037f33647c3f17758a2356c80fc4a53d7e0685d' + 'haskell-actions/setup@v2.12.1': + ref: 'v2.12.1' + commit: 'sha1-0f8e8c99d88aeb3fbfd523f1ef2c6f762d10d64d' owner_id: 75048950 repo_id: 623796603 'hyperpolymath/smtp-notify-action@v0.5.1': diff --git a/.github/workflows/publish-jsr.yml b/.github/workflows/publish-jsr.yml index 7cb5e19e..97b00bd4 100644 --- a/.github/workflows/publish-jsr.yml +++ b/.github/workflows/publish-jsr.yml @@ -43,8 +43,8 @@ jobs: timeout-minutes: 10 steps: - uses: actions/checkout@v7.0.1 - # v2.0.5 — immutable commit pin (tag: v2.0.5). - - uses: denoland/setup-deno@22d081ff2d3a40755e97629de92e3bcbfa7cf2ed + # v2.0.5; its commit is pinned in actions.lock (the pin authority). + - uses: denoland/setup-deno@v2.0.5 with: deno-version: v2.x - name: Resolve package directory diff --git a/CHANGELOG.adoc b/CHANGELOG.adoc index 414748a2..ce60555c 100644 --- a/CHANGELOG.adoc +++ b/CHANGELOG.adoc @@ -158,6 +158,11 @@ JSR publish (#303) ==== CI +* fix(ci): `CI` never started from 2026-10-11 (startup_failure, zero jobs) +because Dependabot #782 bumped actions in ci.yml without regenerating +`.github/workflows/actions.lock`. The lock now matches every workflow +(ci.yml, panic-attack.yml, casket-pages.yml, publish-jsr.yml), and +governance check 4 (`tools/ci/check-actions-lock.sh`) fails on any drift * ci(migration-assistant): fix smoke-parse for tree-sitter-cli 0.25 (#342) * ci: bump github/codeql-action from 4.32.6 to 4.36.0 (#323) diff --git a/tools/ci/check-actions-lock.sh b/tools/ci/check-actions-lock.sh new file mode 100755 index 00000000..960f0e05 --- /dev/null +++ b/tools/ci/check-actions-lock.sh @@ -0,0 +1,147 @@ +#!/usr/bin/env bash +# SPDX-License-Identifier: MPL-2.0 +# +# actions.lock consistency guard. +# +# `.github/workflows/actions.lock` (GitHub's actions lockfile, generated by +# `gh actions-lock`) is this repo's pin authority: it maps every action a +# workflow uses to a commit SHA. GitHub refuses to start a workflow whose +# `uses:` refs do not match the lock, and reports only a `startup_failure` +# with zero jobs. That is how the `CI` workflow stopped running on every +# push and PR from 2026-10-11: Dependabot (#782) bumped +# `actions/setup-node` and `actions/upload-artifact` in ci.yml without +# regenerating the lock. +# +# For each workflow, this check compares the set of external actions its +# `uses:` lines reference (sub-path actions such as +# `github/codeql-action/init@v4` count as `github/codeql-action@v4`; local +# `./` actions, `docker://` images and reusable workflows (a job-level +# `uses:` naming a `.github/workflows/*.yml` file) are not locked) +# with the set the lock lists for it, and fails on any difference, either +# way round. It also fails if a locked action has no `dependencies:` entry. +# +# Usage: tools/ci/check-actions-lock.sh [WORKFLOW_DIR] (default .github/workflows) +set -uo pipefail + +dir="${1:-.github/workflows}" +lock="$dir/actions.lock" +fail=0 +err() { printf '::error::%s\n' "$*"; fail=1; } + +[[ -f "$lock" ]] || { err "actions lockfile missing: $lock"; exit 1; } + +# Split a workflow (comments stripped) by context: lines inside a `steps:` +# block (more indented than its `steps:` key) are tagged S, all others J. +# A reusable workflow is called by a job (`jobs..uses`), never by a step, +# so the reusable-workflow exclusion below applies to J lines only: a step +# action whose directory happens to be named `.github/workflows/x.yml` is +# still checked. +tag() { + local file="$1" + sed -E 's/[[:space:]]+#.*$//' "$file" | awk ' + { match($0, /^ */); ind = RLENGTH } + /^[[:space:]]*$/ { next } + # An indentless sequence (`steps:` then `- uses: …` at the same indent) is + # still step context: only a non-`-` line at or above the key ends it. + in_steps && (ind < sind || (ind == sind && $0 !~ /^ *-/)) { in_steps = 0 } + /^[[:space:]]*["'\'']?steps["'\'']?[[:space:]]*:/ { + # `steps: [{uses: …}]` (flow sequence on the key line) is step context too. + print (match($0, /:[[:space:]]*[^[:space:]]/) ? "S" : "J") "\t" $0 + in_steps = 1; sind = ind; next + } + { print (in_steps ? "S" : "J") "\t" $0 } + ' +} + +# The `uses:` values on lines tagged $2 (S or J), action-shaped only. +# Block style (`- uses: x`), flow style (`- {uses: x, with: …}`) and quoted keys (`"uses": x`). +# Only action-shaped values count (`owner/repo[/path]@ref`, a ref may hold `/`), so `uses:` text in +# a `run:` script (a grep pattern, say) is not mistaken for a step. +refs() { + local file="$1" ctx="$2" + tag "$file" | grep -E "^$ctx"$'\t' | cut -f2- \ + | grep -oE '(^|[{,[:space:]-])["'\'']?uses["'\'']?[[:space:]]*:[[:space:]]*[^[:space:],}]+' \ + | sed -E 's/^.*uses["'\'']?[[:space:]]*:[[:space:]]*//; s/^["'\'']//; s/["'\'']$//' \ + | grep -vE '^(\./|docker://)' \ + | grep -E '^[A-Za-z0-9_.-]+/[A-Za-z0-9_./-]+@[A-Za-z0-9_./-]+$' +} + +# The actions a workflow file uses, normalised and sorted. +used() { + local file="$1" + { refs "$file" S; refs "$file" J | grep -vE '/\.github/workflows/[^/@]+\.ya?ml@'; } \ + | sed -E 's#^([^/@]+/[^/@]+)/[^@]*@#\1@#' \ + | sort -u +} + +# Fail closed: a `uses:` key at the start of a line (block `uses:` / `- uses:`, +# or a flow mapping opened on the line, `- {uses: …}`) whose value the matcher +# above cannot read is an error, not a silent skip. That covers folded or +# literal scalars (`uses: >-` with the ref on the next line), an empty value, +# and anything else that is not a local action (`./…`), a Docker image +# (`docker://…`), a reusable workflow (`owner/repo/.github/workflows/x.yml@ref`) +# or an action (`owner/repo[/path]@ref`). Write such a step as a plain scalar. +unreadable() { + local file="$1" + sed -E 's/[[:space:]]+#.*$//' "$file" \ + | grep -nE '^[[:space:]]*(-[[:space:]]+)?\{?[[:space:]]*["'\'']?uses["'\'']?[[:space:]]*:' \ + | while IFS= read -r line; do + local n="${line%%:*}" v + v=$(printf '%s\n' "${line#*:}" \ + | sed -E 's/^[[:space:]]*(-[[:space:]]+)?\{?[[:space:]]*["'\'']?uses["'\'']?[[:space:]]*:[[:space:]]*//; s/[[:space:]]*[,}].*$//; s/^["'\'']//; s/["'\'']$//') + if ! printf '%s\n' "$v" | grep -qE '^(\./|docker://|[A-Za-z0-9_.-]+/[A-Za-z0-9_./-]+@[A-Za-z0-9_./-]+$)'; then + printf '%s: %s\n' "$n" "${v:-}" + fi + done +} + +# The actions the lock lists for workflow path $1, sorted. +locked() { + local path="$1" + awk -v wf="'$path':" ' + /^workflows:/ { inwf = 1; next } + /^dependencies:/ { inwf = 0 } + inwf && $1 == wf { on = 1; next } + inwf && on && /^ - / { v = $2; gsub(/'\''/, "", v); print v; next } + inwf && on { on = 0 } + ' "$lock" | sort -u +} + +# Dependency keys present in the lock. +deps=$(awk '/^dependencies:/ { d = 1; next } d && /^ '\''/ { k = $1; gsub(/['\'':]/, "", k); print k }' "$lock") + +checked=0 +for wf in "$dir"/*.yml "$dir"/*.yaml; do + [[ -f "$wf" ]] || continue + rel=".github/workflows/$(basename "$wf")" + checked=$((checked + 1)) + bad=$(unreadable "$wf") + [[ -z "$bad" ]] || err "$rel has uses: values this guard cannot read (write them as plain scalars): ${bad//$'\n'/; }" + u=$(used "$wf") + l=$(locked "$rel") + if ! grep -qF "'$rel':" "$lock"; then + [[ -z "$u" ]] || err "$rel uses actions but has no actions.lock entry: ${u//$'\n'/ }" + continue + fi + missing=$(comm -23 <(printf '%s\n' "$u" | sed '/^$/d') <(printf '%s\n' "$l" | sed '/^$/d')) + stale=$(comm -13 <(printf '%s\n' "$u" | sed '/^$/d') <(printf '%s\n' "$l" | sed '/^$/d')) + [[ -z "$missing" ]] || err "$rel uses actions the lock does not list (regenerate actions.lock): ${missing//$'\n'/ }" + [[ -z "$stale" ]] || err "$rel: actions.lock lists actions the workflow no longer uses: ${stale//$'\n'/ }" + for a in $l; do + printf '%s\n' "$deps" | grep -qxF "$a" || err "actions.lock has no dependencies entry for $a ($rel)" + done +done + +# Transitive references: an action the lock records may itself use other +# actions (`uses:` under its dependency record, e.g. upload-pages-artifact -> +# upload-artifact@). Each of those must have its own record too. +while IFS= read -r t; do + [[ -n "$t" ]] || continue + printf '%s\n' "$deps" | grep -qxF "$t" || err "actions.lock: a dependency uses $t, which has no dependencies entry" +done < <(awk '/^dependencies:/ { d = 1; next } d && /^ uses:/ { u = 1; next } d && u && /^ - / { v = $2; gsub(/'\''/, "", v); print v; next } { u = 0 }' "$lock" | sort -u) + +if [[ "$fail" -ne 0 ]]; then + echo "actions.lock check FAILED: a mismatched workflow does not start (startup_failure, zero jobs)." + exit 1 +fi +echo "actions.lock check: OK ($checked workflows match the lock)" diff --git a/tools/ci/governance-standalone.sh b/tools/ci/governance-standalone.sh index bf9241c8..0d4f3816 100755 --- a/tools/ci/governance-standalone.sh +++ b/tools/ci/governance-standalone.sh @@ -26,7 +26,7 @@ err() { printf '::error::%s\n' "$*"; fail=1; } echo "== Governance gate (standalone) ==" # --- [1] Jekyll artifacts are banned (estate SSG is hyperpolymath/casket-ssg) -echo "[1/3] Jekyll artifacts" +echo "[1/4] Jekyll artifacts" jekyll=$(find . \( -path ./.git -o -path ./_build -o -path ./node_modules \) -prune -o \ \( -name '_config.yml' -o -name 'Gemfile' -o -iname 'jekyll*.yml' \ -o -iname 'jekyll-gh-pages*.yml' \) -print 2>/dev/null || true) @@ -38,7 +38,7 @@ else note "none"; fi # --- [2] MPL-1.0 license headers are banned (must be MPL-2.0) --------------- # Match the actual SPDX identifier, not mere prose mentions of the ban (the # policy docs legitimately discuss MPL-1.0). -echo "[2/3] MPL-1.0 SPDX headers" +echo "[2/4] MPL-1.0 SPDX headers" mpl1=$(grep -rIl --exclude-dir=.git --exclude-dir=_build --exclude-dir=node_modules \ -E 'SPDX-License-Identifier:[[:space:]]*MPL-1\.0' . 2>/dev/null || true) if [ -n "$mpl1" ]; then @@ -48,7 +48,7 @@ else note "none"; fi # --- [3] DOC-FORMAT (delta): newly-added docs/ files must be .adoc ---------- # Community-health files keep their canonical .md names. -echo "[3/3] DOC-FORMAT (newly-added docs/ files must be .adoc)" +echo "[3/4] DOC-FORMAT (newly-added docs/ files must be .adoc)" base="${1:-${GOVERNANCE_BASE_REF:-${GITHUB_BASE_REF:-}}}" if [ -n "$base" ] && git rev-parse --verify --quiet "origin/$base" >/dev/null 2>&1; then added=$(git diff --name-only --diff-filter=A "origin/$base...HEAD" -- 'docs/' 2>/dev/null \ @@ -62,6 +62,20 @@ else note "no base ref available — delta check skipped" fi +# --- [4] actions.lock matches every workflow's `uses:` --------------------- +# A workflow whose actions drift from the lockfile never starts (GitHub reports +# a startup_failure with zero jobs). Dependabot bumps do exactly that unless the +# lock is regenerated: CI was silently not running from 2026-10-11 (#782). +echo "[4/4] actions.lock consistency" +if ! lock_out=$(./tools/ci/check-actions-lock.sh 2>&1); then + printf '%s\n' "$lock_out" | grep '::error::' | sed 's/^::error:: *//' | while IFS= read -r l; do err "$l"; done + err "actions.lock is out of step with the workflows (run gh actions-lock)" +else note "$lock_out"; fi +if ! test_out=$(./tools/ci/test-check-actions-lock.sh 2>&1); then + printf '%s\n' "$test_out" | grep '^FAIL' | while IFS= read -r l; do err "check-actions-lock self-test: $l"; done + err "the actions.lock guard failed its own regression tests (tools/ci/test-check-actions-lock.sh)" +else note "$(printf '%s\n' "$test_out" | tail -1)"; fi + echo if [ "$fail" -ne 0 ]; then echo "Governance gate: FAIL"; exit 1; fi echo "Governance gate: PASS" diff --git a/tools/ci/test-check-actions-lock.sh b/tools/ci/test-check-actions-lock.sh new file mode 100755 index 00000000..52b8bdb8 --- /dev/null +++ b/tools/ci/test-check-actions-lock.sh @@ -0,0 +1,88 @@ +#!/usr/bin/env bash +# SPDX-License-Identifier: MPL-2.0 +# +# Regression tests for tools/ci/check-actions-lock.sh. Each case appends a +# job to a copy of the real workflows and asserts whether the guard passes. +# A reference in step context is always checked; only a job-level call of a +# workflow file (`jobs..uses: …/.github/workflows/x.yml@ref`) is skipped. +# +# Usage: tools/ci/test-check-actions-lock.sh (from the repo root) +set -uo pipefail + +guard=tools/ci/check-actions-lock.sh +work=$(mktemp -d) +trap 'rm -rf "$work"' EXIT +fails=0 + +# expect +expect() { + local want="$1" name="$2" yaml="$3" got + rm -rf "$work/wf" && mkdir "$work/wf" + cp .github/workflows/*.yml .github/workflows/actions.lock "$work/wf/" + printf '%s\n' "$yaml" >> "$work/wf/ci.yml" + if "$guard" "$work/wf" >/dev/null 2>&1; then got=pass; else got=fail; fi + if [[ "$got" == "$want" ]]; then + echo "ok $name" + else + echo "FAIL $name (expected $want, got $got)" + fails=$((fails + 1)) + fi +} + +expect pass "real workflows" "" +expect fail "unlocked step action" ' t: + runs-on: x + steps: + - uses: acme/build-action@v1' +expect fail "step action under a .github/workflows/*.yml directory" ' t: + runs-on: x + steps: + - name: odd + uses: acme/repo/.github/workflows/my-action.yml@v1' +expect fail "indentless step sequence" ' t: + runs-on: x + steps: + - name: odd + uses: acme/repo/.github/workflows/my-action.yml@v1' +expect fail "flow sequence on the steps: line" ' t: + runs-on: x + steps: [{uses: acme/repo/.github/workflows/f.yml@v2}]' +expect fail "flow mapping step" ' t: + runs-on: x + steps: + - {uses: acme/build-action@v1, with: {a: b}}' +expect fail "quoted key, spaced colon" ' t: + runs-on: x + steps: + - "uses" : acme/build-action@v1' +expect fail "ref containing a slash" ' t: + runs-on: x + steps: + - uses: acme/build-action@release/v1' +expect fail "folded scalar fails closed" ' t: + runs-on: x + steps: + - uses: >- + acme/build-action@v1' +expect fail "job-level non-workflow path is still an action" ' t: + uses: acme/repo/.github/workflows/my-action@v1' +expect pass "job-level reusable workflow call" ' t: + uses: acme/repo/.github/workflows/x.yml@0123456789abcdef0123456789abcdef01234567' +expect pass "reusable call after an indentless steps block" ' a: + runs-on: x + steps: + - run: echo + timeout-minutes: 5 + b: + uses: acme/repo/.github/workflows/x.yaml@v1' +expect pass "local action and docker image" ' t: + runs-on: x + steps: + - uses: ./tools/local-action + - uses: docker://alpine:3' + +if [[ "$fails" -ne 0 ]]; then + echo "check-actions-lock self-test: $fails case(s) FAILED" + exit 1 +fi +echo "check-actions-lock self-test: OK"