From f9cd8fe474df533320216ea0fca02490f8c43519 Mon Sep 17 00:00:00 2001 From: REPPL <77722411+REPPL@users.noreply.github.com> Date: Thu, 29 Oct 2026 19:46:57 +0000 Subject: [PATCH] docs: file the test packages that can still reach the machine's gh login The guard #1147 adds covers the four test packages on the announce path. Twenty-one more depend on internal/core/github without it; this records them so the follow-up is not left in a pull-request body. Refs: iss-2610291946475029 Assisted-by: Claude:claude-opus-5-5 --- ...29-test-packages-reach-the-machine-gh-login.md | 15 +++++++++++++++ 1 file changed, 15 insertions(+) create mode 100644 .abcd/work/issues/open/iss-2610291946475029-test-packages-reach-the-machine-gh-login.md diff --git a/.abcd/work/issues/open/iss-2610291946475029-test-packages-reach-the-machine-gh-login.md b/.abcd/work/issues/open/iss-2610291946475029-test-packages-reach-the-machine-gh-login.md new file mode 100644 index 000000000..7502f7a09 --- /dev/null +++ b/.abcd/work/issues/open/iss-2610291946475029-test-packages-reach-the-machine-gh-login.md @@ -0,0 +1,15 @@ +--- +schema_version: 1 +id: "iss-2610291946475029" +slug: "test-packages-reach-the-machine-gh-login" +severity: "minor" +category: "tech-debt" +source: "review-followup" +found_during: "#1147 merge-queue failure follow-up, 2026-10-29" +origin: researcher-authored +production_mode: hand-written +found_at: "internal/core/github" +remedy: "Give each of these packages the same TestMain guard #1147 adds to the landing, claim, implement loop and CLI test packages (HideGHLogin in internal/gittest: an empty GH_CONFIG_DIR and the gh token variables unset), and add a check that names any test package depending on internal/core/github without it." +--- + +Twenty-one test packages depend on internal/core/github but have no TestMain hiding the machine's gh login: afterupdate, ahoy, autonomy, capture, embargo, github, ideate, implement, lifeboat, reading, record, release, repolint, report, reservesweep, scribe, site, sweep, update, surface/session and surface/session/web. A test in any of them that reaches the forge reads the developer's real login and tokens, so it can pass locally and fail on CI, which has no login, as the landing body test did in the merge queue for #1147.