Skip to content

mypy workflow may not be covering as much as we think #804

Description

@d-w-moore

mypy --ignore-missing-imports irods is run by the Github compile time type checks. There do seem to be gaps in its coverage however:

Adding a module irods/experiment.py:

class C: pass

def function(x: C): pass

And a final test in irods/test/meta_test.py:

    def test_that_should_be_flagged_by_mypy(self):
        function(1)

As well as an import at the head of that file:

from irods.experiment import function

One would expect an error, but we don't get one.

$ cd <PRC_REPO>
$ mypy --ignore-missing-imports irods
Success: no issues found in 99 source files

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions