"lzomodule.c:38:10: fatal error: lzo/lzo1.h: No such file or directory" on Ubuntu / missing wheels

[mxmlnkn]

It seems that only wheels for MacOS and Windows are available on PyPI. This results in the following error on pip install python-lzo:

Defaulting to user installation because normal site-packages is not writeable
Collecting python-lzo
  Downloading python-lzo-1.15.tar.gz (17 kB)
  Installing build dependencies ... done
  Getting requirements to build wheel ... done
  Preparing metadata (pyproject.toml) ... done
Building wheels for collected packages: python-lzo
  Building wheel for python-lzo (pyproject.toml) ... error
  error: subprocess-exited-with-error
  
  × Building wheel for python-lzo (pyproject.toml) did not run successfully.
  │ exit code: 1
  ╰─> [5 lines of output]
      lzomodule.c:38:10: fatal error: lzo/lzo1.h: No such file or directory
         38 | #include <lzo/lzo1.h>
            |          ^~~~~~~~~~~~
      compilation terminated.
      error: command '/usr/bin/x86_64-linux-gnu-gcc' failed with exit code 1
      [end of output]
  
  note: This error originates from a subprocess, and is likely not a problem with pip.
  ERROR: Failed building wheel for python-lzo
Failed to build python-lzo
ERROR: Could not build wheels for python-lzo, which is required to install pyproject.toml-based projects

After installing the missing dependencies with sudo apt install liblzo2-dev, it builds fine.

[jd-boyd]

I thought the apt install part was mentioned in the readme, but I just double checked before saying that and I'm wrong. So I guess that will need to be fixed. Unless I'm behind on the times, binary wheels for Linux are not particularly portable across all versions of Linux. Those I believe The goal is to have binary wheels for windows and Mac OS, but only source for Linux.

[mxmlnkn]

As far as I know, manylinux solved the wheels-for-Linux problem. Most Python packages publish manylinux wheels to avoid additional manual user installation steps such as the one I had to do. I saw cibuildwheel mentioned, which I am also using for my packages. Normally, it should build all (manylinux) wheels automatically.

[fixthething]

Wanted to reaffirm the manylinux approach for being able to distribute binary wheels for wide Linux compatibility. If you really want to support ten-year old Linux distros you can use manylinux2014, but I think it's deprecated and probably most package maintainers now would just distribute for manylinux-2.28 which supports:

• Debian 10+
  

• Ubuntu 18.10+
  

• Fedora 29+
  

• CentOS/RHEL 8+
  

See https://github.com/pypa/manylinux

[fixthething]

If you install the liblzo2.so.2 into the manylinux image, build the wheel from within the image, then run "python3 -m auditwheel repair --plat manylinux_2_28_x86_64 -w . (path to original built .whl file)", it will automatically verify that both your .so and the liblzo one meet the correct glibc requirements, add the manylinux label, and even grab the .so file and include it in your wheel so that the package works even if the library isn't pre-installed on the user's system.

[jd-boyd]

I'm going with building LZO from source to staticly link into the python module if liblzo2.so isn't found, and am using many-linux. Currently that is running. It it works, I will probably tag 3.17 and try to finally make a new release on pypi.

After that I think I want to redo the linux build actions again so that they parallize better instead using one running that takes 40 minutes per qemu build.