From 9b37d976e65bb04cc32988c67b98a3836d3417d6 Mon Sep 17 00:00:00 2001 From: George Angel Date: Wed, 18 Nov 2026 14:24:31 +1000 Subject: [PATCH] Stop mutating cached tag in isLatestSemver isLatestSemver appended "@" to the *api.ImageTag returned by search.LatestImage, which points into the shared version cache. Once a tag had been re-pushed upstream, the cached tag no longer matched its name, so the tag-name fallback in CurrentImage failed and version_checker_is_available reported 0 for an image that still exists. The same corrupted entry was reused on later reconciles, flipping IsLatest to true and, after a cache refetch, regressing LatestVersion. Work on a copy so the cache stays intact. Fixes #467 --- pkg/controller/checker/checker.go | 16 +++++++++------- 1 file changed, 9 insertions(+), 7 deletions(-) diff --git a/pkg/controller/checker/checker.go b/pkg/controller/checker/checker.go index 01d43c31..c1de697d 100644 --- a/pkg/controller/checker/checker.go +++ b/pkg/controller/checker/checker.go @@ -166,7 +166,9 @@ func (c *Checker) isLatestSemver(ctx context.Context, imageURL, currentSHA strin return nil, false, err } - latestImageV := semver.Parse(latestImage.Tag) + result := *latestImage + + latestImageV := semver.Parse(result.Tag) var isLatest bool @@ -179,23 +181,23 @@ func (c *Checker) isLatestSemver(ctx context.Context, imageURL, currentSHA strin // but the SHA has been updated upstream, // mark not latest if currentImage.Equal(latestImageV) && - !latestImage.MatchesSHA(currentSHA) { + !result.MatchesSHA(currentSHA) { isLatest = false - if latestImage.SHA != "" { + if result.SHA != "" { // Add the SHA as a prefix to identify that it has been updated! - latestImage.Tag = fmt.Sprintf("%s@%s", latestImage.Tag, latestImage.SHA) + result.Tag = fmt.Sprintf("%s@%s", result.Tag, result.SHA) } else { - for _, child := range latestImage.Children { + for _, child := range result.Children { // Take first child's SHA for latest image tag if child.SHA != currentSHA { - latestImage.Tag = fmt.Sprintf("%s@%s", latestImage.Tag, child.SHA) + result.Tag = fmt.Sprintf("%s@%s", result.Tag, child.SHA) break } } } } - return latestImage, isLatest, nil + return &result, isLatest, nil } // isLatestSHA will return the the result of whether the given image is the latest, according to image SHA.