Merge pull request #97 from lambda-feedback/boolean-as-number

Write a Boolean answer as 1 or 0, compared as a string

Author: peterbjohnson

in2lambda/api/response_area.py

@@ -177,6 +177,10 @@ def _validate(self) -> None:
                 names = " or ".join(t.__name__ for t in self.payload_types)
                 raise ValueError(f"test payload {test.payload!r} is not {names}")
 
+    def _serial(self, value: Any) -> Any:
+        """An answer or test payload as Lambda Feedback stores it."""
+        return value
+
 
 @dataclass(kw_only=True)
 class _Maths(ResponseArea):
@@ -254,6 +258,14 @@ class Boolean(ResponseArea):
     payload_types: ClassVar[tuple[type, ...]] = (bool,)
     answer: bool = False
 
+    # Lambda Feedback stores the answer, and sends the response, as 1 or 0, and
+    # isExactEqual compares them as strings.
+    def _serial(self, value: Any) -> Any:
+        return int(value) if isinstance(value, bool) else value
+
+    def _grade_params(self) -> Optional[dict[str, Any]]:
+        return {"type": "str", **(self.grade_params or {})}
+
 
 @dataclass(kw_only=True)
 class MultipleChoice(ResponseArea):

in2lambda/json_convert/json_convert.py

@@ -82,7 +82,7 @@ def _response_area_to_json(area: ResponseArea, order: int) -> dict[str, Any]:
         "tests": [
             {
                 "id": test.id,
-                "payload": test.payload,
+                "payload": area._serial(test.payload),
                 "expectedResponse": {"isCorrect": test.is_correct},
             }
             for test in _tests(area)
@@ -91,7 +91,7 @@ def _response_area_to_json(area: ResponseArea, order: int) -> dict[str, Any]:
         "response": {
             "responseInput": {
                 "responseType": area.response_type,
-                "answer": area.answer,
+                "answer": area._serial(area.answer),
                 "config": area._config(),
             }
         },

tests/test_boolean.py

@@ -0,0 +1,10 @@
+"""A Boolean area is written as Lambda Feedback's own teacher test sends it."""
+
+from in2lambda.api.response_area import Boolean
+from in2lambda.json_convert.json_convert import _response_area_to_json
+
+
+def test_a_boolean_answer_is_written_as_a_number_compared_as_a_string() -> None:
+    area = _response_area_to_json(Boolean(answer=True), 0)
+    assert area["response"]["responseInput"]["answer"] == 1
+    assert area["gradeParams"] == {"type": "str"}