From 96216b3c653d0a3cd3d9aef5f9cda206a620f6a3 Mon Sep 17 00:00:00 2001 From: Roei Shoustak <52932659+shoustak@users.noreply.github.com> Date: Fri, 13 Nov 2026 21:17:06 +0200 Subject: [PATCH] docs(combobox-web): drop useMenuStyle from AGENTS.md The hook was removed in f05c682a (menu now shrinks and scrolls when space is tight), but AGENTS.md still listed it in four places. --- packages/pluggableWidgets/combobox-web/AGENTS.md | 4 ---- 1 file changed, 4 deletions(-) diff --git a/packages/pluggableWidgets/combobox-web/AGENTS.md b/packages/pluggableWidgets/combobox-web/AGENTS.md index 6166c7c4f8..1cc540c811 100644 --- a/packages/pluggableWidgets/combobox-web/AGENTS.md +++ b/packages/pluggableWidgets/combobox-web/AGENTS.md @@ -162,7 +162,6 @@ BaseOptionsProvider (standalone implementations) | **useDownshiftSingleSelectProps** | `src/hooks/useDownshiftSingleSelectProps.ts` | Wraps Downshift useCombobox for single-select | | **useDownshiftMultiSelectProps** | `src/hooks/useDownshiftMultiSelectProps.ts` | Wraps Downshift useMultipleSelection + useCombobox | | **useLazyLoading** | `src/hooks/useLazyLoading.ts` | Infinite scroll via useInfiniteControl from grid plugin | -| **useMenuStyle** | `src/hooks/useMenuStyle.ts` | Dynamic dropdown positioning with debounced style updates | ### Data Flow @@ -182,7 +181,6 @@ SingleSelection / MultiSelection │ ├─ useDownshift*Props(selector) → Downshift state (isOpen, inputValue, etc.) ├─ useLazyLoading(selector.options) → onScroll handler - ├─ useMenuStyle() → dropdown positioning │ ↓ getInputProps, getMenuProps, getItemProps ComboboxWrapper + Menu components @@ -229,7 +227,6 @@ selector.setValue(selectedItem) | --------------------------- | ----------------------------- | ----------------------------------- | | Debounced filter input | useGetSelector | 200ms (configurable) | | Debounced datasource filter | BaseDatasourceOptionsProvider | 200ms (configurable) | -| Debounced menu position | useMenuStyle | 32ms (~60fps) | | Memoized Downshift config | useDownshift\*Props | useMemo with selector deps | | Singleton selector | useGetSelector | useRef (created once) | | Lazy loading | useLazyLoading | useInfiniteControl from grid plugin | @@ -372,7 +369,6 @@ pnpm run format — Prettier - `src/hooks/useDownshiftSingleSelectProps.ts` - `src/hooks/useDownshiftMultiSelectProps.ts` - `src/hooks/useLazyLoading.ts` -- `src/hooks/useMenuStyle.ts` ### Selectors