diff --git a/packages/mergebot/src/_tests/fixtures/67090/derived.json b/packages/mergebot/src/_tests/fixtures/67090/derived.json index 458278f0c1..174d1a0287 100644 --- a/packages/mergebot/src/_tests/fixtures/67090/derived.json +++ b/packages/mergebot/src/_tests/fixtures/67090/derived.json @@ -17,6 +17,7 @@ "pkgInfo": [ { "name": "ansicolors", + "version": "0.0", "kind": "edit", "files": [ { @@ -33,6 +34,7 @@ }, { "name": "cardinal", + "version": "2.1", "kind": "add", "files": [ { @@ -98,6 +100,7 @@ }, { "name": "marked-terminal", + "version": "6.0", "kind": "edit", "files": [ { diff --git a/packages/mergebot/src/_tests/fixtures/67090/mutations.json b/packages/mergebot/src/_tests/fixtures/67090/mutations.json index 871755a39c..3789de6353 100644 --- a/packages/mergebot/src/_tests/fixtures/67090/mutations.json +++ b/packages/mergebot/src/_tests/fixtures/67090/mutations.json @@ -4,7 +4,7 @@ "variables": { "input": { "id": "IC_kwDOAFz6BM5pVwbO", - "body": "@andrewbranch Thank you for submitting this PR!\n\n***This is a live comment that I will keep updated.***\n\n## 3 packages in this PR\n\n* `ansicolors` — [on npm](https://www.npmjs.com/package/ansicolors), [on unpkg](https://unpkg.com/browse/ansicolors@latest/)\n* `cardinal` (*new!*) — [on npm](https://www.npmjs.com/package/cardinal), [on unpkg](https://unpkg.com/browse/cardinal@latest/)\n - 1 added owner: ✎@andrewbranch\n - Config files to check:\n - [`cardinal/tslint.json`](https://github.com/DefinitelyTyped/DefinitelyTyped/pull/67090/files/bb7d42f514b9f9cfca6b9a84dc99fac76ac35643#diff-9f471f9ba6ffa73024ae9aeb049dd98078364c565db83ee831e0498cbb678d67): edited\n* `marked-terminal` — [on npm](https://www.npmjs.com/package/marked-terminal), [on unpkg](https://unpkg.com/browse/marked-terminal@latest/)\n\n## Code Reviews\n\nThis PR adds a new definition, so it needs to be reviewed by a DT maintainer before it can be merged.\n\nYou can test the changes of this PR [in the Playground](https://www.typescriptlang.org/play/?dtPR=67090&install-plugin=playground-dt-review).\n\n## Status\n\n * ✅ No merge conflicts\n * ❌ Continuous integration tests have failed\n * 🕐 Only a DT maintainer can approve changes when there are new packages added\n\nOnce every item on this list is checked, I'll ask you for permission to merge and publish the changes.\n\n----------------------\n... diagnostics scrubbed ...\n" + "body": "@andrewbranch Thank you for submitting this PR!\n\n***This is a live comment that I will keep updated.***\n\n## 3 packages in this PR\n\n* `ansicolors` (0.0) — [on npm](https://www.npmjs.com/package/ansicolors), [on unpkg](https://unpkg.com/browse/ansicolors@latest/)\n* `cardinal` (2.1) (*new!*) — [on npm](https://www.npmjs.com/package/cardinal), [on unpkg](https://unpkg.com/browse/cardinal@latest/)\n - 1 added owner: ✎@andrewbranch\n - Config files to check:\n - [`cardinal/tslint.json`](https://github.com/DefinitelyTyped/DefinitelyTyped/pull/67090/files/bb7d42f514b9f9cfca6b9a84dc99fac76ac35643#diff-9f471f9ba6ffa73024ae9aeb049dd98078364c565db83ee831e0498cbb678d67): edited\n* `marked-terminal` (6.0) — [on npm](https://www.npmjs.com/package/marked-terminal), [on unpkg](https://unpkg.com/browse/marked-terminal@latest/)\n\n## Code Reviews\n\nThis PR adds a new definition, so it needs to be reviewed by a DT maintainer before it can be merged.\n\nYou can test the changes of this PR [in the Playground](https://www.typescriptlang.org/play/?dtPR=67090&install-plugin=playground-dt-review).\n\n## Status\n\n * ✅ No merge conflicts\n * ❌ Continuous integration tests have failed\n * 🕐 Only a DT maintainer can approve changes when there are new packages added\n\nOnce every item on this list is checked, I'll ask you for permission to merge and publish the changes.\n\n----------------------\n... diagnostics scrubbed ...\n" } } }, diff --git a/packages/mergebot/src/_tests/fixtures/67090/result.json b/packages/mergebot/src/_tests/fixtures/67090/result.json index e99da39dc5..6caaddea3c 100644 --- a/packages/mergebot/src/_tests/fixtures/67090/result.json +++ b/packages/mergebot/src/_tests/fixtures/67090/result.json @@ -9,7 +9,7 @@ "responseComments": [ { "tag": "welcome", - "status": "@andrewbranch Thank you for submitting this PR!\n\n***This is a live comment that I will keep updated.***\n\n## 3 packages in this PR\n\n* `ansicolors` — [on npm](https://www.npmjs.com/package/ansicolors), [on unpkg](https://unpkg.com/browse/ansicolors@latest/)\n* `cardinal` (*new!*) — [on npm](https://www.npmjs.com/package/cardinal), [on unpkg](https://unpkg.com/browse/cardinal@latest/)\n - 1 added owner: ✎@andrewbranch\n - Config files to check:\n - [`cardinal/tslint.json`](https://github.com/DefinitelyTyped/DefinitelyTyped/pull/67090/files/bb7d42f514b9f9cfca6b9a84dc99fac76ac35643#diff-9f471f9ba6ffa73024ae9aeb049dd98078364c565db83ee831e0498cbb678d67): edited\n* `marked-terminal` — [on npm](https://www.npmjs.com/package/marked-terminal), [on unpkg](https://unpkg.com/browse/marked-terminal@latest/)\n\n## Code Reviews\n\nThis PR adds a new definition, so it needs to be reviewed by a DT maintainer before it can be merged.\n\nYou can test the changes of this PR [in the Playground](https://www.typescriptlang.org/play/?dtPR=67090&install-plugin=playground-dt-review).\n\n## Status\n\n * ✅ No merge conflicts\n * ❌ Continuous integration tests have failed\n * 🕐 Only a DT maintainer can approve changes when there are new packages added\n\nOnce every item on this list is checked, I'll ask you for permission to merge and publish the changes.\n\n----------------------\n... diagnostics scrubbed ..." + "status": "@andrewbranch Thank you for submitting this PR!\n\n***This is a live comment that I will keep updated.***\n\n## 3 packages in this PR\n\n* `ansicolors` (0.0) — [on npm](https://www.npmjs.com/package/ansicolors), [on unpkg](https://unpkg.com/browse/ansicolors@latest/)\n* `cardinal` (2.1) (*new!*) — [on npm](https://www.npmjs.com/package/cardinal), [on unpkg](https://unpkg.com/browse/cardinal@latest/)\n - 1 added owner: ✎@andrewbranch\n - Config files to check:\n - [`cardinal/tslint.json`](https://github.com/DefinitelyTyped/DefinitelyTyped/pull/67090/files/bb7d42f514b9f9cfca6b9a84dc99fac76ac35643#diff-9f471f9ba6ffa73024ae9aeb049dd98078364c565db83ee831e0498cbb678d67): edited\n* `marked-terminal` (6.0) — [on npm](https://www.npmjs.com/package/marked-terminal), [on unpkg](https://unpkg.com/browse/marked-terminal@latest/)\n\n## Code Reviews\n\nThis PR adds a new definition, so it needs to be reviewed by a DT maintainer before it can be merged.\n\nYou can test the changes of this PR [in the Playground](https://www.typescriptlang.org/play/?dtPR=67090&install-plugin=playground-dt-review).\n\n## Status\n\n * ✅ No merge conflicts\n * ❌ Continuous integration tests have failed\n * 🕐 Only a DT maintainer can approve changes when there are new packages added\n\nOnce every item on this list is checked, I'll ask you for permission to merge and publish the changes.\n\n----------------------\n... diagnostics scrubbed ..." }, { "tag": "pinging-reviewers", diff --git a/packages/mergebot/src/_tests/fixtures/68381/derived.json b/packages/mergebot/src/_tests/fixtures/68381/derived.json index c9e90fddf6..70a076c879 100644 --- a/packages/mergebot/src/_tests/fixtures/68381/derived.json +++ b/packages/mergebot/src/_tests/fixtures/68381/derived.json @@ -17,6 +17,7 @@ "pkgInfo": [ { "name": "express-serve-static-core", + "version": "4.17", "kind": "edit", "files": [ { diff --git a/packages/mergebot/src/_tests/fixtures/68381/mutations.json b/packages/mergebot/src/_tests/fixtures/68381/mutations.json index f85916f4ba..457f7e2843 100644 --- a/packages/mergebot/src/_tests/fixtures/68381/mutations.json +++ b/packages/mergebot/src/_tests/fixtures/68381/mutations.json @@ -4,7 +4,7 @@ "variables": { "input": { "id": "IC_kwDOAFz6BM5yPU4k", - "body": "@krzysdz Thank you for submitting this PR! I see this is your first time submitting to DefinitelyTyped 👋 — I'm the local bot who will help you through the process of getting things through.\n\n***This is a live comment that I will keep updated.***\n\n## 1 package in this PR\n\n* `express-serve-static-core` — [on npm](https://www.npmjs.com/package/express-serve-static-core), [on unpkg](https://unpkg.com/browse/express-serve-static-core@latest/)\n\n## Code Reviews\n\nBecause this is a widely-used package, a DT maintainer will need to review it before it can be merged.\n\nYou can test the changes of this PR [in the Playground](https://www.typescriptlang.org/play/?dtPR=68381&install-plugin=playground-dt-review).\n\n## Status\n\n * ✅ No merge conflicts\n * ✅ Continuous integration tests have passed\n * 🕐 Only a DT maintainer can approve changes [without tests](https://github.com/DefinitelyTyped/DefinitelyTyped#user-content-test-editing-an-existing-package)\n\nOnce every item on this list is checked, I'll ask you for permission to merge and publish the changes.\n\n----------------------\n... diagnostics scrubbed ...\n" + "body": "@krzysdz Thank you for submitting this PR! I see this is your first time submitting to DefinitelyTyped 👋 — I'm the local bot who will help you through the process of getting things through.\n\n***This is a live comment that I will keep updated.***\n\n## 1 package in this PR\n\n* `express-serve-static-core` (4.17) — [on npm](https://www.npmjs.com/package/express-serve-static-core), [on unpkg](https://unpkg.com/browse/express-serve-static-core@latest/)\n\n## Code Reviews\n\nBecause this is a widely-used package, a DT maintainer will need to review it before it can be merged.\n\nYou can test the changes of this PR [in the Playground](https://www.typescriptlang.org/play/?dtPR=68381&install-plugin=playground-dt-review).\n\n## Status\n\n * ✅ No merge conflicts\n * ✅ Continuous integration tests have passed\n * 🕐 Only a DT maintainer can approve changes [without tests](https://github.com/DefinitelyTyped/DefinitelyTyped#user-content-test-editing-an-existing-package)\n\nOnce every item on this list is checked, I'll ask you for permission to merge and publish the changes.\n\n----------------------\n... diagnostics scrubbed ...\n" } } }, diff --git a/packages/mergebot/src/_tests/fixtures/68381/result.json b/packages/mergebot/src/_tests/fixtures/68381/result.json index 8ce31d057b..ccad4fa43f 100644 --- a/packages/mergebot/src/_tests/fixtures/68381/result.json +++ b/packages/mergebot/src/_tests/fixtures/68381/result.json @@ -11,7 +11,7 @@ }, { "tag": "welcome", - "status": "@krzysdz Thank you for submitting this PR! I see this is your first time submitting to DefinitelyTyped 👋 — I'm the local bot who will help you through the process of getting things through.\n\n***This is a live comment that I will keep updated.***\n\n## 1 package in this PR\n\n* `express-serve-static-core` — [on npm](https://www.npmjs.com/package/express-serve-static-core), [on unpkg](https://unpkg.com/browse/express-serve-static-core@latest/)\n\n## Code Reviews\n\nBecause this is a widely-used package, a DT maintainer will need to review it before it can be merged.\n\nYou can test the changes of this PR [in the Playground](https://www.typescriptlang.org/play/?dtPR=68381&install-plugin=playground-dt-review).\n\n## Status\n\n * ✅ No merge conflicts\n * ✅ Continuous integration tests have passed\n * 🕐 Only a DT maintainer can approve changes [without tests](https://github.com/DefinitelyTyped/DefinitelyTyped#user-content-test-editing-an-existing-package)\n\nOnce every item on this list is checked, I'll ask you for permission to merge and publish the changes.\n\n----------------------\n... diagnostics scrubbed ..." + "status": "@krzysdz Thank you for submitting this PR! I see this is your first time submitting to DefinitelyTyped 👋 — I'm the local bot who will help you through the process of getting things through.\n\n***This is a live comment that I will keep updated.***\n\n## 1 package in this PR\n\n* `express-serve-static-core` (4.17) — [on npm](https://www.npmjs.com/package/express-serve-static-core), [on unpkg](https://unpkg.com/browse/express-serve-static-core@latest/)\n\n## Code Reviews\n\nBecause this is a widely-used package, a DT maintainer will need to review it before it can be merged.\n\nYou can test the changes of this PR [in the Playground](https://www.typescriptlang.org/play/?dtPR=68381&install-plugin=playground-dt-review).\n\n## Status\n\n * ✅ No merge conflicts\n * ✅ Continuous integration tests have passed\n * 🕐 Only a DT maintainer can approve changes [without tests](https://github.com/DefinitelyTyped/DefinitelyTyped#user-content-test-editing-an-existing-package)\n\nOnce every item on this list is checked, I'll ask you for permission to merge and publish the changes.\n\n----------------------\n... diagnostics scrubbed ..." }, { "tag": "pinging-reviewers", diff --git a/packages/mergebot/src/_tests/fixtures/68772/derived.json b/packages/mergebot/src/_tests/fixtures/68772/derived.json index 1baf794079..a05e980eb6 100644 --- a/packages/mergebot/src/_tests/fixtures/68772/derived.json +++ b/packages/mergebot/src/_tests/fixtures/68772/derived.json @@ -17,6 +17,7 @@ "pkgInfo": [ { "name": "relationship.js", + "version": "1.2", "kind": "edit", "files": [ { diff --git a/packages/mergebot/src/_tests/fixtures/68772/mutations.json b/packages/mergebot/src/_tests/fixtures/68772/mutations.json index 675c2a154b..3f70989a27 100644 --- a/packages/mergebot/src/_tests/fixtures/68772/mutations.json +++ b/packages/mergebot/src/_tests/fixtures/68772/mutations.json @@ -4,7 +4,7 @@ "variables": { "input": { "id": "IC_kwDOAFz6BM51I9v-", - "body": "@jakebailey Thank you for submitting this PR!\n\n***This is a live comment that I will keep updated.***\n\n## 1 package in this PR\n\n* `relationship.js` — [on npm](https://www.npmjs.com/package/relationship.js), [on unpkg](https://unpkg.com/browse/relationship.js@latest/)\n\n## Code Reviews\n\nThis PR can be merged once it's reviewed by a DT maintainer.\n\nYou can test the changes of this PR [in the Playground](https://www.typescriptlang.org/play/?dtPR=68772&install-plugin=playground-dt-review).\n\n## Status\n\n * ✅ No merge conflicts\n * 🕐 Continuous integration tests are still running\n * 🕐 Only a DT maintainer can approve changes [without tests](https://github.com/DefinitelyTyped/DefinitelyTyped#user-content-test-editing-an-existing-package)\n\nOnce every item on this list is checked, I'll ask you for permission to merge and publish the changes.\n\n----------------------\n... diagnostics scrubbed ...\n" + "body": "@jakebailey Thank you for submitting this PR!\n\n***This is a live comment that I will keep updated.***\n\n## 1 package in this PR\n\n* `relationship.js` (1.2) — [on npm](https://www.npmjs.com/package/relationship.js), [on unpkg](https://unpkg.com/browse/relationship.js@latest/)\n\n## Code Reviews\n\nThis PR can be merged once it's reviewed by a DT maintainer.\n\nYou can test the changes of this PR [in the Playground](https://www.typescriptlang.org/play/?dtPR=68772&install-plugin=playground-dt-review).\n\n## Status\n\n * ✅ No merge conflicts\n * 🕐 Continuous integration tests are still running\n * 🕐 Only a DT maintainer can approve changes [without tests](https://github.com/DefinitelyTyped/DefinitelyTyped#user-content-test-editing-an-existing-package)\n\nOnce every item on this list is checked, I'll ask you for permission to merge and publish the changes.\n\n----------------------\n... diagnostics scrubbed ...\n" } } }, diff --git a/packages/mergebot/src/_tests/fixtures/68772/result.json b/packages/mergebot/src/_tests/fixtures/68772/result.json index 02298a3383..b63de97042 100644 --- a/packages/mergebot/src/_tests/fixtures/68772/result.json +++ b/packages/mergebot/src/_tests/fixtures/68772/result.json @@ -10,7 +10,7 @@ }, { "tag": "welcome", - "status": "@jakebailey Thank you for submitting this PR!\n\n***This is a live comment that I will keep updated.***\n\n## 1 package in this PR\n\n* `relationship.js` — [on npm](https://www.npmjs.com/package/relationship.js), [on unpkg](https://unpkg.com/browse/relationship.js@latest/)\n\n## Code Reviews\n\nThis PR can be merged once it's reviewed by a DT maintainer.\n\nYou can test the changes of this PR [in the Playground](https://www.typescriptlang.org/play/?dtPR=68772&install-plugin=playground-dt-review).\n\n## Status\n\n * ✅ No merge conflicts\n * 🕐 Continuous integration tests are still running\n * 🕐 Only a DT maintainer can approve changes [without tests](https://github.com/DefinitelyTyped/DefinitelyTyped#user-content-test-editing-an-existing-package)\n\nOnce every item on this list is checked, I'll ask you for permission to merge and publish the changes.\n\n----------------------\n... diagnostics scrubbed ..." + "status": "@jakebailey Thank you for submitting this PR!\n\n***This is a live comment that I will keep updated.***\n\n## 1 package in this PR\n\n* `relationship.js` (1.2) — [on npm](https://www.npmjs.com/package/relationship.js), [on unpkg](https://unpkg.com/browse/relationship.js@latest/)\n\n## Code Reviews\n\nThis PR can be merged once it's reviewed by a DT maintainer.\n\nYou can test the changes of this PR [in the Playground](https://www.typescriptlang.org/play/?dtPR=68772&install-plugin=playground-dt-review).\n\n## Status\n\n * ✅ No merge conflicts\n * 🕐 Continuous integration tests are still running\n * 🕐 Only a DT maintainer can approve changes [without tests](https://github.com/DefinitelyTyped/DefinitelyTyped#user-content-test-editing-an-existing-package)\n\nOnce every item on this list is checked, I'll ask you for permission to merge and publish the changes.\n\n----------------------\n... diagnostics scrubbed ..." }, { "tag": "pinging-reviewers", diff --git a/packages/mergebot/src/_tests/fixtures/68908/derived.json b/packages/mergebot/src/_tests/fixtures/68908/derived.json index e865706133..7641de9ba8 100644 --- a/packages/mergebot/src/_tests/fixtures/68908/derived.json +++ b/packages/mergebot/src/_tests/fixtures/68908/derived.json @@ -17,6 +17,7 @@ "pkgInfo": [ { "name": "node", + "version": "20.11", "kind": "edit", "files": [ { diff --git a/packages/mergebot/src/_tests/fixtures/68908/mutations.json b/packages/mergebot/src/_tests/fixtures/68908/mutations.json index e397b954df..5c65e53352 100644 --- a/packages/mergebot/src/_tests/fixtures/68908/mutations.json +++ b/packages/mergebot/src/_tests/fixtures/68908/mutations.json @@ -4,7 +4,7 @@ "variables": { "input": { "id": "IC_kwDOAFz6BM52Yyvs", - "body": "@jakebailey Thank you for submitting this PR!\n\n***This is a live comment that I will keep updated.***\n\n## 1 package in this PR\n\n* `node` — [on npm](https://www.npmjs.com/package/node), [on unpkg](https://unpkg.com/browse/node@latest/)\n - Config files to check:\n - [`node/ts4.8/scripts/generate-docs/.gitignore`](https://github.com/DefinitelyTyped/DefinitelyTyped/pull/68908/files/b3eeaef096e86260fb5300d4e289257112644f86#diff-91526815b4e9495a4a3c4fc39e0d0ec54cfde836d5fba3a1ed2357f249d7cba7): edited\n - [`node/ts4.8/scripts/generate-inspector/inspector.d.ts.template`](https://github.com/DefinitelyTyped/DefinitelyTyped/pull/68908/files/b3eeaef096e86260fb5300d4e289257112644f86#diff-451f80f4367421783eca707351dd71c71207e031bc5dff3a4d0b95058e84c7f7): edited\n\n## Code Reviews\n\nBecause this is a widely-used package, a DT maintainer will need to review it before it can be merged.\n\nYou can test the changes of this PR [in the Playground](https://www.typescriptlang.org/play/?dtPR=68908&install-plugin=playground-dt-review).\n\n## Status\n\n * ✅ No merge conflicts\n * 🕐 Continuous integration tests are still running\n * 🕐 A DT maintainer needs to approve changes that affect module config files\n\nOnce every item on this list is checked, I'll ask you for permission to merge and publish the changes.\n\n----------------------\n... diagnostics scrubbed ...\n" + "body": "@jakebailey Thank you for submitting this PR!\n\n***This is a live comment that I will keep updated.***\n\n## 1 package in this PR\n\n* `node` (20.11) — [on npm](https://www.npmjs.com/package/node), [on unpkg](https://unpkg.com/browse/node@latest/)\n - Config files to check:\n - [`node/ts4.8/scripts/generate-docs/.gitignore`](https://github.com/DefinitelyTyped/DefinitelyTyped/pull/68908/files/b3eeaef096e86260fb5300d4e289257112644f86#diff-91526815b4e9495a4a3c4fc39e0d0ec54cfde836d5fba3a1ed2357f249d7cba7): edited\n - [`node/ts4.8/scripts/generate-inspector/inspector.d.ts.template`](https://github.com/DefinitelyTyped/DefinitelyTyped/pull/68908/files/b3eeaef096e86260fb5300d4e289257112644f86#diff-451f80f4367421783eca707351dd71c71207e031bc5dff3a4d0b95058e84c7f7): edited\n\n## Code Reviews\n\nBecause this is a widely-used package, a DT maintainer will need to review it before it can be merged.\n\nYou can test the changes of this PR [in the Playground](https://www.typescriptlang.org/play/?dtPR=68908&install-plugin=playground-dt-review).\n\n## Status\n\n * ✅ No merge conflicts\n * 🕐 Continuous integration tests are still running\n * 🕐 A DT maintainer needs to approve changes that affect module config files\n\nOnce every item on this list is checked, I'll ask you for permission to merge and publish the changes.\n\n----------------------\n... diagnostics scrubbed ...\n" } } } diff --git a/packages/mergebot/src/_tests/fixtures/68908/result.json b/packages/mergebot/src/_tests/fixtures/68908/result.json index 1f5960de6e..d28f9d101c 100644 --- a/packages/mergebot/src/_tests/fixtures/68908/result.json +++ b/packages/mergebot/src/_tests/fixtures/68908/result.json @@ -8,7 +8,7 @@ "responseComments": [ { "tag": "welcome", - "status": "@jakebailey Thank you for submitting this PR!\n\n***This is a live comment that I will keep updated.***\n\n## 1 package in this PR\n\n* `node` — [on npm](https://www.npmjs.com/package/node), [on unpkg](https://unpkg.com/browse/node@latest/)\n - Config files to check:\n - [`node/ts4.8/scripts/generate-docs/.gitignore`](https://github.com/DefinitelyTyped/DefinitelyTyped/pull/68908/files/b3eeaef096e86260fb5300d4e289257112644f86#diff-91526815b4e9495a4a3c4fc39e0d0ec54cfde836d5fba3a1ed2357f249d7cba7): edited\n - [`node/ts4.8/scripts/generate-inspector/inspector.d.ts.template`](https://github.com/DefinitelyTyped/DefinitelyTyped/pull/68908/files/b3eeaef096e86260fb5300d4e289257112644f86#diff-451f80f4367421783eca707351dd71c71207e031bc5dff3a4d0b95058e84c7f7): edited\n\n## Code Reviews\n\nBecause this is a widely-used package, a DT maintainer will need to review it before it can be merged.\n\nYou can test the changes of this PR [in the Playground](https://www.typescriptlang.org/play/?dtPR=68908&install-plugin=playground-dt-review).\n\n## Status\n\n * ✅ No merge conflicts\n * 🕐 Continuous integration tests are still running\n * 🕐 A DT maintainer needs to approve changes that affect module config files\n\nOnce every item on this list is checked, I'll ask you for permission to merge and publish the changes.\n\n----------------------\n... diagnostics scrubbed ..." + "status": "@jakebailey Thank you for submitting this PR!\n\n***This is a live comment that I will keep updated.***\n\n## 1 package in this PR\n\n* `node` (20.11) — [on npm](https://www.npmjs.com/package/node), [on unpkg](https://unpkg.com/browse/node@latest/)\n - Config files to check:\n - [`node/ts4.8/scripts/generate-docs/.gitignore`](https://github.com/DefinitelyTyped/DefinitelyTyped/pull/68908/files/b3eeaef096e86260fb5300d4e289257112644f86#diff-91526815b4e9495a4a3c4fc39e0d0ec54cfde836d5fba3a1ed2357f249d7cba7): edited\n - [`node/ts4.8/scripts/generate-inspector/inspector.d.ts.template`](https://github.com/DefinitelyTyped/DefinitelyTyped/pull/68908/files/b3eeaef096e86260fb5300d4e289257112644f86#diff-451f80f4367421783eca707351dd71c71207e031bc5dff3a4d0b95058e84c7f7): edited\n\n## Code Reviews\n\nBecause this is a widely-used package, a DT maintainer will need to review it before it can be merged.\n\nYou can test the changes of this PR [in the Playground](https://www.typescriptlang.org/play/?dtPR=68908&install-plugin=playground-dt-review).\n\n## Status\n\n * ✅ No merge conflicts\n * 🕐 Continuous integration tests are still running\n * 🕐 A DT maintainer needs to approve changes that affect module config files\n\nOnce every item on this list is checked, I'll ask you for permission to merge and publish the changes.\n\n----------------------\n... diagnostics scrubbed ..." }, { "tag": "pinging-reviewers", diff --git a/packages/mergebot/src/_tests/fixtures/69589/derived.json b/packages/mergebot/src/_tests/fixtures/69589/derived.json index ac95deed02..7585e40de8 100644 --- a/packages/mergebot/src/_tests/fixtures/69589/derived.json +++ b/packages/mergebot/src/_tests/fixtures/69589/derived.json @@ -17,6 +17,7 @@ "pkgInfo": [ { "name": "readable-stream", + "version": "4.0", "kind": "edit", "files": [ { diff --git a/packages/mergebot/src/_tests/fixtures/69589/mutations.json b/packages/mergebot/src/_tests/fixtures/69589/mutations.json index 9343d44b75..49d404d84a 100644 --- a/packages/mergebot/src/_tests/fixtures/69589/mutations.json +++ b/packages/mergebot/src/_tests/fixtures/69589/mutations.json @@ -4,7 +4,7 @@ "variables": { "input": { "id": "IC_kwDOAFz6BM59n4sP", - "body": "@mcollina Thank you for submitting this PR!\n\n***This is a live comment that I will keep updated.***\n\n## 1 package in this PR\n\n* `readable-stream` — [on npm](https://www.npmjs.com/package/readable-stream), [on unpkg](https://unpkg.com/browse/readable-stream@latest/)\n - 1 added owner: ✎@mcollina\n\n## Code Reviews\n\nBecause this is a widely-used package, a DT maintainer will need to review it before it can be merged.\n\nYou can test the changes of this PR [in the Playground](https://www.typescriptlang.org/play/?dtPR=69589&install-plugin=playground-dt-review).\n\n## Status\n\n * ✅ No merge conflicts\n * ✅ Continuous integration tests have passed\n * 🕐 Most recent commit is approved by a DT maintainer\n\nOnce every item on this list is checked, I'll ask you for permission to merge and publish the changes.\n\n----------------------\n... diagnostics scrubbed ...\n" + "body": "@mcollina Thank you for submitting this PR!\n\n***This is a live comment that I will keep updated.***\n\n## 1 package in this PR\n\n* `readable-stream` (4.0) — [on npm](https://www.npmjs.com/package/readable-stream), [on unpkg](https://unpkg.com/browse/readable-stream@latest/)\n - 1 added owner: ✎@mcollina\n\n## Code Reviews\n\nBecause this is a widely-used package, a DT maintainer will need to review it before it can be merged.\n\nYou can test the changes of this PR [in the Playground](https://www.typescriptlang.org/play/?dtPR=69589&install-plugin=playground-dt-review).\n\n## Status\n\n * ✅ No merge conflicts\n * ✅ Continuous integration tests have passed\n * 🕐 Most recent commit is approved by a DT maintainer\n\nOnce every item on this list is checked, I'll ask you for permission to merge and publish the changes.\n\n----------------------\n... diagnostics scrubbed ...\n" } } }, diff --git a/packages/mergebot/src/_tests/fixtures/69589/result.json b/packages/mergebot/src/_tests/fixtures/69589/result.json index 162b4fae80..69406d4694 100644 --- a/packages/mergebot/src/_tests/fixtures/69589/result.json +++ b/packages/mergebot/src/_tests/fixtures/69589/result.json @@ -7,7 +7,7 @@ "responseComments": [ { "tag": "welcome", - "status": "@mcollina Thank you for submitting this PR!\n\n***This is a live comment that I will keep updated.***\n\n## 1 package in this PR\n\n* `readable-stream` — [on npm](https://www.npmjs.com/package/readable-stream), [on unpkg](https://unpkg.com/browse/readable-stream@latest/)\n - 1 added owner: ✎@mcollina\n\n## Code Reviews\n\nBecause this is a widely-used package, a DT maintainer will need to review it before it can be merged.\n\nYou can test the changes of this PR [in the Playground](https://www.typescriptlang.org/play/?dtPR=69589&install-plugin=playground-dt-review).\n\n## Status\n\n * ✅ No merge conflicts\n * ✅ Continuous integration tests have passed\n * 🕐 Most recent commit is approved by a DT maintainer\n\nOnce every item on this list is checked, I'll ask you for permission to merge and publish the changes.\n\n----------------------\n... diagnostics scrubbed ..." + "status": "@mcollina Thank you for submitting this PR!\n\n***This is a live comment that I will keep updated.***\n\n## 1 package in this PR\n\n* `readable-stream` (4.0) — [on npm](https://www.npmjs.com/package/readable-stream), [on unpkg](https://unpkg.com/browse/readable-stream@latest/)\n - 1 added owner: ✎@mcollina\n\n## Code Reviews\n\nBecause this is a widely-used package, a DT maintainer will need to review it before it can be merged.\n\nYou can test the changes of this PR [in the Playground](https://www.typescriptlang.org/play/?dtPR=69589&install-plugin=playground-dt-review).\n\n## Status\n\n * ✅ No merge conflicts\n * ✅ Continuous integration tests have passed\n * 🕐 Most recent commit is approved by a DT maintainer\n\nOnce every item on this list is checked, I'll ask you for permission to merge and publish the changes.\n\n----------------------\n... diagnostics scrubbed ..." }, { "tag": "pinging-reviewers", diff --git a/packages/mergebot/src/_tests/fixtures/69997/derived.json b/packages/mergebot/src/_tests/fixtures/69997/derived.json index 02d33915da..095d71705e 100644 --- a/packages/mergebot/src/_tests/fixtures/69997/derived.json +++ b/packages/mergebot/src/_tests/fixtures/69997/derived.json @@ -17,6 +17,7 @@ "pkgInfo": [ { "name": "imap", + "version": "0.8", "kind": "edit", "files": [ { @@ -33,6 +34,7 @@ }, { "name": "jake", + "version": "0.0", "kind": "edit", "files": [ { @@ -47,6 +49,7 @@ }, { "name": "newman", + "version": "5.3", "kind": "edit", "files": [ { @@ -63,6 +66,7 @@ }, { "name": "node-red", + "version": "1.3", "kind": "edit", "files": [ { @@ -83,6 +87,7 @@ }, { "name": "node", + "version": "22.7", "kind": "edit", "files": [ { @@ -177,6 +182,7 @@ }, { "name": "opossum", + "version": "8.1", "kind": "edit", "files": [ { @@ -197,6 +203,7 @@ }, { "name": "rdf-store-fs", + "version": "1.1", "kind": "edit", "files": [ { @@ -213,6 +220,7 @@ }, { "name": "readable-stream", + "version": "4.0", "kind": "edit", "files": [ { @@ -231,6 +239,7 @@ }, { "name": "sane", + "version": "2.0", "kind": "edit", "files": [ { @@ -247,6 +256,7 @@ }, { "name": "sse", + "version": "0.0", "kind": "edit", "files": [ { @@ -263,6 +273,7 @@ }, { "name": "steam", + "version": "0.0", "kind": "edit", "files": [ { @@ -279,6 +290,7 @@ }, { "name": "twitter", + "version": "1.7", "kind": "edit", "files": [ { @@ -295,6 +307,7 @@ }, { "name": "umzug", + "version": "2.3", "kind": "edit", "files": [ { @@ -314,6 +327,7 @@ }, { "name": "xml-flow", + "version": "1.0", "kind": "edit", "files": [ { diff --git a/packages/mergebot/src/_tests/fixtures/69997/mutations.json b/packages/mergebot/src/_tests/fixtures/69997/mutations.json index c39fe18007..5e8b577b9e 100644 --- a/packages/mergebot/src/_tests/fixtures/69997/mutations.json +++ b/packages/mergebot/src/_tests/fixtures/69997/mutations.json @@ -4,7 +4,7 @@ "variables": { "input": { "id": "IC_kwDOAFz6BM6D48lN", - "body": "@ckohen Thank you for submitting this PR! I see this is your first time submitting to DefinitelyTyped 👋 — I'm the local bot who will help you through the process of getting things through.\n\n***This is a live comment that I will keep updated.***\n\n## 14 packages in this PR\n\n* `imap` — [on npm](https://www.npmjs.com/package/imap), [on unpkg](https://unpkg.com/browse/imap@latest/)\n* `jake` — [on npm](https://www.npmjs.com/package/jake), [on unpkg](https://unpkg.com/browse/jake@latest/)\n* `newman` — [on npm](https://www.npmjs.com/package/newman), [on unpkg](https://unpkg.com/browse/newman@latest/)\n* `node-red` — [on npm](https://www.npmjs.com/package/node-red), [on unpkg](https://unpkg.com/browse/node-red@latest/)\n* `node` — [on npm](https://www.npmjs.com/package/node), [on unpkg](https://unpkg.com/browse/node@latest/)\n* `opossum` — [on npm](https://www.npmjs.com/package/opossum), [on unpkg](https://unpkg.com/browse/opossum@latest/)\n* `rdf-store-fs` — [on npm](https://www.npmjs.com/package/rdf-store-fs), [on unpkg](https://unpkg.com/browse/rdf-store-fs@latest/)\n* `readable-stream` — [on npm](https://www.npmjs.com/package/readable-stream), [on unpkg](https://unpkg.com/browse/readable-stream@latest/)\n* `sane` — [on npm](https://www.npmjs.com/package/sane), [on unpkg](https://unpkg.com/browse/sane@latest/)\n* `sse` — [on npm](https://www.npmjs.com/package/sse), [on unpkg](https://unpkg.com/browse/sse@latest/)\n* `steam` — [on npm](https://www.npmjs.com/package/steam), [on unpkg](https://unpkg.com/browse/steam@latest/)\n* `twitter` — [on npm](https://www.npmjs.com/package/twitter), [on unpkg](https://unpkg.com/browse/twitter@latest/)\n* `umzug` — [on npm](https://www.npmjs.com/package/umzug), [on unpkg](https://unpkg.com/browse/umzug@latest/)\n* `xml-flow` — [on npm](https://www.npmjs.com/package/xml-flow), [on unpkg](https://unpkg.com/browse/xml-flow@latest/)\n\n## Code Reviews\n\nBecause this is a widely-used package, a DT maintainer will need to review it before it can be merged.\n\nYou can test the changes of this PR [in the Playground](https://www.typescriptlang.org/play/?dtPR=69997&install-plugin=playground-dt-review).\n\n## Status\n\n * ❌ No merge conflicts\n * ✅ Continuous integration tests have passed\n * 🕐 A DT maintainer needs to approve changes that affect more than one package\n\nOnce every item on this list is checked, I'll ask you for permission to merge and publish the changes.\n\n----------------------\n... diagnostics scrubbed ...\n" + "body": "@ckohen Thank you for submitting this PR! I see this is your first time submitting to DefinitelyTyped 👋 — I'm the local bot who will help you through the process of getting things through.\n\n***This is a live comment that I will keep updated.***\n\n## 14 packages in this PR\n\n* `imap` (0.8) — [on npm](https://www.npmjs.com/package/imap), [on unpkg](https://unpkg.com/browse/imap@latest/)\n* `jake` (0.0) — [on npm](https://www.npmjs.com/package/jake), [on unpkg](https://unpkg.com/browse/jake@latest/)\n* `newman` (5.3) — [on npm](https://www.npmjs.com/package/newman), [on unpkg](https://unpkg.com/browse/newman@latest/)\n* `node-red` (1.3) — [on npm](https://www.npmjs.com/package/node-red), [on unpkg](https://unpkg.com/browse/node-red@latest/)\n* `node` (22.7) — [on npm](https://www.npmjs.com/package/node), [on unpkg](https://unpkg.com/browse/node@latest/)\n* `opossum` (8.1) — [on npm](https://www.npmjs.com/package/opossum), [on unpkg](https://unpkg.com/browse/opossum@latest/)\n* `rdf-store-fs` (1.1) — [on npm](https://www.npmjs.com/package/rdf-store-fs), [on unpkg](https://unpkg.com/browse/rdf-store-fs@latest/)\n* `readable-stream` (4.0) — [on npm](https://www.npmjs.com/package/readable-stream), [on unpkg](https://unpkg.com/browse/readable-stream@latest/)\n* `sane` (2.0) — [on npm](https://www.npmjs.com/package/sane), [on unpkg](https://unpkg.com/browse/sane@latest/)\n* `sse` (0.0) — [on npm](https://www.npmjs.com/package/sse), [on unpkg](https://unpkg.com/browse/sse@latest/)\n* `steam` (0.0) — [on npm](https://www.npmjs.com/package/steam), [on unpkg](https://unpkg.com/browse/steam@latest/)\n* `twitter` (1.7) — [on npm](https://www.npmjs.com/package/twitter), [on unpkg](https://unpkg.com/browse/twitter@latest/)\n* `umzug` (2.3) — [on npm](https://www.npmjs.com/package/umzug), [on unpkg](https://unpkg.com/browse/umzug@latest/)\n* `xml-flow` (1.0) — [on npm](https://www.npmjs.com/package/xml-flow), [on unpkg](https://unpkg.com/browse/xml-flow@latest/)\n\n## Code Reviews\n\nBecause this is a widely-used package, a DT maintainer will need to review it before it can be merged.\n\nYou can test the changes of this PR [in the Playground](https://www.typescriptlang.org/play/?dtPR=69997&install-plugin=playground-dt-review).\n\n## Status\n\n * ❌ No merge conflicts\n * ✅ Continuous integration tests have passed\n * 🕐 A DT maintainer needs to approve changes that affect more than one package\n\nOnce every item on this list is checked, I'll ask you for permission to merge and publish the changes.\n\n----------------------\n... diagnostics scrubbed ...\n" } } }, diff --git a/packages/mergebot/src/_tests/fixtures/69997/result.json b/packages/mergebot/src/_tests/fixtures/69997/result.json index 3c7fb9131a..27a7f29ff8 100644 --- a/packages/mergebot/src/_tests/fixtures/69997/result.json +++ b/packages/mergebot/src/_tests/fixtures/69997/result.json @@ -9,7 +9,7 @@ "responseComments": [ { "tag": "welcome", - "status": "@ckohen Thank you for submitting this PR! I see this is your first time submitting to DefinitelyTyped 👋 — I'm the local bot who will help you through the process of getting things through.\n\n***This is a live comment that I will keep updated.***\n\n## 14 packages in this PR\n\n* `imap` — [on npm](https://www.npmjs.com/package/imap), [on unpkg](https://unpkg.com/browse/imap@latest/)\n* `jake` — [on npm](https://www.npmjs.com/package/jake), [on unpkg](https://unpkg.com/browse/jake@latest/)\n* `newman` — [on npm](https://www.npmjs.com/package/newman), [on unpkg](https://unpkg.com/browse/newman@latest/)\n* `node-red` — [on npm](https://www.npmjs.com/package/node-red), [on unpkg](https://unpkg.com/browse/node-red@latest/)\n* `node` — [on npm](https://www.npmjs.com/package/node), [on unpkg](https://unpkg.com/browse/node@latest/)\n* `opossum` — [on npm](https://www.npmjs.com/package/opossum), [on unpkg](https://unpkg.com/browse/opossum@latest/)\n* `rdf-store-fs` — [on npm](https://www.npmjs.com/package/rdf-store-fs), [on unpkg](https://unpkg.com/browse/rdf-store-fs@latest/)\n* `readable-stream` — [on npm](https://www.npmjs.com/package/readable-stream), [on unpkg](https://unpkg.com/browse/readable-stream@latest/)\n* `sane` — [on npm](https://www.npmjs.com/package/sane), [on unpkg](https://unpkg.com/browse/sane@latest/)\n* `sse` — [on npm](https://www.npmjs.com/package/sse), [on unpkg](https://unpkg.com/browse/sse@latest/)\n* `steam` — [on npm](https://www.npmjs.com/package/steam), [on unpkg](https://unpkg.com/browse/steam@latest/)\n* `twitter` — [on npm](https://www.npmjs.com/package/twitter), [on unpkg](https://unpkg.com/browse/twitter@latest/)\n* `umzug` — [on npm](https://www.npmjs.com/package/umzug), [on unpkg](https://unpkg.com/browse/umzug@latest/)\n* `xml-flow` — [on npm](https://www.npmjs.com/package/xml-flow), [on unpkg](https://unpkg.com/browse/xml-flow@latest/)\n\n## Code Reviews\n\nBecause this is a widely-used package, a DT maintainer will need to review it before it can be merged.\n\nYou can test the changes of this PR [in the Playground](https://www.typescriptlang.org/play/?dtPR=69997&install-plugin=playground-dt-review).\n\n## Status\n\n * ❌ No merge conflicts\n * ✅ Continuous integration tests have passed\n * 🕐 A DT maintainer needs to approve changes that affect more than one package\n\nOnce every item on this list is checked, I'll ask you for permission to merge and publish the changes.\n\n----------------------\n... diagnostics scrubbed ..." + "status": "@ckohen Thank you for submitting this PR! I see this is your first time submitting to DefinitelyTyped 👋 — I'm the local bot who will help you through the process of getting things through.\n\n***This is a live comment that I will keep updated.***\n\n## 14 packages in this PR\n\n* `imap` (0.8) — [on npm](https://www.npmjs.com/package/imap), [on unpkg](https://unpkg.com/browse/imap@latest/)\n* `jake` (0.0) — [on npm](https://www.npmjs.com/package/jake), [on unpkg](https://unpkg.com/browse/jake@latest/)\n* `newman` (5.3) — [on npm](https://www.npmjs.com/package/newman), [on unpkg](https://unpkg.com/browse/newman@latest/)\n* `node-red` (1.3) — [on npm](https://www.npmjs.com/package/node-red), [on unpkg](https://unpkg.com/browse/node-red@latest/)\n* `node` (22.7) — [on npm](https://www.npmjs.com/package/node), [on unpkg](https://unpkg.com/browse/node@latest/)\n* `opossum` (8.1) — [on npm](https://www.npmjs.com/package/opossum), [on unpkg](https://unpkg.com/browse/opossum@latest/)\n* `rdf-store-fs` (1.1) — [on npm](https://www.npmjs.com/package/rdf-store-fs), [on unpkg](https://unpkg.com/browse/rdf-store-fs@latest/)\n* `readable-stream` (4.0) — [on npm](https://www.npmjs.com/package/readable-stream), [on unpkg](https://unpkg.com/browse/readable-stream@latest/)\n* `sane` (2.0) — [on npm](https://www.npmjs.com/package/sane), [on unpkg](https://unpkg.com/browse/sane@latest/)\n* `sse` (0.0) — [on npm](https://www.npmjs.com/package/sse), [on unpkg](https://unpkg.com/browse/sse@latest/)\n* `steam` (0.0) — [on npm](https://www.npmjs.com/package/steam), [on unpkg](https://unpkg.com/browse/steam@latest/)\n* `twitter` (1.7) — [on npm](https://www.npmjs.com/package/twitter), [on unpkg](https://unpkg.com/browse/twitter@latest/)\n* `umzug` (2.3) — [on npm](https://www.npmjs.com/package/umzug), [on unpkg](https://unpkg.com/browse/umzug@latest/)\n* `xml-flow` (1.0) — [on npm](https://www.npmjs.com/package/xml-flow), [on unpkg](https://unpkg.com/browse/xml-flow@latest/)\n\n## Code Reviews\n\nBecause this is a widely-used package, a DT maintainer will need to review it before it can be merged.\n\nYou can test the changes of this PR [in the Playground](https://www.typescriptlang.org/play/?dtPR=69997&install-plugin=playground-dt-review).\n\n## Status\n\n * ❌ No merge conflicts\n * ✅ Continuous integration tests have passed\n * 🕐 A DT maintainer needs to approve changes that affect more than one package\n\nOnce every item on this list is checked, I'll ask you for permission to merge and publish the changes.\n\n----------------------\n... diagnostics scrubbed ..." }, { "tag": "pinging-reviewers-too-many", diff --git a/packages/mergebot/src/_tests/fixtures/70024/derived.json b/packages/mergebot/src/_tests/fixtures/70024/derived.json index 66b00be67c..723e48b9e8 100644 --- a/packages/mergebot/src/_tests/fixtures/70024/derived.json +++ b/packages/mergebot/src/_tests/fixtures/70024/derived.json @@ -19,6 +19,7 @@ "pkgInfo": [ { "name": "ws", + "version": "8.5", "kind": "edit", "files": [ { diff --git a/packages/mergebot/src/_tests/fixtures/70024/mutations.json b/packages/mergebot/src/_tests/fixtures/70024/mutations.json index eeac231fcd..2f873dfae8 100644 --- a/packages/mergebot/src/_tests/fixtures/70024/mutations.json +++ b/packages/mergebot/src/_tests/fixtures/70024/mutations.json @@ -4,7 +4,7 @@ "variables": { "input": { "id": "IC_kwDOAFz6BM6EY4ad", - "body": "@ITenthusiasm Thank you for submitting this PR!\n\n***This is a live comment that I will keep updated.***\n\n## 1 package in this PR\n\n* `ws` — [on npm](https://www.npmjs.com/package/ws), [on unpkg](https://unpkg.com/browse/ws@latest/)\n - owner-approval: @k-yle\n\n## Code Reviews\n\nBecause this is a widely-used package, a DT maintainer will need to review it before it can be merged.\n\nYou can test the changes of this PR [in the Playground](https://www.typescriptlang.org/play/?dtPR=70024&install-plugin=playground-dt-review).\n\n## Status\n\n * ✅ No merge conflicts\n * ✅ Continuous integration tests have passed\n * ✅ Most recent commit is approved by a DT maintainer\n\nAll of the items on the list are green. **To merge, you need to post a comment including the string \"Ready to merge\"** to bring in your changes.\n\n----------------------\n... diagnostics scrubbed ...\n" + "body": "@ITenthusiasm Thank you for submitting this PR!\n\n***This is a live comment that I will keep updated.***\n\n## 1 package in this PR\n\n* `ws` (8.5) — [on npm](https://www.npmjs.com/package/ws), [on unpkg](https://unpkg.com/browse/ws@latest/)\n - owner-approval: @k-yle\n\n## Code Reviews\n\nBecause this is a widely-used package, a DT maintainer will need to review it before it can be merged.\n\nYou can test the changes of this PR [in the Playground](https://www.typescriptlang.org/play/?dtPR=70024&install-plugin=playground-dt-review).\n\n## Status\n\n * ✅ No merge conflicts\n * ✅ Continuous integration tests have passed\n * ✅ Most recent commit is approved by a DT maintainer\n\nAll of the items on the list are green. **To merge, you need to post a comment including the string \"Ready to merge\"** to bring in your changes.\n\n----------------------\n... diagnostics scrubbed ...\n" } } }, diff --git a/packages/mergebot/src/_tests/fixtures/70024/result.json b/packages/mergebot/src/_tests/fixtures/70024/result.json index ad93c978c4..600053491c 100644 --- a/packages/mergebot/src/_tests/fixtures/70024/result.json +++ b/packages/mergebot/src/_tests/fixtures/70024/result.json @@ -9,7 +9,7 @@ "responseComments": [ { "tag": "welcome", - "status": "@ITenthusiasm Thank you for submitting this PR!\n\n***This is a live comment that I will keep updated.***\n\n## 1 package in this PR\n\n* `ws` — [on npm](https://www.npmjs.com/package/ws), [on unpkg](https://unpkg.com/browse/ws@latest/)\n - owner-approval: @k-yle\n\n## Code Reviews\n\nBecause this is a widely-used package, a DT maintainer will need to review it before it can be merged.\n\nYou can test the changes of this PR [in the Playground](https://www.typescriptlang.org/play/?dtPR=70024&install-plugin=playground-dt-review).\n\n## Status\n\n * ✅ No merge conflicts\n * ✅ Continuous integration tests have passed\n * ✅ Most recent commit is approved by a DT maintainer\n\nAll of the items on the list are green. **To merge, you need to post a comment including the string \"Ready to merge\"** to bring in your changes.\n\n----------------------\n... diagnostics scrubbed ..." + "status": "@ITenthusiasm Thank you for submitting this PR!\n\n***This is a live comment that I will keep updated.***\n\n## 1 package in this PR\n\n* `ws` (8.5) — [on npm](https://www.npmjs.com/package/ws), [on unpkg](https://unpkg.com/browse/ws@latest/)\n - owner-approval: @k-yle\n\n## Code Reviews\n\nBecause this is a widely-used package, a DT maintainer will need to review it before it can be merged.\n\nYou can test the changes of this PR [in the Playground](https://www.typescriptlang.org/play/?dtPR=70024&install-plugin=playground-dt-review).\n\n## Status\n\n * ✅ No merge conflicts\n * ✅ Continuous integration tests have passed\n * ✅ Most recent commit is approved by a DT maintainer\n\nAll of the items on the list are green. **To merge, you need to post a comment including the string \"Ready to merge\"** to bring in your changes.\n\n----------------------\n... diagnostics scrubbed ..." }, { "tag": "merge-offer", diff --git a/packages/mergebot/src/_tests/fixtures/70150/derived.json b/packages/mergebot/src/_tests/fixtures/70150/derived.json index 151b978fbd..e03be108f3 100644 --- a/packages/mergebot/src/_tests/fixtures/70150/derived.json +++ b/packages/mergebot/src/_tests/fixtures/70150/derived.json @@ -18,6 +18,7 @@ "pkgInfo": [ { "name": "chrome", + "version": "0.0", "kind": "edit", "files": [ { diff --git a/packages/mergebot/src/_tests/fixtures/70150/mutations.json b/packages/mergebot/src/_tests/fixtures/70150/mutations.json index 12d9a67110..5edcb50714 100644 --- a/packages/mergebot/src/_tests/fixtures/70150/mutations.json +++ b/packages/mergebot/src/_tests/fixtures/70150/mutations.json @@ -4,7 +4,7 @@ "variables": { "input": { "id": "IC_kwDOAFz6BM6GXLU7", - "body": "@sebasjm Thank you for submitting this PR! I see this is your first time submitting to DefinitelyTyped 👋 — I'm the local bot who will help you through the process of getting things through.\n\n***This is a live comment that I will keep updated.***\n\n## 1 package in this PR\n\n* `chrome` — [on npm](https://www.npmjs.com/package/chrome), [on unpkg](https://unpkg.com/browse/chrome@latest/)\n - owner-approval: @nicolas377\n\n## Code Reviews\n\nThis PR can be merged once it's reviewed.\n\nYou can test the changes of this PR [in the Playground](https://www.typescriptlang.org/play/?dtPR=70150&install-plugin=playground-dt-review).\n\n## Status\n\n * ✅ No merge conflicts\n * ✅ Continuous integration tests have passed\n * ✅ Most recent commit is approved by type definition owners or DT maintainers\n\nAll of the items on the list are green. **To merge, you need to post a comment including the string \"Ready to merge\"** to bring in your changes.\n\n----------------------\n... diagnostics scrubbed ...\n" + "body": "@sebasjm Thank you for submitting this PR! I see this is your first time submitting to DefinitelyTyped 👋 — I'm the local bot who will help you through the process of getting things through.\n\n***This is a live comment that I will keep updated.***\n\n## 1 package in this PR\n\n* `chrome` (0.0) — [on npm](https://www.npmjs.com/package/chrome), [on unpkg](https://unpkg.com/browse/chrome@latest/)\n - owner-approval: @nicolas377\n\n## Code Reviews\n\nThis PR can be merged once it's reviewed.\n\nYou can test the changes of this PR [in the Playground](https://www.typescriptlang.org/play/?dtPR=70150&install-plugin=playground-dt-review).\n\n## Status\n\n * ✅ No merge conflicts\n * ✅ Continuous integration tests have passed\n * ✅ Most recent commit is approved by type definition owners or DT maintainers\n\nAll of the items on the list are green. **To merge, you need to post a comment including the string \"Ready to merge\"** to bring in your changes.\n\n----------------------\n... diagnostics scrubbed ...\n" } } }, diff --git a/packages/mergebot/src/_tests/fixtures/70150/result.json b/packages/mergebot/src/_tests/fixtures/70150/result.json index 4d40a4b6bb..1f17440924 100644 --- a/packages/mergebot/src/_tests/fixtures/70150/result.json +++ b/packages/mergebot/src/_tests/fixtures/70150/result.json @@ -13,7 +13,7 @@ }, { "tag": "welcome", - "status": "@sebasjm Thank you for submitting this PR! I see this is your first time submitting to DefinitelyTyped 👋 — I'm the local bot who will help you through the process of getting things through.\n\n***This is a live comment that I will keep updated.***\n\n## 1 package in this PR\n\n* `chrome` — [on npm](https://www.npmjs.com/package/chrome), [on unpkg](https://unpkg.com/browse/chrome@latest/)\n - owner-approval: @nicolas377\n\n## Code Reviews\n\nThis PR can be merged once it's reviewed.\n\nYou can test the changes of this PR [in the Playground](https://www.typescriptlang.org/play/?dtPR=70150&install-plugin=playground-dt-review).\n\n## Status\n\n * ✅ No merge conflicts\n * ✅ Continuous integration tests have passed\n * ✅ Most recent commit is approved by type definition owners or DT maintainers\n\nAll of the items on the list are green. **To merge, you need to post a comment including the string \"Ready to merge\"** to bring in your changes.\n\n----------------------\n... diagnostics scrubbed ..." + "status": "@sebasjm Thank you for submitting this PR! I see this is your first time submitting to DefinitelyTyped 👋 — I'm the local bot who will help you through the process of getting things through.\n\n***This is a live comment that I will keep updated.***\n\n## 1 package in this PR\n\n* `chrome` (0.0) — [on npm](https://www.npmjs.com/package/chrome), [on unpkg](https://unpkg.com/browse/chrome@latest/)\n - owner-approval: @nicolas377\n\n## Code Reviews\n\nThis PR can be merged once it's reviewed.\n\nYou can test the changes of this PR [in the Playground](https://www.typescriptlang.org/play/?dtPR=70150&install-plugin=playground-dt-review).\n\n## Status\n\n * ✅ No merge conflicts\n * ✅ Continuous integration tests have passed\n * ✅ Most recent commit is approved by type definition owners or DT maintainers\n\nAll of the items on the list are green. **To merge, you need to post a comment including the string \"Ready to merge\"** to bring in your changes.\n\n----------------------\n... diagnostics scrubbed ..." }, { "tag": "merge-offer", diff --git a/packages/mergebot/src/_tests/fixtures/70218/derived.json b/packages/mergebot/src/_tests/fixtures/70218/derived.json index fe165b6161..4984adfd08 100644 --- a/packages/mergebot/src/_tests/fixtures/70218/derived.json +++ b/packages/mergebot/src/_tests/fixtures/70218/derived.json @@ -17,6 +17,7 @@ "pkgInfo": [ { "name": "fast-decode-uri-component", + "version": "0.1", "kind": "add", "files": [ { diff --git a/packages/mergebot/src/_tests/fixtures/70218/mutations.json b/packages/mergebot/src/_tests/fixtures/70218/mutations.json index f0574445a4..8afafe2704 100644 --- a/packages/mergebot/src/_tests/fixtures/70218/mutations.json +++ b/packages/mergebot/src/_tests/fixtures/70218/mutations.json @@ -4,7 +4,7 @@ "variables": { "input": { "id": "IC_kwDOAFz6BM6HPuRc", - "body": "@huseeiin Thank you for submitting this PR! I see this is your first time submitting to DefinitelyTyped 👋 — I'm the local bot who will help you through the process of getting things through.\n\n***This is a live comment that I will keep updated.***\n\n## 1 package in this PR\n\n* `fast-decode-uri-component` (*new!*) — [on npm](https://www.npmjs.com/package/fast-decode-uri-component), [on unpkg](https://unpkg.com/browse/fast-decode-uri-component@latest/)\n - 1 added owner: ✎@huseeiin\n - Config files to check:\n - [`fast-decode-uri-component/tsconfig.json`](https://github.com/DefinitelyTyped/DefinitelyTyped/pull/70218/files/b40b94cbeb5441526e8ef39ff8684258f16d0514#diff-533ae5a3ce61574804bc5074b19ca431b11098f32353f7a2325b96ec0a72e686): not [the expected form](https://github.com/DefinitelyTyped/DefinitelyTyped#user-content-tsconfigjson) (check: `compilerOptions`)\n\n## Code Reviews\n\nThis PR adds a new definition, so it needs to be reviewed by a DT maintainer before it can be merged.\n\nYou can test the changes of this PR [in the Playground](https://www.typescriptlang.org/play/?dtPR=70218&install-plugin=playground-dt-review).\n\n## Status\n\n * ✅ No merge conflicts\n * ❌ Continuous integration tests have failed\n * 🕐 Only a DT maintainer can approve changes when there are new packages added\n\nOnce every item on this list is checked, I'll ask you for permission to merge and publish the changes.\n\n----------------------\n... diagnostics scrubbed ...\n" + "body": "@huseeiin Thank you for submitting this PR! I see this is your first time submitting to DefinitelyTyped 👋 — I'm the local bot who will help you through the process of getting things through.\n\n***This is a live comment that I will keep updated.***\n\n## 1 package in this PR\n\n* `fast-decode-uri-component` (0.1) (*new!*) — [on npm](https://www.npmjs.com/package/fast-decode-uri-component), [on unpkg](https://unpkg.com/browse/fast-decode-uri-component@latest/)\n - 1 added owner: ✎@huseeiin\n - Config files to check:\n - [`fast-decode-uri-component/tsconfig.json`](https://github.com/DefinitelyTyped/DefinitelyTyped/pull/70218/files/b40b94cbeb5441526e8ef39ff8684258f16d0514#diff-533ae5a3ce61574804bc5074b19ca431b11098f32353f7a2325b96ec0a72e686): not [the expected form](https://github.com/DefinitelyTyped/DefinitelyTyped#user-content-tsconfigjson) (check: `compilerOptions`)\n\n## Code Reviews\n\nThis PR adds a new definition, so it needs to be reviewed by a DT maintainer before it can be merged.\n\nYou can test the changes of this PR [in the Playground](https://www.typescriptlang.org/play/?dtPR=70218&install-plugin=playground-dt-review).\n\n## Status\n\n * ✅ No merge conflicts\n * ❌ Continuous integration tests have failed\n * 🕐 Only a DT maintainer can approve changes when there are new packages added\n\nOnce every item on this list is checked, I'll ask you for permission to merge and publish the changes.\n\n----------------------\n... diagnostics scrubbed ...\n" } } }, diff --git a/packages/mergebot/src/_tests/fixtures/70218/result.json b/packages/mergebot/src/_tests/fixtures/70218/result.json index 62e654c1c5..82d9d57bec 100644 --- a/packages/mergebot/src/_tests/fixtures/70218/result.json +++ b/packages/mergebot/src/_tests/fixtures/70218/result.json @@ -13,7 +13,7 @@ }, { "tag": "welcome", - "status": "@huseeiin Thank you for submitting this PR! I see this is your first time submitting to DefinitelyTyped 👋 — I'm the local bot who will help you through the process of getting things through.\n\n***This is a live comment that I will keep updated.***\n\n## 1 package in this PR\n\n* `fast-decode-uri-component` (*new!*) — [on npm](https://www.npmjs.com/package/fast-decode-uri-component), [on unpkg](https://unpkg.com/browse/fast-decode-uri-component@latest/)\n - 1 added owner: ✎@huseeiin\n - Config files to check:\n - [`fast-decode-uri-component/tsconfig.json`](https://github.com/DefinitelyTyped/DefinitelyTyped/pull/70218/files/b40b94cbeb5441526e8ef39ff8684258f16d0514#diff-533ae5a3ce61574804bc5074b19ca431b11098f32353f7a2325b96ec0a72e686): not [the expected form](https://github.com/DefinitelyTyped/DefinitelyTyped#user-content-tsconfigjson) (check: `compilerOptions`)\n\n## Code Reviews\n\nThis PR adds a new definition, so it needs to be reviewed by a DT maintainer before it can be merged.\n\nYou can test the changes of this PR [in the Playground](https://www.typescriptlang.org/play/?dtPR=70218&install-plugin=playground-dt-review).\n\n## Status\n\n * ✅ No merge conflicts\n * ❌ Continuous integration tests have failed\n * 🕐 Only a DT maintainer can approve changes when there are new packages added\n\nOnce every item on this list is checked, I'll ask you for permission to merge and publish the changes.\n\n----------------------\n... diagnostics scrubbed ..." + "status": "@huseeiin Thank you for submitting this PR! I see this is your first time submitting to DefinitelyTyped 👋 — I'm the local bot who will help you through the process of getting things through.\n\n***This is a live comment that I will keep updated.***\n\n## 1 package in this PR\n\n* `fast-decode-uri-component` (0.1) (*new!*) — [on npm](https://www.npmjs.com/package/fast-decode-uri-component), [on unpkg](https://unpkg.com/browse/fast-decode-uri-component@latest/)\n - 1 added owner: ✎@huseeiin\n - Config files to check:\n - [`fast-decode-uri-component/tsconfig.json`](https://github.com/DefinitelyTyped/DefinitelyTyped/pull/70218/files/b40b94cbeb5441526e8ef39ff8684258f16d0514#diff-533ae5a3ce61574804bc5074b19ca431b11098f32353f7a2325b96ec0a72e686): not [the expected form](https://github.com/DefinitelyTyped/DefinitelyTyped#user-content-tsconfigjson) (check: `compilerOptions`)\n\n## Code Reviews\n\nThis PR adds a new definition, so it needs to be reviewed by a DT maintainer before it can be merged.\n\nYou can test the changes of this PR [in the Playground](https://www.typescriptlang.org/play/?dtPR=70218&install-plugin=playground-dt-review).\n\n## Status\n\n * ✅ No merge conflicts\n * ❌ Continuous integration tests have failed\n * 🕐 Only a DT maintainer can approve changes when there are new packages added\n\nOnce every item on this list is checked, I'll ask you for permission to merge and publish the changes.\n\n----------------------\n... diagnostics scrubbed ..." }, { "tag": "pinging-reviewers-others", diff --git a/packages/mergebot/src/_tests/fixtures/70222/derived.json b/packages/mergebot/src/_tests/fixtures/70222/derived.json index fdd9310a6e..8929306dba 100644 --- a/packages/mergebot/src/_tests/fixtures/70222/derived.json +++ b/packages/mergebot/src/_tests/fixtures/70222/derived.json @@ -18,6 +18,7 @@ "pkgInfo": [ { "name": "three", + "version": "0.167", "kind": "edit", "files": [ { diff --git a/packages/mergebot/src/_tests/fixtures/70222/mutations.json b/packages/mergebot/src/_tests/fixtures/70222/mutations.json index debebd5487..6da43ddb4d 100644 --- a/packages/mergebot/src/_tests/fixtures/70222/mutations.json +++ b/packages/mergebot/src/_tests/fixtures/70222/mutations.json @@ -4,7 +4,7 @@ "variables": { "input": { "id": "IC_kwDOAFz6BM6HSqmn", - "body": "@Methuselah96 Thank you for submitting this PR!\n\n***This is a live comment that I will keep updated.***\n\n## 1 package in this PR\n\n* `three` — [on npm](https://www.npmjs.com/package/three), [on unpkg](https://unpkg.com/browse/three@latest/) (author is owner)\n\n## Code Reviews\n\nThis PR can be merged once it's reviewed.\n\nYou can test the changes of this PR [in the Playground](https://www.typescriptlang.org/play/?dtPR=70222&install-plugin=playground-dt-review).\n\n## Status\n\n * ✅ No merge conflicts\n * ✅ Continuous integration tests have passed\n * 🕐 Most recent commit is approved by type definition owners or DT maintainers\n\nOnce every item on this list is checked, I'll ask you for permission to merge and publish the changes.\n\n----------------------\n... diagnostics scrubbed ...\n" + "body": "@Methuselah96 Thank you for submitting this PR!\n\n***This is a live comment that I will keep updated.***\n\n## 1 package in this PR\n\n* `three` (0.167) — [on npm](https://www.npmjs.com/package/three), [on unpkg](https://unpkg.com/browse/three@latest/) (author is owner)\n\n## Code Reviews\n\nThis PR can be merged once it's reviewed.\n\nYou can test the changes of this PR [in the Playground](https://www.typescriptlang.org/play/?dtPR=70222&install-plugin=playground-dt-review).\n\n## Status\n\n * ✅ No merge conflicts\n * ✅ Continuous integration tests have passed\n * 🕐 Most recent commit is approved by type definition owners or DT maintainers\n\nOnce every item on this list is checked, I'll ask you for permission to merge and publish the changes.\n\n----------------------\n... diagnostics scrubbed ...\n" } } } diff --git a/packages/mergebot/src/_tests/fixtures/70222/result.json b/packages/mergebot/src/_tests/fixtures/70222/result.json index 6639d5d426..e3ca30fc82 100644 --- a/packages/mergebot/src/_tests/fixtures/70222/result.json +++ b/packages/mergebot/src/_tests/fixtures/70222/result.json @@ -12,7 +12,7 @@ }, { "tag": "welcome", - "status": "@Methuselah96 Thank you for submitting this PR!\n\n***This is a live comment that I will keep updated.***\n\n## 1 package in this PR\n\n* `three` — [on npm](https://www.npmjs.com/package/three), [on unpkg](https://unpkg.com/browse/three@latest/) (author is owner)\n\n## Code Reviews\n\nThis PR can be merged once it's reviewed.\n\nYou can test the changes of this PR [in the Playground](https://www.typescriptlang.org/play/?dtPR=70222&install-plugin=playground-dt-review).\n\n## Status\n\n * ✅ No merge conflicts\n * ✅ Continuous integration tests have passed\n * 🕐 Most recent commit is approved by type definition owners or DT maintainers\n\nOnce every item on this list is checked, I'll ask you for permission to merge and publish the changes.\n\n----------------------\n... diagnostics scrubbed ..." + "status": "@Methuselah96 Thank you for submitting this PR!\n\n***This is a live comment that I will keep updated.***\n\n## 1 package in this PR\n\n* `three` (0.167) — [on npm](https://www.npmjs.com/package/three), [on unpkg](https://unpkg.com/browse/three@latest/) (author is owner)\n\n## Code Reviews\n\nThis PR can be merged once it's reviewed.\n\nYou can test the changes of this PR [in the Playground](https://www.typescriptlang.org/play/?dtPR=70222&install-plugin=playground-dt-review).\n\n## Status\n\n * ✅ No merge conflicts\n * ✅ Continuous integration tests have passed\n * 🕐 Most recent commit is approved by type definition owners or DT maintainers\n\nOnce every item on this list is checked, I'll ask you for permission to merge and publish the changes.\n\n----------------------\n... diagnostics scrubbed ..." }, { "tag": "pinging-reviewers", diff --git a/packages/mergebot/src/_tests/fixtures/70242/derived.json b/packages/mergebot/src/_tests/fixtures/70242/derived.json index 2b0155e2b5..ebbf7dec72 100644 --- a/packages/mergebot/src/_tests/fixtures/70242/derived.json +++ b/packages/mergebot/src/_tests/fixtures/70242/derived.json @@ -33,6 +33,7 @@ }, { "name": "polygon-lookup", + "version": "2.6", "kind": "edit", "files": [ { @@ -49,6 +50,7 @@ }, { "name": "rbush", + "version": "3.0", "kind": "edit", "files": [ { @@ -66,6 +68,7 @@ }, { "name": "which-polygon", + "version": "2.2", "kind": "edit", "files": [ { diff --git a/packages/mergebot/src/_tests/fixtures/70242/mutations.json b/packages/mergebot/src/_tests/fixtures/70242/mutations.json index ae027c3f45..cf4fec9a76 100644 --- a/packages/mergebot/src/_tests/fixtures/70242/mutations.json +++ b/packages/mergebot/src/_tests/fixtures/70242/mutations.json @@ -4,7 +4,7 @@ "variables": { "input": { "id": "IC_kwDOAFz6BM6HhVto", - "body": "@mfedderly Thank you for submitting this PR!\n\n***This is a live comment that I will keep updated.***\n\n## 3 packages in this PR\n\n* `polygon-lookup` — [on npm](https://www.npmjs.com/package/polygon-lookup), [on unpkg](https://unpkg.com/browse/polygon-lookup@latest/)\n - owner-approval: @ffflorian\n* `rbush` — [on npm](https://www.npmjs.com/package/rbush), [on unpkg](https://unpkg.com/browse/rbush@latest/)\n* `which-polygon` — [on npm](https://www.npmjs.com/package/which-polygon), [on unpkg](https://unpkg.com/browse/which-polygon@latest/)\n\n## Code Reviews\n\nThis PR can be merged once it's reviewed.\n\nYou can test the changes of this PR [in the Playground](https://www.typescriptlang.org/play/?dtPR=70242&install-plugin=playground-dt-review).\n\n## Status\n\n * ✅ No merge conflicts\n * ✅ Continuous integration tests have passed\n * 🕐 Type definition owners or DT maintainers needs to approve changes that affect more than one package\n\nOnce every item on this list is checked, I'll ask you for permission to merge and publish the changes.\n\n----------------------\n... diagnostics scrubbed ...\n" + "body": "@mfedderly Thank you for submitting this PR!\n\n***This is a live comment that I will keep updated.***\n\n## 3 packages in this PR\n\n* `polygon-lookup` (2.6) — [on npm](https://www.npmjs.com/package/polygon-lookup), [on unpkg](https://unpkg.com/browse/polygon-lookup@latest/)\n - owner-approval: @ffflorian\n* `rbush` (3.0) — [on npm](https://www.npmjs.com/package/rbush), [on unpkg](https://unpkg.com/browse/rbush@latest/)\n* `which-polygon` (2.2) — [on npm](https://www.npmjs.com/package/which-polygon), [on unpkg](https://unpkg.com/browse/which-polygon@latest/)\n\n## Code Reviews\n\nThis PR can be merged once it's reviewed.\n\nYou can test the changes of this PR [in the Playground](https://www.typescriptlang.org/play/?dtPR=70242&install-plugin=playground-dt-review).\n\n## Status\n\n * ✅ No merge conflicts\n * ✅ Continuous integration tests have passed\n * 🕐 Type definition owners or DT maintainers needs to approve changes that affect more than one package\n\nOnce every item on this list is checked, I'll ask you for permission to merge and publish the changes.\n\n----------------------\n... diagnostics scrubbed ...\n" } } } diff --git a/packages/mergebot/src/_tests/fixtures/70242/result.json b/packages/mergebot/src/_tests/fixtures/70242/result.json index d02471d2c2..2374c72630 100644 --- a/packages/mergebot/src/_tests/fixtures/70242/result.json +++ b/packages/mergebot/src/_tests/fixtures/70242/result.json @@ -13,7 +13,7 @@ }, { "tag": "welcome", - "status": "@mfedderly Thank you for submitting this PR!\n\n***This is a live comment that I will keep updated.***\n\n## 3 packages in this PR\n\n* `polygon-lookup` — [on npm](https://www.npmjs.com/package/polygon-lookup), [on unpkg](https://unpkg.com/browse/polygon-lookup@latest/)\n - owner-approval: @ffflorian\n* `rbush` — [on npm](https://www.npmjs.com/package/rbush), [on unpkg](https://unpkg.com/browse/rbush@latest/)\n* `which-polygon` — [on npm](https://www.npmjs.com/package/which-polygon), [on unpkg](https://unpkg.com/browse/which-polygon@latest/)\n\n## Code Reviews\n\nThis PR can be merged once it's reviewed.\n\nYou can test the changes of this PR [in the Playground](https://www.typescriptlang.org/play/?dtPR=70242&install-plugin=playground-dt-review).\n\n## Status\n\n * ✅ No merge conflicts\n * ✅ Continuous integration tests have passed\n * 🕐 Type definition owners or DT maintainers needs to approve changes that affect more than one package\n\nOnce every item on this list is checked, I'll ask you for permission to merge and publish the changes.\n\n----------------------\n... diagnostics scrubbed ..." + "status": "@mfedderly Thank you for submitting this PR!\n\n***This is a live comment that I will keep updated.***\n\n## 3 packages in this PR\n\n* `polygon-lookup` (2.6) — [on npm](https://www.npmjs.com/package/polygon-lookup), [on unpkg](https://unpkg.com/browse/polygon-lookup@latest/)\n - owner-approval: @ffflorian\n* `rbush` (3.0) — [on npm](https://www.npmjs.com/package/rbush), [on unpkg](https://unpkg.com/browse/rbush@latest/)\n* `which-polygon` (2.2) — [on npm](https://www.npmjs.com/package/which-polygon), [on unpkg](https://unpkg.com/browse/which-polygon@latest/)\n\n## Code Reviews\n\nThis PR can be merged once it's reviewed.\n\nYou can test the changes of this PR [in the Playground](https://www.typescriptlang.org/play/?dtPR=70242&install-plugin=playground-dt-review).\n\n## Status\n\n * ✅ No merge conflicts\n * ✅ Continuous integration tests have passed\n * 🕐 Type definition owners or DT maintainers needs to approve changes that affect more than one package\n\nOnce every item on this list is checked, I'll ask you for permission to merge and publish the changes.\n\n----------------------\n... diagnostics scrubbed ..." } ], "shouldClose": false, diff --git a/packages/mergebot/src/_tests/fixtures/70751/derived.json b/packages/mergebot/src/_tests/fixtures/70751/derived.json index c47b3c77b6..e0c34d2c03 100644 --- a/packages/mergebot/src/_tests/fixtures/70751/derived.json +++ b/packages/mergebot/src/_tests/fixtures/70751/derived.json @@ -17,6 +17,7 @@ "pkgInfo": [ { "name": "express", + "version": "5.0", "kind": "edit", "files": [ { diff --git a/packages/mergebot/src/_tests/fixtures/70751/mutations.json b/packages/mergebot/src/_tests/fixtures/70751/mutations.json index 7eb3d0decd..9795d1a03b 100644 --- a/packages/mergebot/src/_tests/fixtures/70751/mutations.json +++ b/packages/mergebot/src/_tests/fixtures/70751/mutations.json @@ -4,7 +4,7 @@ "variables": { "input": { "subjectId": "PR_kwDOAFz6BM59K3Uu", - "body": "@jakebailey Thank you for submitting this PR!\n\n***This is a live comment that I will keep updated.***\n\n## 1 package in this PR\n\n* `express` — [on npm](https://www.npmjs.com/package/express), [on unpkg](https://unpkg.com/browse/express@latest/)\n - Config files to check:\n - [`express/package.json`](https://github.com/DefinitelyTyped/DefinitelyTyped/pull/70751/files/9856226df8d03bf135be670297bb5bf01f79625a#diff-d8a8870b20691ea142d2c76db164e2732ff20bf2e1ba742a04d86e4a6adacc18): not [the expected form](https://github.com/DefinitelyTyped/DefinitelyTyped#user-content-packagejson) and not moving towards it (check: `peerDependencies`)\n - [`express/v4/package.json`](https://github.com/DefinitelyTyped/DefinitelyTyped/pull/70751/files/9856226df8d03bf135be670297bb5bf01f79625a#diff-6d96baa63d84c72911de2708233f00cd6bd6ef09dd3f91e9b4b412fa51cfd51b): not [the expected form](https://github.com/DefinitelyTyped/DefinitelyTyped#user-content-packagejson) and not moving towards it (check: `peerDependencies`)\n\n## Code Reviews\n\nBecause this is a widely-used package, a DT maintainer will need to review it before it can be merged.\n\nYou can test the changes of this PR [in the Playground](https://www.typescriptlang.org/play/?dtPR=70751&install-plugin=playground-dt-review).\n\n## Status\n\n * ✅ No merge conflicts\n * 🕐 Continuous integration tests are still running\n * 🕐 A DT maintainer needs to approve changes that affect module config files\n\nOnce every item on this list is checked, I'll ask you for permission to merge and publish the changes.\n\n----------------------\n... diagnostics scrubbed ...\n" + "body": "@jakebailey Thank you for submitting this PR!\n\n***This is a live comment that I will keep updated.***\n\n## 1 package in this PR\n\n* `express` (5.0) — [on npm](https://www.npmjs.com/package/express), [on unpkg](https://unpkg.com/browse/express@latest/)\n - Config files to check:\n - [`express/package.json`](https://github.com/DefinitelyTyped/DefinitelyTyped/pull/70751/files/9856226df8d03bf135be670297bb5bf01f79625a#diff-d8a8870b20691ea142d2c76db164e2732ff20bf2e1ba742a04d86e4a6adacc18): not [the expected form](https://github.com/DefinitelyTyped/DefinitelyTyped#user-content-packagejson) and not moving towards it (check: `peerDependencies`)\n - [`express/v4/package.json`](https://github.com/DefinitelyTyped/DefinitelyTyped/pull/70751/files/9856226df8d03bf135be670297bb5bf01f79625a#diff-6d96baa63d84c72911de2708233f00cd6bd6ef09dd3f91e9b4b412fa51cfd51b): not [the expected form](https://github.com/DefinitelyTyped/DefinitelyTyped#user-content-packagejson) and not moving towards it (check: `peerDependencies`)\n\n## Code Reviews\n\nBecause this is a widely-used package, a DT maintainer will need to review it before it can be merged.\n\nYou can test the changes of this PR [in the Playground](https://www.typescriptlang.org/play/?dtPR=70751&install-plugin=playground-dt-review).\n\n## Status\n\n * ✅ No merge conflicts\n * 🕐 Continuous integration tests are still running\n * 🕐 A DT maintainer needs to approve changes that affect module config files\n\nOnce every item on this list is checked, I'll ask you for permission to merge and publish the changes.\n\n----------------------\n... diagnostics scrubbed ...\n" } } }, diff --git a/packages/mergebot/src/_tests/fixtures/70751/result.json b/packages/mergebot/src/_tests/fixtures/70751/result.json index aa12e3e035..b5afcef467 100644 --- a/packages/mergebot/src/_tests/fixtures/70751/result.json +++ b/packages/mergebot/src/_tests/fixtures/70751/result.json @@ -7,7 +7,7 @@ "responseComments": [ { "tag": "welcome", - "status": "@jakebailey Thank you for submitting this PR!\n\n***This is a live comment that I will keep updated.***\n\n## 1 package in this PR\n\n* `express` — [on npm](https://www.npmjs.com/package/express), [on unpkg](https://unpkg.com/browse/express@latest/)\n - Config files to check:\n - [`express/package.json`](https://github.com/DefinitelyTyped/DefinitelyTyped/pull/70751/files/9856226df8d03bf135be670297bb5bf01f79625a#diff-d8a8870b20691ea142d2c76db164e2732ff20bf2e1ba742a04d86e4a6adacc18): not [the expected form](https://github.com/DefinitelyTyped/DefinitelyTyped#user-content-packagejson) and not moving towards it (check: `peerDependencies`)\n - [`express/v4/package.json`](https://github.com/DefinitelyTyped/DefinitelyTyped/pull/70751/files/9856226df8d03bf135be670297bb5bf01f79625a#diff-6d96baa63d84c72911de2708233f00cd6bd6ef09dd3f91e9b4b412fa51cfd51b): not [the expected form](https://github.com/DefinitelyTyped/DefinitelyTyped#user-content-packagejson) and not moving towards it (check: `peerDependencies`)\n\n## Code Reviews\n\nBecause this is a widely-used package, a DT maintainer will need to review it before it can be merged.\n\nYou can test the changes of this PR [in the Playground](https://www.typescriptlang.org/play/?dtPR=70751&install-plugin=playground-dt-review).\n\n## Status\n\n * ✅ No merge conflicts\n * 🕐 Continuous integration tests are still running\n * 🕐 A DT maintainer needs to approve changes that affect module config files\n\nOnce every item on this list is checked, I'll ask you for permission to merge and publish the changes.\n\n----------------------\n... diagnostics scrubbed ..." + "status": "@jakebailey Thank you for submitting this PR!\n\n***This is a live comment that I will keep updated.***\n\n## 1 package in this PR\n\n* `express` (5.0) — [on npm](https://www.npmjs.com/package/express), [on unpkg](https://unpkg.com/browse/express@latest/)\n - Config files to check:\n - [`express/package.json`](https://github.com/DefinitelyTyped/DefinitelyTyped/pull/70751/files/9856226df8d03bf135be670297bb5bf01f79625a#diff-d8a8870b20691ea142d2c76db164e2732ff20bf2e1ba742a04d86e4a6adacc18): not [the expected form](https://github.com/DefinitelyTyped/DefinitelyTyped#user-content-packagejson) and not moving towards it (check: `peerDependencies`)\n - [`express/v4/package.json`](https://github.com/DefinitelyTyped/DefinitelyTyped/pull/70751/files/9856226df8d03bf135be670297bb5bf01f79625a#diff-6d96baa63d84c72911de2708233f00cd6bd6ef09dd3f91e9b4b412fa51cfd51b): not [the expected form](https://github.com/DefinitelyTyped/DefinitelyTyped#user-content-packagejson) and not moving towards it (check: `peerDependencies`)\n\n## Code Reviews\n\nBecause this is a widely-used package, a DT maintainer will need to review it before it can be merged.\n\nYou can test the changes of this PR [in the Playground](https://www.typescriptlang.org/play/?dtPR=70751&install-plugin=playground-dt-review).\n\n## Status\n\n * ✅ No merge conflicts\n * 🕐 Continuous integration tests are still running\n * 🕐 A DT maintainer needs to approve changes that affect module config files\n\nOnce every item on this list is checked, I'll ask you for permission to merge and publish the changes.\n\n----------------------\n... diagnostics scrubbed ..." }, { "tag": "pinging-reviewers", diff --git a/packages/mergebot/src/_tests/fixtures/71725/derived.json b/packages/mergebot/src/_tests/fixtures/71725/derived.json index 186c42f33e..a70ac6ebf5 100644 --- a/packages/mergebot/src/_tests/fixtures/71725/derived.json +++ b/packages/mergebot/src/_tests/fixtures/71725/derived.json @@ -18,6 +18,7 @@ "pkgInfo": [ { "name": "enhance__enhance", + "version": "2.0", "kind": "add", "files": [ { diff --git a/packages/mergebot/src/_tests/fixtures/71725/mutations.json b/packages/mergebot/src/_tests/fixtures/71725/mutations.json index 3578d71d46..1a1c8fa096 100644 --- a/packages/mergebot/src/_tests/fixtures/71725/mutations.json +++ b/packages/mergebot/src/_tests/fixtures/71725/mutations.json @@ -4,7 +4,7 @@ "variables": { "input": { "id": "IC_kwDOAFz6BM6bcLgn", - "body": "@agawley Thank you for submitting this PR! I see this is your first time submitting to DefinitelyTyped 👋 — I'm the local bot who will help you through the process of getting things through.\n\n***This is a live comment that I will keep updated.***\n\n## 1 package in this PR\n\n* `enhance__enhance` (*new!*) — [on npm](https://www.npmjs.com/package/@enhance/enhance), [on unpkg](https://unpkg.com/browse/@enhance/enhance@latest/)\n - 1 added owner: ✎@agawley\n - Config files to check:\n - [`enhance__enhance/.eslintrc.json`](https://github.com/DefinitelyTyped/DefinitelyTyped/pull/71725/files/10894aa4e8d1717516ae8867f3fbaa50e88785ea#diff-8396f43ae17f6ac375fa3ccd977f1fa5f4623a11ad7d4bb5d770a7f49d0feebd): not [the expected form](https://github.com/DefinitelyTyped/DefinitelyTyped#user-content-linter-eslintrcjson) (check: `rules`)\n\n## Code Reviews\n\nThis PR adds a new definition, so it needs to be reviewed by a DT maintainer before it can be merged.\n\nYou can test the changes of this PR [in the Playground](https://www.typescriptlang.org/play/?dtPR=71725&install-plugin=playground-dt-review).\n\n## Status\n\n * ✅ No merge conflicts\n * ✅ Continuous integration tests have passed\n * ✅ Only a DT maintainer can approve changes when there are new packages added\n\nAll of the items on the list are green. **To merge, you need to post a comment including the string \"Ready to merge\"** to bring in your changes.\n\n----------------------\n... diagnostics scrubbed ...\n" + "body": "@agawley Thank you for submitting this PR! I see this is your first time submitting to DefinitelyTyped 👋 — I'm the local bot who will help you through the process of getting things through.\n\n***This is a live comment that I will keep updated.***\n\n## 1 package in this PR\n\n* `enhance__enhance` (2.0) (*new!*) — [on npm](https://www.npmjs.com/package/@enhance/enhance), [on unpkg](https://unpkg.com/browse/@enhance/enhance@latest/)\n - 1 added owner: ✎@agawley\n - Config files to check:\n - [`enhance__enhance/.eslintrc.json`](https://github.com/DefinitelyTyped/DefinitelyTyped/pull/71725/files/10894aa4e8d1717516ae8867f3fbaa50e88785ea#diff-8396f43ae17f6ac375fa3ccd977f1fa5f4623a11ad7d4bb5d770a7f49d0feebd): not [the expected form](https://github.com/DefinitelyTyped/DefinitelyTyped#user-content-linter-eslintrcjson) (check: `rules`)\n\n## Code Reviews\n\nThis PR adds a new definition, so it needs to be reviewed by a DT maintainer before it can be merged.\n\nYou can test the changes of this PR [in the Playground](https://www.typescriptlang.org/play/?dtPR=71725&install-plugin=playground-dt-review).\n\n## Status\n\n * ✅ No merge conflicts\n * ✅ Continuous integration tests have passed\n * ✅ Only a DT maintainer can approve changes when there are new packages added\n\nAll of the items on the list are green. **To merge, you need to post a comment including the string \"Ready to merge\"** to bring in your changes.\n\n----------------------\n... diagnostics scrubbed ...\n" } } } diff --git a/packages/mergebot/src/_tests/fixtures/71725/result.json b/packages/mergebot/src/_tests/fixtures/71725/result.json index af182c8a1b..32ff67f5ff 100644 --- a/packages/mergebot/src/_tests/fixtures/71725/result.json +++ b/packages/mergebot/src/_tests/fixtures/71725/result.json @@ -9,7 +9,7 @@ "responseComments": [ { "tag": "welcome", - "status": "@agawley Thank you for submitting this PR! I see this is your first time submitting to DefinitelyTyped 👋 — I'm the local bot who will help you through the process of getting things through.\n\n***This is a live comment that I will keep updated.***\n\n## 1 package in this PR\n\n* `enhance__enhance` (*new!*) — [on npm](https://www.npmjs.com/package/@enhance/enhance), [on unpkg](https://unpkg.com/browse/@enhance/enhance@latest/)\n - 1 added owner: ✎@agawley\n - Config files to check:\n - [`enhance__enhance/.eslintrc.json`](https://github.com/DefinitelyTyped/DefinitelyTyped/pull/71725/files/10894aa4e8d1717516ae8867f3fbaa50e88785ea#diff-8396f43ae17f6ac375fa3ccd977f1fa5f4623a11ad7d4bb5d770a7f49d0feebd): not [the expected form](https://github.com/DefinitelyTyped/DefinitelyTyped#user-content-linter-eslintrcjson) (check: `rules`)\n\n## Code Reviews\n\nThis PR adds a new definition, so it needs to be reviewed by a DT maintainer before it can be merged.\n\nYou can test the changes of this PR [in the Playground](https://www.typescriptlang.org/play/?dtPR=71725&install-plugin=playground-dt-review).\n\n## Status\n\n * ✅ No merge conflicts\n * ✅ Continuous integration tests have passed\n * ✅ Only a DT maintainer can approve changes when there are new packages added\n\nAll of the items on the list are green. **To merge, you need to post a comment including the string \"Ready to merge\"** to bring in your changes.\n\n----------------------\n... diagnostics scrubbed ..." + "status": "@agawley Thank you for submitting this PR! I see this is your first time submitting to DefinitelyTyped 👋 — I'm the local bot who will help you through the process of getting things through.\n\n***This is a live comment that I will keep updated.***\n\n## 1 package in this PR\n\n* `enhance__enhance` (2.0) (*new!*) — [on npm](https://www.npmjs.com/package/@enhance/enhance), [on unpkg](https://unpkg.com/browse/@enhance/enhance@latest/)\n - 1 added owner: ✎@agawley\n - Config files to check:\n - [`enhance__enhance/.eslintrc.json`](https://github.com/DefinitelyTyped/DefinitelyTyped/pull/71725/files/10894aa4e8d1717516ae8867f3fbaa50e88785ea#diff-8396f43ae17f6ac375fa3ccd977f1fa5f4623a11ad7d4bb5d770a7f49d0feebd): not [the expected form](https://github.com/DefinitelyTyped/DefinitelyTyped#user-content-linter-eslintrcjson) (check: `rules`)\n\n## Code Reviews\n\nThis PR adds a new definition, so it needs to be reviewed by a DT maintainer before it can be merged.\n\nYou can test the changes of this PR [in the Playground](https://www.typescriptlang.org/play/?dtPR=71725&install-plugin=playground-dt-review).\n\n## Status\n\n * ✅ No merge conflicts\n * ✅ Continuous integration tests have passed\n * ✅ Only a DT maintainer can approve changes when there are new packages added\n\nAll of the items on the list are green. **To merge, you need to post a comment including the string \"Ready to merge\"** to bring in your changes.\n\n----------------------\n... diagnostics scrubbed ..." }, { "tag": "merge-offer", diff --git a/packages/mergebot/src/_tests/fixtures/71790/derived.json b/packages/mergebot/src/_tests/fixtures/71790/derived.json index 4eb7156b8e..011adc32a3 100644 --- a/packages/mergebot/src/_tests/fixtures/71790/derived.json +++ b/packages/mergebot/src/_tests/fixtures/71790/derived.json @@ -32,6 +32,7 @@ }, { "name": "hapi__catbox-memory", + "version": "4.1", "kind": "delete", "files": [ { diff --git a/packages/mergebot/src/_tests/fixtures/71790/mutations.json b/packages/mergebot/src/_tests/fixtures/71790/mutations.json index 48c8d6468f..85fbc68284 100644 --- a/packages/mergebot/src/_tests/fixtures/71790/mutations.json +++ b/packages/mergebot/src/_tests/fixtures/71790/mutations.json @@ -4,7 +4,7 @@ "variables": { "input": { "id": "IC_kwDOAFz6BM6cXqlQ", - "body": "@hkleungai Thank you for submitting this PR!\n\n***This is a live comment that I will keep updated.***\n\nThis PR touches some part of DefinitelyTyped infrastructure, so a DT maintainer will need to review it. This is rare — did you mean to do this?\n\n## 1 package in this PR (and infra files)\n\n* `hapi__catbox-memory` (*probably deleted!*) — [on npm](https://www.npmjs.com/package/@hapi/catbox-memory), [on unpkg](https://unpkg.com/browse/@hapi/catbox-memory@latest/)\n* Infra files\n - [`notNeededPackages.json`](https://github.com/DefinitelyTyped/DefinitelyTyped/pull/71790/files/0a964f11f0a26b05b176e5d56763599b0c16e044#diff-a275c2eae7b8f788a52327e76809026ee1bc5ea614393806c8f3cbab07202621)\n\n## Code Reviews\n\nThis PR can be merged once it's reviewed by a DT maintainer.\n\nYou can test the changes of this PR [in the Playground](https://www.typescriptlang.org/play/?dtPR=71790&install-plugin=playground-dt-review).\n\n## Status\n\n * ✅ No merge conflicts\n * ✅ Continuous integration tests have passed\n * 🕐 A DT maintainer needs to approve changes that affect DT infrastructure ([`notNeededPackages.json`](https://github.com/DefinitelyTyped/DefinitelyTyped/pull/71790/files/0a964f11f0a26b05b176e5d56763599b0c16e044#diff-a275c2eae7b8f788a52327e76809026ee1bc5ea614393806c8f3cbab07202621))\n\nOnce every item on this list is checked, I'll ask you for permission to merge and publish the changes.\n\n----------------------\n... diagnostics scrubbed ...\n" + "body": "@hkleungai Thank you for submitting this PR!\n\n***This is a live comment that I will keep updated.***\n\nThis PR touches some part of DefinitelyTyped infrastructure, so a DT maintainer will need to review it. This is rare — did you mean to do this?\n\n## 1 package in this PR (and infra files)\n\n* `hapi__catbox-memory` (4.1) (*probably deleted!*) — [on npm](https://www.npmjs.com/package/@hapi/catbox-memory), [on unpkg](https://unpkg.com/browse/@hapi/catbox-memory@latest/)\n* Infra files\n - [`notNeededPackages.json`](https://github.com/DefinitelyTyped/DefinitelyTyped/pull/71790/files/0a964f11f0a26b05b176e5d56763599b0c16e044#diff-a275c2eae7b8f788a52327e76809026ee1bc5ea614393806c8f3cbab07202621)\n\n## Code Reviews\n\nThis PR can be merged once it's reviewed by a DT maintainer.\n\nYou can test the changes of this PR [in the Playground](https://www.typescriptlang.org/play/?dtPR=71790&install-plugin=playground-dt-review).\n\n## Status\n\n * ✅ No merge conflicts\n * ✅ Continuous integration tests have passed\n * 🕐 A DT maintainer needs to approve changes that affect DT infrastructure ([`notNeededPackages.json`](https://github.com/DefinitelyTyped/DefinitelyTyped/pull/71790/files/0a964f11f0a26b05b176e5d56763599b0c16e044#diff-a275c2eae7b8f788a52327e76809026ee1bc5ea614393806c8f3cbab07202621))\n\nOnce every item on this list is checked, I'll ask you for permission to merge and publish the changes.\n\n----------------------\n... diagnostics scrubbed ...\n" } } }, diff --git a/packages/mergebot/src/_tests/fixtures/71790/result.json b/packages/mergebot/src/_tests/fixtures/71790/result.json index c70a58dd99..0335bc26dc 100644 --- a/packages/mergebot/src/_tests/fixtures/71790/result.json +++ b/packages/mergebot/src/_tests/fixtures/71790/result.json @@ -6,7 +6,7 @@ "responseComments": [ { "tag": "welcome", - "status": "@hkleungai Thank you for submitting this PR!\n\n***This is a live comment that I will keep updated.***\n\nThis PR touches some part of DefinitelyTyped infrastructure, so a DT maintainer will need to review it. This is rare — did you mean to do this?\n\n## 1 package in this PR (and infra files)\n\n* `hapi__catbox-memory` (*probably deleted!*) — [on npm](https://www.npmjs.com/package/@hapi/catbox-memory), [on unpkg](https://unpkg.com/browse/@hapi/catbox-memory@latest/)\n* Infra files\n - [`notNeededPackages.json`](https://github.com/DefinitelyTyped/DefinitelyTyped/pull/71790/files/0a964f11f0a26b05b176e5d56763599b0c16e044#diff-a275c2eae7b8f788a52327e76809026ee1bc5ea614393806c8f3cbab07202621)\n\n## Code Reviews\n\nThis PR can be merged once it's reviewed by a DT maintainer.\n\nYou can test the changes of this PR [in the Playground](https://www.typescriptlang.org/play/?dtPR=71790&install-plugin=playground-dt-review).\n\n## Status\n\n * ✅ No merge conflicts\n * ✅ Continuous integration tests have passed\n * 🕐 A DT maintainer needs to approve changes that affect DT infrastructure ([`notNeededPackages.json`](https://github.com/DefinitelyTyped/DefinitelyTyped/pull/71790/files/0a964f11f0a26b05b176e5d56763599b0c16e044#diff-a275c2eae7b8f788a52327e76809026ee1bc5ea614393806c8f3cbab07202621))\n\nOnce every item on this list is checked, I'll ask you for permission to merge and publish the changes.\n\n----------------------\n... diagnostics scrubbed ..." + "status": "@hkleungai Thank you for submitting this PR!\n\n***This is a live comment that I will keep updated.***\n\nThis PR touches some part of DefinitelyTyped infrastructure, so a DT maintainer will need to review it. This is rare — did you mean to do this?\n\n## 1 package in this PR (and infra files)\n\n* `hapi__catbox-memory` (4.1) (*probably deleted!*) — [on npm](https://www.npmjs.com/package/@hapi/catbox-memory), [on unpkg](https://unpkg.com/browse/@hapi/catbox-memory@latest/)\n* Infra files\n - [`notNeededPackages.json`](https://github.com/DefinitelyTyped/DefinitelyTyped/pull/71790/files/0a964f11f0a26b05b176e5d56763599b0c16e044#diff-a275c2eae7b8f788a52327e76809026ee1bc5ea614393806c8f3cbab07202621)\n\n## Code Reviews\n\nThis PR can be merged once it's reviewed by a DT maintainer.\n\nYou can test the changes of this PR [in the Playground](https://www.typescriptlang.org/play/?dtPR=71790&install-plugin=playground-dt-review).\n\n## Status\n\n * ✅ No merge conflicts\n * ✅ Continuous integration tests have passed\n * 🕐 A DT maintainer needs to approve changes that affect DT infrastructure ([`notNeededPackages.json`](https://github.com/DefinitelyTyped/DefinitelyTyped/pull/71790/files/0a964f11f0a26b05b176e5d56763599b0c16e044#diff-a275c2eae7b8f788a52327e76809026ee1bc5ea614393806c8f3cbab07202621))\n\nOnce every item on this list is checked, I'll ask you for permission to merge and publish the changes.\n\n----------------------\n... diagnostics scrubbed ..." }, { "tag": "pinging-reviewers", diff --git a/packages/mergebot/src/_tests/fixtures/72083/derived.json b/packages/mergebot/src/_tests/fixtures/72083/derived.json index ebb3d97034..a0f007b1d8 100644 --- a/packages/mergebot/src/_tests/fixtures/72083/derived.json +++ b/packages/mergebot/src/_tests/fixtures/72083/derived.json @@ -20,6 +20,7 @@ "pkgInfo": [ { "name": "uswds__uswds", + "version": "3.11", "kind": "edit", "files": [ { diff --git a/packages/mergebot/src/_tests/fixtures/72083/mutations.json b/packages/mergebot/src/_tests/fixtures/72083/mutations.json index 68c3e9d2fc..4592f170b4 100644 --- a/packages/mergebot/src/_tests/fixtures/72083/mutations.json +++ b/packages/mergebot/src/_tests/fixtures/72083/mutations.json @@ -4,7 +4,7 @@ "variables": { "input": { "id": "IC_kwDOAFz6BM6gcJe-", - "body": "@sandersn Thank you for submitting this PR!\n\n***This is a live comment that I will keep updated.***\n\n## 1 package in this PR\n\n* `uswds__uswds` — [on npm](https://www.npmjs.com/package/@uswds/uswds), [on unpkg](https://unpkg.com/browse/@uswds/uswds@latest/)\n\n## Code Reviews\n\nBecause you edited one package and there were no type definition changes, I can help you merge this PR once someone else signs off on it.\n\nYou can test the changes of this PR [in the Playground](https://www.typescriptlang.org/play/?dtPR=72083&install-plugin=playground-dt-review).\n\n## Status\n\n * ✅ No merge conflicts\n * ✅ Continuous integration tests have passed\n * ✅ Most recent commit is approved by type definition owners, DT maintainers or others\n\nAll of the items on the list are green. **To merge, you need to post a comment including the string \"Ready to merge\"** to bring in your changes.\n\n----------------------\n... diagnostics scrubbed ...\n" + "body": "@sandersn Thank you for submitting this PR!\n\n***This is a live comment that I will keep updated.***\n\n## 1 package in this PR\n\n* `uswds__uswds` (3.11) — [on npm](https://www.npmjs.com/package/@uswds/uswds), [on unpkg](https://unpkg.com/browse/@uswds/uswds@latest/)\n\n## Code Reviews\n\nBecause you edited one package and there were no type definition changes, I can help you merge this PR once someone else signs off on it.\n\nYou can test the changes of this PR [in the Playground](https://www.typescriptlang.org/play/?dtPR=72083&install-plugin=playground-dt-review).\n\n## Status\n\n * ✅ No merge conflicts\n * ✅ Continuous integration tests have passed\n * ✅ Most recent commit is approved by type definition owners, DT maintainers or others\n\nAll of the items on the list are green. **To merge, you need to post a comment including the string \"Ready to merge\"** to bring in your changes.\n\n----------------------\n... diagnostics scrubbed ...\n" } } }, diff --git a/packages/mergebot/src/_tests/fixtures/72083/result.json b/packages/mergebot/src/_tests/fixtures/72083/result.json index 656e5f77b2..caec814e0a 100644 --- a/packages/mergebot/src/_tests/fixtures/72083/result.json +++ b/packages/mergebot/src/_tests/fixtures/72083/result.json @@ -8,7 +8,7 @@ "responseComments": [ { "tag": "welcome", - "status": "@sandersn Thank you for submitting this PR!\n\n***This is a live comment that I will keep updated.***\n\n## 1 package in this PR\n\n* `uswds__uswds` — [on npm](https://www.npmjs.com/package/@uswds/uswds), [on unpkg](https://unpkg.com/browse/@uswds/uswds@latest/)\n\n## Code Reviews\n\nBecause you edited one package and there were no type definition changes, I can help you merge this PR once someone else signs off on it.\n\nYou can test the changes of this PR [in the Playground](https://www.typescriptlang.org/play/?dtPR=72083&install-plugin=playground-dt-review).\n\n## Status\n\n * ✅ No merge conflicts\n * ✅ Continuous integration tests have passed\n * ✅ Most recent commit is approved by type definition owners, DT maintainers or others\n\nAll of the items on the list are green. **To merge, you need to post a comment including the string \"Ready to merge\"** to bring in your changes.\n\n----------------------\n... diagnostics scrubbed ..." + "status": "@sandersn Thank you for submitting this PR!\n\n***This is a live comment that I will keep updated.***\n\n## 1 package in this PR\n\n* `uswds__uswds` (3.11) — [on npm](https://www.npmjs.com/package/@uswds/uswds), [on unpkg](https://unpkg.com/browse/@uswds/uswds@latest/)\n\n## Code Reviews\n\nBecause you edited one package and there were no type definition changes, I can help you merge this PR once someone else signs off on it.\n\nYou can test the changes of this PR [in the Playground](https://www.typescriptlang.org/play/?dtPR=72083&install-plugin=playground-dt-review).\n\n## Status\n\n * ✅ No merge conflicts\n * ✅ Continuous integration tests have passed\n * ✅ Most recent commit is approved by type definition owners, DT maintainers or others\n\nAll of the items on the list are green. **To merge, you need to post a comment including the string \"Ready to merge\"** to bring in your changes.\n\n----------------------\n... diagnostics scrubbed ..." }, { "tag": "merge-offer", diff --git a/packages/mergebot/src/_tests/fixtures/73752/derived.json b/packages/mergebot/src/_tests/fixtures/73752/derived.json index 7a4915b34f..190ab6cd5b 100644 --- a/packages/mergebot/src/_tests/fixtures/73752/derived.json +++ b/packages/mergebot/src/_tests/fixtures/73752/derived.json @@ -17,6 +17,7 @@ "pkgInfo": [ { "name": "webxr", + "version": "0.5", "kind": "edit", "files": [ { diff --git a/packages/mergebot/src/_tests/fixtures/73752/mutations.json b/packages/mergebot/src/_tests/fixtures/73752/mutations.json index 75133334b9..c1debc25ef 100644 --- a/packages/mergebot/src/_tests/fixtures/73752/mutations.json +++ b/packages/mergebot/src/_tests/fixtures/73752/mutations.json @@ -4,7 +4,7 @@ "variables": { "input": { "id": "IC_kwDOAFz6BM7HALVM", - "body": "@sorskoot Thank you for submitting this PR!\n\n***This is a live comment that I will keep updated.***\n\n## 1 package in this PR\n\n* `webxr` — [on npm](https://www.npmjs.com/package/webxr), [on unpkg](https://unpkg.com/browse/webxr@latest/) (author is owner)\n\n## Code Reviews\n\nBecause this is a widely-used package, a DT maintainer will need to review it before it can be merged.\n\nYou can test the changes of this PR [in the Playground](https://www.typescriptlang.org/play/?dtPR=73752&install-plugin=playground-dt-review).\n\n## Status\n\n * ✅ No merge conflicts\n * ✅ Continuous integration tests have passed\n * 🕐 Most recent commit is approved by a DT maintainer\n\nOnce every item on this list is checked, I'll ask you for permission to merge and publish the changes.\n\n----------------------\n... diagnostics scrubbed ...\n" + "body": "@sorskoot Thank you for submitting this PR!\n\n***This is a live comment that I will keep updated.***\n\n## 1 package in this PR\n\n* `webxr` (0.5) — [on npm](https://www.npmjs.com/package/webxr), [on unpkg](https://unpkg.com/browse/webxr@latest/) (author is owner)\n\n## Code Reviews\n\nBecause this is a widely-used package, a DT maintainer will need to review it before it can be merged.\n\nYou can test the changes of this PR [in the Playground](https://www.typescriptlang.org/play/?dtPR=73752&install-plugin=playground-dt-review).\n\n## Status\n\n * ✅ No merge conflicts\n * ✅ Continuous integration tests have passed\n * 🕐 Most recent commit is approved by a DT maintainer\n\nOnce every item on this list is checked, I'll ask you for permission to merge and publish the changes.\n\n----------------------\n... diagnostics scrubbed ...\n" } } } diff --git a/packages/mergebot/src/_tests/fixtures/73752/result.json b/packages/mergebot/src/_tests/fixtures/73752/result.json index 23d76e1bfa..22f61c561c 100644 --- a/packages/mergebot/src/_tests/fixtures/73752/result.json +++ b/packages/mergebot/src/_tests/fixtures/73752/result.json @@ -7,7 +7,7 @@ "responseComments": [ { "tag": "welcome", - "status": "@sorskoot Thank you for submitting this PR!\n\n***This is a live comment that I will keep updated.***\n\n## 1 package in this PR\n\n* `webxr` — [on npm](https://www.npmjs.com/package/webxr), [on unpkg](https://unpkg.com/browse/webxr@latest/) (author is owner)\n\n## Code Reviews\n\nBecause this is a widely-used package, a DT maintainer will need to review it before it can be merged.\n\nYou can test the changes of this PR [in the Playground](https://www.typescriptlang.org/play/?dtPR=73752&install-plugin=playground-dt-review).\n\n## Status\n\n * ✅ No merge conflicts\n * ✅ Continuous integration tests have passed\n * 🕐 Most recent commit is approved by a DT maintainer\n\nOnce every item on this list is checked, I'll ask you for permission to merge and publish the changes.\n\n----------------------\n... diagnostics scrubbed ..." + "status": "@sorskoot Thank you for submitting this PR!\n\n***This is a live comment that I will keep updated.***\n\n## 1 package in this PR\n\n* `webxr` (0.5) — [on npm](https://www.npmjs.com/package/webxr), [on unpkg](https://unpkg.com/browse/webxr@latest/) (author is owner)\n\n## Code Reviews\n\nBecause this is a widely-used package, a DT maintainer will need to review it before it can be merged.\n\nYou can test the changes of this PR [in the Playground](https://www.typescriptlang.org/play/?dtPR=73752&install-plugin=playground-dt-review).\n\n## Status\n\n * ✅ No merge conflicts\n * ✅ Continuous integration tests have passed\n * 🕐 Most recent commit is approved by a DT maintainer\n\nOnce every item on this list is checked, I'll ask you for permission to merge and publish the changes.\n\n----------------------\n... diagnostics scrubbed ..." }, { "tag": "pinging-reviewers", diff --git a/packages/mergebot/src/_tests/fixtures/74980/derived.json b/packages/mergebot/src/_tests/fixtures/74980/derived.json index e9ac6de43d..f6c9250248 100644 --- a/packages/mergebot/src/_tests/fixtures/74980/derived.json +++ b/packages/mergebot/src/_tests/fixtures/74980/derived.json @@ -17,6 +17,7 @@ "pkgInfo": [ { "name": "bluebird", + "version": "3.5", "kind": "edit", "files": [ { diff --git a/packages/mergebot/src/_tests/fixtures/74980/mutations.json b/packages/mergebot/src/_tests/fixtures/74980/mutations.json index fbb46a9b68..8d2a70f9da 100644 --- a/packages/mergebot/src/_tests/fixtures/74980/mutations.json +++ b/packages/mergebot/src/_tests/fixtures/74980/mutations.json @@ -4,7 +4,7 @@ "variables": { "input": { "subjectId": "PR_kwDOAFz6BM7aQ8jd", - "body": "@justinkrn68-droid Thank you for submitting this PR! I see this is your first time submitting to DefinitelyTyped 👋 — I'm the local bot who will help you through the process of getting things through.\n\n***This is a live comment that I will keep updated.***\n\n## 1 package in this PR\n\n* `bluebird` — [on npm](https://www.npmjs.com/package/bluebird), [on unpkg](https://unpkg.com/browse/bluebird@latest/)\n - Config files to check:\n - [`bluebird/package.json`](https://github.com/DefinitelyTyped/DefinitelyTyped/pull/74980/files/c6d1344b3c7e49f62f4befd1aaa8665eb6bd6864#diff-a7758061c91486db4772fdf646baf1596c98b99a50204a6b3185b4a7e021fb9f): couldn't parse json\n\n## Code Reviews\n\nBecause this is a widely-used package, a DT maintainer will need to review it before it can be merged.\n\nYou can test the changes of this PR [in the Playground](https://www.typescriptlang.org/play/?dtPR=74980&install-plugin=playground-dt-review).\n\n## Status\n\n * ✅ No merge conflicts\n * 🕐 Continuous integration tests are still running\n * 🕐 A DT maintainer needs to approve changes that affect module config files\n\nOnce every item on this list is checked, I'll ask you for permission to merge and publish the changes.\n\n## Inactive\n\nThis PR has been inactive for 29 days — it is *still* unreviewed!\n\n----------------------\n... diagnostics scrubbed ...\n" + "body": "@justinkrn68-droid Thank you for submitting this PR! I see this is your first time submitting to DefinitelyTyped 👋 — I'm the local bot who will help you through the process of getting things through.\n\n***This is a live comment that I will keep updated.***\n\n## 1 package in this PR\n\n* `bluebird` (3.5) — [on npm](https://www.npmjs.com/package/bluebird), [on unpkg](https://unpkg.com/browse/bluebird@latest/)\n - Config files to check:\n - [`bluebird/package.json`](https://github.com/DefinitelyTyped/DefinitelyTyped/pull/74980/files/c6d1344b3c7e49f62f4befd1aaa8665eb6bd6864#diff-a7758061c91486db4772fdf646baf1596c98b99a50204a6b3185b4a7e021fb9f): couldn't parse json\n\n## Code Reviews\n\nBecause this is a widely-used package, a DT maintainer will need to review it before it can be merged.\n\nYou can test the changes of this PR [in the Playground](https://www.typescriptlang.org/play/?dtPR=74980&install-plugin=playground-dt-review).\n\n## Status\n\n * ✅ No merge conflicts\n * 🕐 Continuous integration tests are still running\n * 🕐 A DT maintainer needs to approve changes that affect module config files\n\nOnce every item on this list is checked, I'll ask you for permission to merge and publish the changes.\n\n## Inactive\n\nThis PR has been inactive for 29 days — it is *still* unreviewed!\n\n----------------------\n... diagnostics scrubbed ...\n" } } }, diff --git a/packages/mergebot/src/_tests/fixtures/74980/result.json b/packages/mergebot/src/_tests/fixtures/74980/result.json index 2d7e138c58..4e455116f1 100644 --- a/packages/mergebot/src/_tests/fixtures/74980/result.json +++ b/packages/mergebot/src/_tests/fixtures/74980/result.json @@ -8,7 +8,7 @@ "responseComments": [ { "tag": "welcome", - "status": "@justinkrn68-droid Thank you for submitting this PR! I see this is your first time submitting to DefinitelyTyped 👋 — I'm the local bot who will help you through the process of getting things through.\n\n***This is a live comment that I will keep updated.***\n\n## 1 package in this PR\n\n* `bluebird` — [on npm](https://www.npmjs.com/package/bluebird), [on unpkg](https://unpkg.com/browse/bluebird@latest/)\n - Config files to check:\n - [`bluebird/package.json`](https://github.com/DefinitelyTyped/DefinitelyTyped/pull/74980/files/c6d1344b3c7e49f62f4befd1aaa8665eb6bd6864#diff-a7758061c91486db4772fdf646baf1596c98b99a50204a6b3185b4a7e021fb9f): couldn't parse json\n\n## Code Reviews\n\nBecause this is a widely-used package, a DT maintainer will need to review it before it can be merged.\n\nYou can test the changes of this PR [in the Playground](https://www.typescriptlang.org/play/?dtPR=74980&install-plugin=playground-dt-review).\n\n## Status\n\n * ✅ No merge conflicts\n * 🕐 Continuous integration tests are still running\n * 🕐 A DT maintainer needs to approve changes that affect module config files\n\nOnce every item on this list is checked, I'll ask you for permission to merge and publish the changes.\n\n## Inactive\n\nThis PR has been inactive for 29 days — it is *still* unreviewed!\n\n----------------------\n... diagnostics scrubbed ..." + "status": "@justinkrn68-droid Thank you for submitting this PR! I see this is your first time submitting to DefinitelyTyped 👋 — I'm the local bot who will help you through the process of getting things through.\n\n***This is a live comment that I will keep updated.***\n\n## 1 package in this PR\n\n* `bluebird` (3.5) — [on npm](https://www.npmjs.com/package/bluebird), [on unpkg](https://unpkg.com/browse/bluebird@latest/)\n - Config files to check:\n - [`bluebird/package.json`](https://github.com/DefinitelyTyped/DefinitelyTyped/pull/74980/files/c6d1344b3c7e49f62f4befd1aaa8665eb6bd6864#diff-a7758061c91486db4772fdf646baf1596c98b99a50204a6b3185b4a7e021fb9f): couldn't parse json\n\n## Code Reviews\n\nBecause this is a widely-used package, a DT maintainer will need to review it before it can be merged.\n\nYou can test the changes of this PR [in the Playground](https://www.typescriptlang.org/play/?dtPR=74980&install-plugin=playground-dt-review).\n\n## Status\n\n * ✅ No merge conflicts\n * 🕐 Continuous integration tests are still running\n * 🕐 A DT maintainer needs to approve changes that affect module config files\n\nOnce every item on this list is checked, I'll ask you for permission to merge and publish the changes.\n\n## Inactive\n\nThis PR has been inactive for 29 days — it is *still* unreviewed!\n\n----------------------\n... diagnostics scrubbed ..." }, { "tag": "pinging-reviewers", diff --git a/packages/mergebot/src/_tests/fixtures/75014/derived.json b/packages/mergebot/src/_tests/fixtures/75014/derived.json index 08d6ad1673..02de5da946 100644 --- a/packages/mergebot/src/_tests/fixtures/75014/derived.json +++ b/packages/mergebot/src/_tests/fixtures/75014/derived.json @@ -17,6 +17,7 @@ "pkgInfo": [ { "name": "safie-sdk", + "version": "1.8", "kind": "add", "files": [ { diff --git a/packages/mergebot/src/_tests/fixtures/75014/mutations.json b/packages/mergebot/src/_tests/fixtures/75014/mutations.json index ae671c96b0..12887056d4 100644 --- a/packages/mergebot/src/_tests/fixtures/75014/mutations.json +++ b/packages/mergebot/src/_tests/fixtures/75014/mutations.json @@ -4,7 +4,7 @@ "variables": { "input": { "id": "IC_kwDOAFz6BM8AAAABCqDVRA", - "body": "@yusuke-oba1 Thank you for submitting this PR!\n\n***This is a live comment that I will keep updated.***\n\n## 1 package in this PR\n\n* `safie-sdk` (*new!*) — [on npm](https://www.npmjs.com/package/safie-sdk), [on unpkg](https://unpkg.com/browse/safie-sdk@latest/)\n - 1 added owner: @SafieDev\n\n## Code Reviews\n\nThis PR adds a new definition, so it needs to be reviewed by a DT maintainer before it can be merged.\n\nYou can test the changes of this PR [in the Playground](https://www.typescriptlang.org/play/?dtPR=75014&install-plugin=playground-dt-review).\n\n## Status\n\n * ✅ No merge conflicts\n * ✅ Continuous integration tests have passed\n * ✅ Only a DT maintainer can approve changes when there are new packages added\n\nAll of the items on the list are green. **To merge, you need to post a comment including the string \"Ready to merge\"** to bring in your changes.\n\n----------------------\n... diagnostics scrubbed ...\n" + "body": "@yusuke-oba1 Thank you for submitting this PR!\n\n***This is a live comment that I will keep updated.***\n\n## 1 package in this PR\n\n* `safie-sdk` (1.8) (*new!*) — [on npm](https://www.npmjs.com/package/safie-sdk), [on unpkg](https://unpkg.com/browse/safie-sdk@latest/)\n - 1 added owner: @SafieDev\n\n## Code Reviews\n\nThis PR adds a new definition, so it needs to be reviewed by a DT maintainer before it can be merged.\n\nYou can test the changes of this PR [in the Playground](https://www.typescriptlang.org/play/?dtPR=75014&install-plugin=playground-dt-review).\n\n## Status\n\n * ✅ No merge conflicts\n * ✅ Continuous integration tests have passed\n * ✅ Only a DT maintainer can approve changes when there are new packages added\n\nAll of the items on the list are green. **To merge, you need to post a comment including the string \"Ready to merge\"** to bring in your changes.\n\n----------------------\n... diagnostics scrubbed ...\n" } } }, diff --git a/packages/mergebot/src/_tests/fixtures/75014/result.json b/packages/mergebot/src/_tests/fixtures/75014/result.json index f8d52de78b..0ca46e0d3f 100644 --- a/packages/mergebot/src/_tests/fixtures/75014/result.json +++ b/packages/mergebot/src/_tests/fixtures/75014/result.json @@ -8,7 +8,7 @@ "responseComments": [ { "tag": "welcome", - "status": "@yusuke-oba1 Thank you for submitting this PR!\n\n***This is a live comment that I will keep updated.***\n\n## 1 package in this PR\n\n* `safie-sdk` (*new!*) — [on npm](https://www.npmjs.com/package/safie-sdk), [on unpkg](https://unpkg.com/browse/safie-sdk@latest/)\n - 1 added owner: @SafieDev\n\n## Code Reviews\n\nThis PR adds a new definition, so it needs to be reviewed by a DT maintainer before it can be merged.\n\nYou can test the changes of this PR [in the Playground](https://www.typescriptlang.org/play/?dtPR=75014&install-plugin=playground-dt-review).\n\n## Status\n\n * ✅ No merge conflicts\n * ✅ Continuous integration tests have passed\n * ✅ Only a DT maintainer can approve changes when there are new packages added\n\nAll of the items on the list are green. **To merge, you need to post a comment including the string \"Ready to merge\"** to bring in your changes.\n\n----------------------\n... diagnostics scrubbed ..." + "status": "@yusuke-oba1 Thank you for submitting this PR!\n\n***This is a live comment that I will keep updated.***\n\n## 1 package in this PR\n\n* `safie-sdk` (1.8) (*new!*) — [on npm](https://www.npmjs.com/package/safie-sdk), [on unpkg](https://unpkg.com/browse/safie-sdk@latest/)\n - 1 added owner: @SafieDev\n\n## Code Reviews\n\nThis PR adds a new definition, so it needs to be reviewed by a DT maintainer before it can be merged.\n\nYou can test the changes of this PR [in the Playground](https://www.typescriptlang.org/play/?dtPR=75014&install-plugin=playground-dt-review).\n\n## Status\n\n * ✅ No merge conflicts\n * ✅ Continuous integration tests have passed\n * ✅ Only a DT maintainer can approve changes when there are new packages added\n\nAll of the items on the list are green. **To merge, you need to post a comment including the string \"Ready to merge\"** to bring in your changes.\n\n----------------------\n... diagnostics scrubbed ..." }, { "tag": "merge-offer", diff --git a/packages/mergebot/src/_tests/fixtures/75097/derived.json b/packages/mergebot/src/_tests/fixtures/75097/derived.json index b4b548d2ba..b74f3af0a6 100644 --- a/packages/mergebot/src/_tests/fixtures/75097/derived.json +++ b/packages/mergebot/src/_tests/fixtures/75097/derived.json @@ -20,6 +20,7 @@ "pkgInfo": [ { "name": "discord-rpc", + "version": "4.0", "kind": "edit", "files": [ { diff --git a/packages/mergebot/src/_tests/fixtures/75097/mutations.json b/packages/mergebot/src/_tests/fixtures/75097/mutations.json index 305e2897af..4fc3213e0d 100644 --- a/packages/mergebot/src/_tests/fixtures/75097/mutations.json +++ b/packages/mergebot/src/_tests/fixtures/75097/mutations.json @@ -4,7 +4,7 @@ "variables": { "input": { "id": "IC_kwDOAFz6BM8AAAABFaTesw", - "body": "@brandonbothell Thank you for submitting this PR!\n\n***This is a live comment that I will keep updated.***\n\n## 1 package in this PR\n\n* `discord-rpc` — [on npm](https://www.npmjs.com/package/discord-rpc), [on unpkg](https://unpkg.com/browse/discord-rpc@latest/)\n - owner-approval: @dylhack\n - 1 added owner: ✎@brandonbothell\n\n## Code Reviews\n\nBecause you edited one package and there were no type definition changes, I can help you merge this PR once someone else signs off on it.\n\nYou can test the changes of this PR [in the Playground](https://www.typescriptlang.org/play/?dtPR=75097&install-plugin=playground-dt-review).\n\n## Status\n\n * ✅ No merge conflicts\n * ✅ Continuous integration tests have passed\n * ✅ Most recent commit is approved by type definition owners, DT maintainers or others\n\nAll of the items on the list are green. **To merge, you need to post a comment including the string \"Ready to merge\"** to bring in your changes.\n\n----------------------\n... diagnostics scrubbed ...\n" + "body": "@brandonbothell Thank you for submitting this PR!\n\n***This is a live comment that I will keep updated.***\n\n## 1 package in this PR\n\n* `discord-rpc` (4.0) — [on npm](https://www.npmjs.com/package/discord-rpc), [on unpkg](https://unpkg.com/browse/discord-rpc@latest/)\n - owner-approval: @dylhack\n - 1 added owner: ✎@brandonbothell\n\n## Code Reviews\n\nBecause you edited one package and there were no type definition changes, I can help you merge this PR once someone else signs off on it.\n\nYou can test the changes of this PR [in the Playground](https://www.typescriptlang.org/play/?dtPR=75097&install-plugin=playground-dt-review).\n\n## Status\n\n * ✅ No merge conflicts\n * ✅ Continuous integration tests have passed\n * ✅ Most recent commit is approved by type definition owners, DT maintainers or others\n\nAll of the items on the list are green. **To merge, you need to post a comment including the string \"Ready to merge\"** to bring in your changes.\n\n----------------------\n... diagnostics scrubbed ...\n" } } }, diff --git a/packages/mergebot/src/_tests/fixtures/75097/result.json b/packages/mergebot/src/_tests/fixtures/75097/result.json index 9cce6e0adf..1c4779b22f 100644 --- a/packages/mergebot/src/_tests/fixtures/75097/result.json +++ b/packages/mergebot/src/_tests/fixtures/75097/result.json @@ -8,7 +8,7 @@ "responseComments": [ { "tag": "welcome", - "status": "@brandonbothell Thank you for submitting this PR!\n\n***This is a live comment that I will keep updated.***\n\n## 1 package in this PR\n\n* `discord-rpc` — [on npm](https://www.npmjs.com/package/discord-rpc), [on unpkg](https://unpkg.com/browse/discord-rpc@latest/)\n - owner-approval: @dylhack\n - 1 added owner: ✎@brandonbothell\n\n## Code Reviews\n\nBecause you edited one package and there were no type definition changes, I can help you merge this PR once someone else signs off on it.\n\nYou can test the changes of this PR [in the Playground](https://www.typescriptlang.org/play/?dtPR=75097&install-plugin=playground-dt-review).\n\n## Status\n\n * ✅ No merge conflicts\n * ✅ Continuous integration tests have passed\n * ✅ Most recent commit is approved by type definition owners, DT maintainers or others\n\nAll of the items on the list are green. **To merge, you need to post a comment including the string \"Ready to merge\"** to bring in your changes.\n\n----------------------\n... diagnostics scrubbed ..." + "status": "@brandonbothell Thank you for submitting this PR!\n\n***This is a live comment that I will keep updated.***\n\n## 1 package in this PR\n\n* `discord-rpc` (4.0) — [on npm](https://www.npmjs.com/package/discord-rpc), [on unpkg](https://unpkg.com/browse/discord-rpc@latest/)\n - owner-approval: @dylhack\n - 1 added owner: ✎@brandonbothell\n\n## Code Reviews\n\nBecause you edited one package and there were no type definition changes, I can help you merge this PR once someone else signs off on it.\n\nYou can test the changes of this PR [in the Playground](https://www.typescriptlang.org/play/?dtPR=75097&install-plugin=playground-dt-review).\n\n## Status\n\n * ✅ No merge conflicts\n * ✅ Continuous integration tests have passed\n * ✅ Most recent commit is approved by type definition owners, DT maintainers or others\n\nAll of the items on the list are green. **To merge, you need to post a comment including the string \"Ready to merge\"** to bring in your changes.\n\n----------------------\n... diagnostics scrubbed ..." }, { "tag": "merge-offer", diff --git a/packages/mergebot/src/_tests/fixtures/75112-force-push/derived.json b/packages/mergebot/src/_tests/fixtures/75112-force-push/derived.json index 8eb08aba16..9f158033a2 100644 --- a/packages/mergebot/src/_tests/fixtures/75112-force-push/derived.json +++ b/packages/mergebot/src/_tests/fixtures/75112-force-push/derived.json @@ -17,6 +17,7 @@ "pkgInfo": [ { "name": "npmcli__config", + "version": "6.0", "kind": "edit", "files": [ { diff --git a/packages/mergebot/src/_tests/fixtures/75112-force-push/mutations.json b/packages/mergebot/src/_tests/fixtures/75112-force-push/mutations.json index 2723b7196b..72693eab9a 100644 --- a/packages/mergebot/src/_tests/fixtures/75112-force-push/mutations.json +++ b/packages/mergebot/src/_tests/fixtures/75112-force-push/mutations.json @@ -4,7 +4,7 @@ "variables": { "input": { "id": "IC_kwDOAFz6BM8AAAABF8jQRA", - "body": "@MattIPv4 Thank you for submitting this PR!\n\n***This is a live comment that I will keep updated.***\n\n## 1 package in this PR\n\n* `npmcli__config` — [on npm](https://www.npmjs.com/package/@npmcli/config), [on unpkg](https://unpkg.com/browse/@npmcli/config@latest/)\n\n## Code Reviews\n\nBecause you edited one package and updated the tests (👏), I can help you merge this PR once someone else signs off on it.\n\nYou can test the changes of this PR [in the Playground](https://www.typescriptlang.org/play/?dtPR=75112&install-plugin=playground-dt-review).\n\n## Status\n\n * ✅ No merge conflicts\n * ❓ Continuous integration tests have gone missing\n * 🕐 Most recent commit is approved by type definition owners, DT maintainers or others\n\nOnce every item on this list is checked, I'll ask you for permission to merge and publish the changes.\n\n----------------------\n... diagnostics scrubbed ...\n" + "body": "@MattIPv4 Thank you for submitting this PR!\n\n***This is a live comment that I will keep updated.***\n\n## 1 package in this PR\n\n* `npmcli__config` (6.0) — [on npm](https://www.npmjs.com/package/@npmcli/config), [on unpkg](https://unpkg.com/browse/@npmcli/config@latest/)\n\n## Code Reviews\n\nBecause you edited one package and updated the tests (👏), I can help you merge this PR once someone else signs off on it.\n\nYou can test the changes of this PR [in the Playground](https://www.typescriptlang.org/play/?dtPR=75112&install-plugin=playground-dt-review).\n\n## Status\n\n * ✅ No merge conflicts\n * ❓ Continuous integration tests have gone missing\n * 🕐 Most recent commit is approved by type definition owners, DT maintainers or others\n\nOnce every item on this list is checked, I'll ask you for permission to merge and publish the changes.\n\n----------------------\n... diagnostics scrubbed ...\n" } } }, diff --git a/packages/mergebot/src/_tests/fixtures/75112-force-push/result.json b/packages/mergebot/src/_tests/fixtures/75112-force-push/result.json index cf806c912a..898ecc2eb4 100644 --- a/packages/mergebot/src/_tests/fixtures/75112-force-push/result.json +++ b/packages/mergebot/src/_tests/fixtures/75112-force-push/result.json @@ -3,7 +3,7 @@ "responseComments": [ { "tag": "welcome", - "status": "@MattIPv4 Thank you for submitting this PR!\n\n***This is a live comment that I will keep updated.***\n\n## 1 package in this PR\n\n* `npmcli__config` — [on npm](https://www.npmjs.com/package/@npmcli/config), [on unpkg](https://unpkg.com/browse/@npmcli/config@latest/)\n\n## Code Reviews\n\nBecause you edited one package and updated the tests (👏), I can help you merge this PR once someone else signs off on it.\n\nYou can test the changes of this PR [in the Playground](https://www.typescriptlang.org/play/?dtPR=75112&install-plugin=playground-dt-review).\n\n## Status\n\n * ✅ No merge conflicts\n * ❓ Continuous integration tests have gone missing\n * 🕐 Most recent commit is approved by type definition owners, DT maintainers or others\n\nOnce every item on this list is checked, I'll ask you for permission to merge and publish the changes.\n\n----------------------\n... diagnostics scrubbed ..." + "status": "@MattIPv4 Thank you for submitting this PR!\n\n***This is a live comment that I will keep updated.***\n\n## 1 package in this PR\n\n* `npmcli__config` (6.0) — [on npm](https://www.npmjs.com/package/@npmcli/config), [on unpkg](https://unpkg.com/browse/@npmcli/config@latest/)\n\n## Code Reviews\n\nBecause you edited one package and updated the tests (👏), I can help you merge this PR once someone else signs off on it.\n\nYou can test the changes of this PR [in the Playground](https://www.typescriptlang.org/play/?dtPR=75112&install-plugin=playground-dt-review).\n\n## Status\n\n * ✅ No merge conflicts\n * ❓ Continuous integration tests have gone missing\n * 🕐 Most recent commit is approved by type definition owners, DT maintainers or others\n\nOnce every item on this list is checked, I'll ask you for permission to merge and publish the changes.\n\n----------------------\n... diagnostics scrubbed ..." }, { "tag": "pinging-reviewers", diff --git a/packages/mergebot/src/compute-pr-actions.ts b/packages/mergebot/src/compute-pr-actions.ts index 41b27e673d..82eaf4f3ee 100644 --- a/packages/mergebot/src/compute-pr-actions.ts +++ b/packages/mergebot/src/compute-pr-actions.ts @@ -552,7 +552,7 @@ function createWelcomeComment(info: ExtendedPrInfo, post: (c: Comments.Comment) const authorIsOwner = !p.owners.some(info.isAuthor) ? [] : [`(author is owner)`]; display( [ - `* \`${p.name}\`${kind} —`, + `* \`${p.name}\`${p.version ? ` (${p.version})` : ""}${kind} —`, `[on npm](https://www.npmjs.com/package/${urlPart}),`, `[on unpkg](https://unpkg.com/browse/${urlPart}@latest/)`, ...authorIsOwner, diff --git a/packages/mergebot/src/pr-info.ts b/packages/mergebot/src/pr-info.ts index 52bc288e92..b89c21897d 100644 --- a/packages/mergebot/src/pr-info.ts +++ b/packages/mergebot/src/pr-info.ts @@ -57,6 +57,7 @@ interface BotEnsureRemovedFromProject { export interface PackageInfo { name: string | null; // null => not in a package (= infra files) + version?: string; kind: "edit" | "add" | "delete"; files: FileInfo[]; owners: string[]; // existing owners on master @@ -409,15 +410,17 @@ async function getPackageInfosEtc( const result: PackageInfo[] = []; let maxDownloads = 0; for (const [name, files] of infos) { - const oldOwners = !name ? null : await getOwnersOfPackage(name, baseId, fetchFile); - if (oldOwners instanceof Error) return oldOwners; - const newOwners0 = !name ? null : await getOwnersOfPackage(name, headId, fetchFile); + const oldMetadata = !name ? null : await getPackageMetadata(name, baseId, fetchFile); + if (oldMetadata instanceof Error) return oldMetadata; + const newMetadata0 = !name ? null : await getPackageMetadata(name, headId, fetchFile); // A header error is still an add/edit whereas a missing file is - // delete, hence newOwners0 here - const kind = !name ? "edit" : !oldOwners ? "add" : !newOwners0 ? "delete" : "edit"; + // delete, hence newMetadata0 here + const kind = !name ? "edit" : !oldMetadata ? "add" : !newMetadata0 ? "delete" : "edit"; // treats a header error as a missing file, the CI will fail anyway // (maybe add a way to pass the error in the info so people don't need to read the CI?) - const newOwners = newOwners0 instanceof Error ? null : newOwners0; + const newMetadata = newMetadata0 instanceof Error ? null : newMetadata0; + const newOwners = newMetadata?.owners ?? null; + const oldOwners = oldMetadata?.owners ?? null; const owners = oldOwners || []; const addedOwners = newOwners === null ? [] : oldOwners === null ? newOwners : newOwners.filter((o) => !oldOwners.includes(o)); @@ -435,7 +438,18 @@ async function getPackageInfosEtc( files[0]?.path === "attw.json" && (await isAllowedAttwEdit(headId, baseId, fetchFile)) : undefined; - result.push({ name, kind, files, owners, addedOwners, deletedOwners, popularityLevel, isSafeInfrastructureEdit }); + const version = newMetadata?.version ?? oldMetadata?.version; + result.push({ + name, + ...(version ? { version } : {}), + kind, + files, + owners, + addedOwners, + deletedOwners, + popularityLevel, + isSafeInfrastructureEdit, + }); } return { pkgInfo: result, popularityLevel: downloadsToPopularityLevel(maxDownloads) }; } @@ -739,6 +753,20 @@ export async function getOwnersOfPackage( oid: string, fetchFile: typeof defaultFetchFile, ): Promise { + const metadata = await getPackageMetadata(packageName, oid, fetchFile); + return metadata instanceof Error ? metadata : (metadata?.owners ?? null); +} + +interface PackageMetadata { + owners: string[]; + version?: string; +} + +async function getPackageMetadata( + packageName: string, + oid: string, + fetchFile: typeof defaultFetchFile, +): Promise { const packageJson = `${oid}:types/${packageName}/package.json`; const packageJsonContent = await fetchFile(packageJson, 10240); // grab at most 10k let packageJsonObj; @@ -749,6 +777,8 @@ export async function getOwnersOfPackage( if (e instanceof Error) return new Error(`error parsing owners from package.json: ${e.message}`); } } + const version = + typeof packageJsonObj?.version === "string" ? /^(\d+\.\d+)\.9999$/.exec(packageJsonObj.version)?.[1] : undefined; if (!packageJsonObj || !(packageJsonObj.name && packageJsonObj.version && packageJsonObj.owners)) { // If we see that we're not in a post-pnpm world, try to get the owners from the index.d.ts. @@ -761,10 +791,16 @@ export async function getOwnersOfPackage( } catch (e) { if (e instanceof Error) return new Error(`error parsing owners: ${e.message}`); } - return noNullish(parsed!.contributors.map((c) => c.githubUsername)).filter(isValidGithubUsername); + return { + owners: noNullish(parsed!.contributors.map((c) => c.githubUsername)).filter(isValidGithubUsername), + ...(version ? { version } : {}), + }; } - return noNullish(packageJsonObj.owners?.map((c: any) => c?.githubUsername)).filter(isValidGithubUsername); + return { + owners: noNullish(packageJsonObj.owners?.map((c: any) => c?.githubUsername)).filter(isValidGithubUsername), + ...(version ? { version } : {}), + }; } // GitHub usernames: alphanumeric or single hyphens (plus underscores for Enterprise Managed