|
5 | 5 | # -------------------------------------------------------------------------- |
6 | 6 | """Tests for built-in feature filters.""" |
7 | 7 |
|
| 8 | +import inspect |
| 9 | +import json |
| 10 | +import pickle |
8 | 11 | import unittest |
9 | 12 | import pytest |
10 | 13 | from featuremanagement import FeatureManager, TargetingContext |
11 | 14 |
|
12 | 15 |
|
13 | 16 | class TestDefaultFeatureFlags(unittest.TestCase): |
| 17 | + def test_targeting_context_field_defaults_match_construction(self) -> None: |
| 18 | + defaults = TargetingContext._field_defaults # pylint: disable=protected-access |
| 19 | + parameters = inspect.signature(TargetingContext).parameters |
| 20 | + assert defaults == {name: parameter.default for name, parameter in parameters.items()} |
| 21 | + |
| 22 | + first = TargetingContext(**defaults) |
| 23 | + second = TargetingContext(**defaults) |
| 24 | + assert first == TargetingContext() |
| 25 | + first.groups.append("Admins") |
| 26 | + assert second.groups == [] |
| 27 | + assert TargetingContext().groups == [] |
| 28 | + |
| 29 | + def test_targeting_context_fields_are_read_only(self) -> None: |
| 30 | + context = TargetingContext("Alice", ["Admins"]) |
| 31 | + for field, value in (("user_id", "Bob"), ("groups", ["Users"]), ("extra", True)): |
| 32 | + with self.subTest(field=field), pytest.raises(AttributeError): |
| 33 | + setattr(context, field, value) |
| 34 | + assert context == TargetingContext("Alice", ["Admins"]) |
| 35 | + |
| 36 | + def test_targeting_context_serialization(self) -> None: |
| 37 | + context = TargetingContext("Alice", ["Admins"]) |
| 38 | + assert json.dumps(context) == '["Alice", ["Admins"]]' |
| 39 | + for protocol in (0, pickle.HIGHEST_PROTOCOL): |
| 40 | + with self.subTest(protocol=protocol): |
| 41 | + restored = pickle.loads(pickle.dumps(context, protocol=protocol)) |
| 42 | + self.assertIs(type(restored), TargetingContext) |
| 43 | + assert restored == context |
| 44 | + restored.groups.append("Users") |
| 45 | + assert context.groups == ["Admins"] |
| 46 | + |
| 47 | + def test_targeting_context_helpers_preserve_subclass(self) -> None: |
| 48 | + groups = ["Admins"] |
| 49 | + context = TargetingContext._make(("Alice", groups)) |
| 50 | + self.assertIs(type(context), TargetingContext) |
| 51 | + assert context == TargetingContext("Alice", groups) |
| 52 | + assert context.groups is groups |
| 53 | + |
| 54 | + renamed = context._replace(user_id="Bob") |
| 55 | + self.assertIs(type(renamed), TargetingContext) |
| 56 | + assert renamed == TargetingContext("Bob", ["Admins"]) |
| 57 | + assert renamed.groups is groups |
| 58 | + assert context == TargetingContext("Alice", ["Admins"]) |
| 59 | + |
| 60 | + def test_targeting_context_default_groups_are_independent(self) -> None: |
| 61 | + first = TargetingContext(user_id="Alice") |
| 62 | + second = TargetingContext(user_id="Bob") |
| 63 | + explicit_none = TargetingContext(groups=None) |
| 64 | + |
| 65 | + first.groups.append("Admins") |
| 66 | + |
| 67 | + assert first.groups == ["Admins"] |
| 68 | + assert second.groups == [] |
| 69 | + assert explicit_none.groups == [] |
| 70 | + assert TargetingContext().groups == [] |
| 71 | + |
| 72 | + def test_targeting_context_preserves_supplied_groups(self) -> None: |
| 73 | + groups: list[str] = [] |
| 74 | + context = TargetingContext("Alice", groups) |
| 75 | + |
| 76 | + context.groups.append("Admins") |
| 77 | + |
| 78 | + assert context.user_id == "Alice" |
| 79 | + assert context.groups is groups |
| 80 | + assert groups == ["Admins"] |
| 81 | + |
14 | 82 | def test_invalid_feature_flags(self): |
15 | 83 | with self.assertRaises(AttributeError): |
16 | 84 | FeatureManager("") |
@@ -53,6 +121,11 @@ def test_feature_manager_creation_with_targeting(self): |
53 | 121 | # Brian is not enabled because he is not in Stage 2, group isn't looked at when user is targeted |
54 | 122 | assert not feature_manager.is_enabled("Target", TargetingContext(user_id="Belle", groups=["Stage2"])) |
55 | 123 |
|
| 124 | + first = TargetingContext("Belle") |
| 125 | + first.groups.append("Stage1") |
| 126 | + assert feature_manager.is_enabled("Target", first) |
| 127 | + assert not feature_manager.is_enabled("Target", TargetingContext("Belle")) |
| 128 | + |
56 | 129 | # method: feature_manager_creation |
57 | 130 | def test_feature_manager_creation_with_time_window(self): |
58 | 131 | feature_flags = { |
|
0 commit comments