diff --git a/.chronus/changes/python-lro-typeddict-response-2026-09-21.md b/.chronus/changes/python-lro-typeddict-response-2026-09-21.md new file mode 100644 index 00000000000..c8abcfbd928 --- /dev/null +++ b/.chronus/changes/python-lro-typeddict-response-2026-09-21.md @@ -0,0 +1,7 @@ +--- +changeKind: fix +packages: + - "@typespec/http-client-python" +--- + +Return long-running operation response bodies when generating TypedDict-only models. diff --git a/packages/http-client-python/generator/pygen/codegen/serializers/builder_serializer.py b/packages/http-client-python/generator/pygen/codegen/serializers/builder_serializer.py index 52cfe05783d..224c2f2dfd1 100644 --- a/packages/http-client-python/generator/pygen/codegen/serializers/builder_serializer.py +++ b/packages/http-client-python/generator/pygen/codegen/serializers/builder_serializer.py @@ -1843,7 +1843,7 @@ def get_long_running_output(self, builder: LROOperationType) -> list[str]: if builder.lro_response.headers: retval.append(" response_headers = {}") if ( - (not self.code_model.options["models-mode"] and not self.code_model.generate_typeddict_only) + not self.code_model.options["models-mode"] or self.code_model.options["models-mode"] == "dpg" or builder.lro_response.headers ): diff --git a/packages/http-client-python/tests/unit/test_lro_response.py b/packages/http-client-python/tests/unit/test_lro_response.py new file mode 100644 index 00000000000..f7754cbe72c --- /dev/null +++ b/packages/http-client-python/tests/unit/test_lro_response.py @@ -0,0 +1,40 @@ +# ------------------------------------------------------------------------- +# Copyright (c) Microsoft Corporation. All rights reserved. +# Licensed under the MIT License. See License.txt in the project root for +# license information. +# -------------------------------------------------------------------------- + +from types import SimpleNamespace + +import pytest + +from pygen.codegen.serializers.builder_serializer import LROOperationSerializer + + +@pytest.fixture(scope="session", autouse=True) +def testserver(): + yield + + +class _TestLROOperationSerializer(LROOperationSerializer): + def response_headers_and_deserialization(self, builder, response): + return ["deserialized = response.json()"] + + +@pytest.mark.parametrize("models_mode", [None, "dpg"]) +@pytest.mark.parametrize("generate_typeddict_only", [False, True]) +def test_lro_response_is_available_for_deserialization(models_mode, generate_typeddict_only): + code_model = SimpleNamespace( + options={"models-mode": models_mode}, + generate_typeddict_only=generate_typeddict_only, + get_serialize_namespace=lambda *args, **kwargs: "test", + ) + serializer = _TestLROOperationSerializer(code_model, async_mode=False, client_namespace="test") + operation = SimpleNamespace( + lro_response=SimpleNamespace(headers=[], type=object()), + ) + + generated = serializer.get_long_running_output(operation) + + assert " response = pipeline_response.http_response" in generated + assert " deserialized = response.json()" in generated