The not_landed rule leaves its needinfo flags open after the patch lands and the bug is resolved.
For example, Bug 2057383 was needinfoed by BugBot on August 14. The patch landed and the bug was resolved on August 17, but both needinfos remained open until they were manually cleared on August 20 and August 29.
Because the needinfo is specifically asking about an approved patch that has not landed, it is no longer actionable once the revision is published or the bug is resolved as fixed. BugBot should clear the needinfo flags created by not_landed when that condition is no longer true.
This is related to #2404, but narrower: rather than notifying people about all pending needinfos on closed bugs, not_landed should clean up the flags it created when the patch lands.
The
not_landedrule leaves its needinfo flags open after the patch lands and the bug is resolved.For example, Bug 2057383 was needinfoed by BugBot on August 14. The patch landed and the bug was resolved on August 17, but both needinfos remained open until they were manually cleared on August 20 and August 29.
Because the needinfo is specifically asking about an approved patch that has not landed, it is no longer actionable once the revision is published or the bug is resolved as fixed. BugBot should clear the needinfo flags created by
not_landedwhen that condition is no longer true.This is related to #2404, but narrower: rather than notifying people about all pending needinfos on closed bugs,
not_landedshould clean up the flags it created when the patch lands.