Skip to content

Commit cd03433

Browse files
authored
build: enable V8 undefined double support
V8 14.6 enables v8_enable_undefined_double by default in its GN build, but the GYP configuration never set V8_ENABLE_UNDEFINED_DOUBLE, so the default build ran V8 in a non-default configuration. Enabling it eliminates the repeated wrong-map deoptimizations in big.js reported in #66717. Align the GYP configuration with V8's default, matching the change made on main in 8394db3. Refs: 8394db3 Fixes: #66717 Signed-off-by: inoway46 <inoueyuya416@gmail.com> Assisted-by: Codex Assisted-by: Claude Code PR-URL: #66733 Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
1 parent aafda1a commit cd03433

1 file changed

Lines changed: 6 additions & 0 deletions

File tree

‎tools/v8_gypfiles/features.gypi‎

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -294,6 +294,9 @@
294294
# ReadOnlySpace.
295295
'v8_enable_extensible_ro_snapshot%': 1,
296296

297+
# Use the encoding of undefined in double values.
298+
'v8_enable_undefined_double%': 1,
299+
297300
# Variables from v8.gni
298301

299302
# Enable ECMAScript Internationalization API. Enabling this feature will
@@ -524,6 +527,9 @@
524527
['v8_enable_extensible_ro_snapshot==1', {
525528
'defines': ['V8_ENABLE_EXTENSIBLE_RO_SNAPSHOT',],
526529
}],
530+
['v8_enable_undefined_double==1', {
531+
'defines': ['V8_ENABLE_UNDEFINED_DOUBLE',],
532+
}],
527533
['v8_enable_leaptiering==1', {
528534
'defines': ['V8_ENABLE_LEAPTIERING',],
529535
}],

0 commit comments

Comments
 (0)