Hello! For the VAULT_ADDR endpoint value, if the caller provides a value that includes a trailing slash, eg; http://127.0.0.1:8200/, the library currently does not handle it well.
We can see that the full uri is constructed here: https://github.com/kr1sp1n/node-vault/blob/70097269d35a58bb560b5290190093def96c87b1/src/index.js#L91
...with a trailing slash concatenated into the uri after the client.endpoint.
We would like to submit a PR that addresses the problem with a client.endpoint value that includes a trailing slash, by automatically handling it by removing that trailing slash from the endpoint value.
Thoughts/comments/discussion appreciated.
Hello! For the VAULT_ADDR endpoint value, if the caller provides a value that includes a trailing slash, eg;
http://127.0.0.1:8200/, the library currently does not handle it well.We can see that the full uri is constructed here: https://github.com/kr1sp1n/node-vault/blob/70097269d35a58bb560b5290190093def96c87b1/src/index.js#L91
...with a trailing slash concatenated into the uri after the
client.endpoint.We would like to submit a PR that addresses the problem with a client.endpoint value that includes a trailing slash, by automatically handling it by removing that trailing slash from the endpoint value.
Thoughts/comments/discussion appreciated.