ValueError: unconverted data remains: AM

[lsaffre]

I had the following traceback:

Traceback (most recent call last):
...
File "/usr/local/lino/lino_local/stewards/env/lib/python3.13/site-packages/asgiref/sync.py", line 372, in main_wrap
result = await awaitable
^^^^^^^^^^^^^^^
File "/usr/local/lino/lino_local/stewards/env/lib/python3.13/site-packages/lino_xl/lib/weather/models.py", line 184, in aget_weather_forecasts
return await client.get(dd.plugins.weather.place_name) # DailyForecast
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/usr/local/lino/lino_local/stewards/env/lib/python3.13/site-packages/python_weather/client.py", line 185, in get
return Forecast(await resp.json(content_type='text/plain'), unit, locale)
File "/usr/local/lino/lino_local/stewards/env/lib/python3.13/site-packages/python_weather/forecast.py", line 262, in __init__
datetime.strptime(current['observation_time'], '%I:%M %p').time(),
~~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/usr/lib/python3.13/_strptime.py", line 673, in _strptime_datetime
tt, fraction, gmtoff_fraction = _strptime(data_string, format)
~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^
File "/usr/lib/python3.13/_strptime.py", line 455, in _strptime
raise ValueError("unconverted data remains: %s" %
data_string[found.end():])
ValueError: unconverted data remains: AM

[lsaffre]

My workaround:

Edit file ...env/lib/python3.13/site-packages/python_weather/forecast.py and insert a line

from dateutil import parser

and in line 262, replace:

datetime.strptime(current['observation_time'], '%I:%M %p').time(),

by:

parser.parse(current['observation_time']).time(),

But I ignore whether the result is even correct.

[null8626]

Hello, @lsaffre! Can you give me an example query that causes this bug? It seems odd that wttr.in would randomly not include the AM/PM suffix... so far I am unable to make a query that deliberately makes observation_time only show HH:MM.

[lsaffre]

I'll try to collect examples. My plan is to have python-weather log the result somewhere before parsing it.

[lsaffre]

I got python-weather to log the json dict of every incoming request to the application's Python logger before parsing it. But that's not enough: the dict is very big, even when logging using pprint some lines are longer than a terminal line, so I would not be able to copy and report that data reliably. Next step is to have python-weather write the dict to a .json file. Mayb add a keyword argument "logfile" to the Client.init() method, and ecah Client.get() then would the json data to that file before instantiating the Forecast().

[lsaffre]

Here is a json file of received data where this error occurred:

20260819_1321.json

[lsaffre]

Hello, @lsaffre! Can you give me an example query that causes this bug? It seems odd that wttr.in would randomly not include the AM/PM suffix... so far I am unable to make a query that deliberately makes observation_time only show HH:MM.

I think it is the opposite: some request returns a timestamp where "AM" is appended after the time, but the parser doesn't expect it.