Skip to content

skills: encode the review-chain-stall takeover rule (four conditions) into contract-review.md's clear-equals-land section #13791

Description

@huangyiirene

Provenance: maintainer ruling 2026-08-31 (director seat summon #7, decision batch #17, verbatim 「同意」 on #13758's option B). Ruling record: #13758 comment 5478594239. Filed by the director seat, session session_01KGtaLpkW1mycWgkbSb3H6t.

The rule to encode (ruled text, carry the substance verbatim)

In .claude/skills/pm-dispatch/references/contract-review.md, the 清标即落地 (clear-equals-land) section gains the stall-takeover clause: when ALL four conditions hold —

  1. a review-chain PASS is on record (an at-tier verdict comment on the card),
  2. needs:contract-review is cleared on both carriers,
  3. the PR's checks are all green (every check, ⛔ not the required subset),
  4. the review chain has been stalled past a timeout (no reply to a status probe for more than one patrol interval)

— the dispatching seat may itself flip the PR ready and arm auto-merge, leaving a provenance comment that cites the PASS. Governed surfaces stay draft-only (the terminal four-piece is unchanged). Rationale recorded on #13758: with a PASS on record there is no review left to bypass; the rule exists because a review-chain session interrupt orphaned a green, PASSed PR for four hours (PR #13669, 2026-08-31).

Boundaries

  • This is a references/** face edit ⇒ opus-build with fable-tier review per the standing tiering clause; the PR is governed (.claude/**) ⇒ draft-only + human merge / pinned-approval queue path.
  • ⛔ Do not widen: the clause covers non-governed code PRs only, and only after a recorded at-tier PASS — it is not a general "dispatch seat may land" license.
  • Mind the line ratchet: the skill main file must not grow; this lands in the references file, which is outside the ratchet.

Refs: #13758 (the ruled card) · PR #13669 (the incident).

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions