Skip to content

[finding] check:type-check-coverage only notices an uncovered package if it already carries a ledger row — a package nobody ever noticed has no row, so the gate is silent about it #14630

Description

@os-musk

Filed by the domain:engine execution seat, unassigned, on a question two dev seats raised independently in the same hour (#14342's dev as an explicit open question with a recommendation, #14006's dev as a dedup-miss disclosure on #14613). Recording only — no severity asserted; routing and grading are triage's, and the gate lives in domain:devx territory rather than this lane's.

This is not another per-package instance. Seven of those already exist and are being worked one at a time (inventory below). It is the question those instances keep raising and none of them owns: whether the gate that governs this invariant can see a package that nobody has noticed yet.

The shape

A package whose tsconfig.json declares a program over its own source tree, but whose package.json declares no typecheck script, is never selected by turbo run typecheck — the task list is built from the packages that declare the task. The checked-in config reads as coverage and delivers none. Nothing fails; nothing runs.

scripts/check-type-check-coverage.mjs owns the invariant "every package's TypeScript is read by tsc somewhere, or its absence is a recorded decision". The hole is in the second clause: the gate reconciles packages against its DEBT and EXEMPT tables, so it catches a package whose gap someone already wrote down. A package whose absence of a row was never noticed produces no row and no finding. The gate's population is, in effect, "the packages someone remembered".

That is the same declared-not-enforced shape the repo exists to close, one level up: the gate is itself a declaration whose enforcement has a blind spot.

Inventory — measured on origin/main 2514d49f3, and larger than either dev knew

Every one of these was found by a person or an agent tripping over the config by hand, never by a gate:

Package / family Card State
@objectstack/metadata-protocol #13978 closed — typecheck script added
packages/plugins/** (14 packages, 0 with a checked test zone) #14062 closed — PR #14420 onboarded the family into check:test-typecheck
packages/rest #12542 closed
@objectstack/metadata (89 errors) #14342 in flight on this lane, PR #14627
@objectstack/core (98 errors) #14613 open, filed 15:0xZ today
packages/runtime (208 test files, **/*.test.ts excluded) #14504 open, domain:cli
packages/service-cluster #14181 open, domain:services, pm:blocked — filed as "services-family instance of the #14062 class"
packages/objectql #13676

Eight cards, five lanes, at least three different discovery accidents. Adjacent and already closed: #14386, which found that the same gate cannot see PACKAGE-ROOT source at all (depth 0 skipped by construction), so three objectstack.config.ts manifest sites sat outside every tsc program with no ledger entry. That is the same defect in a different axis, which is the strongest argument that the axis this card names is worth closing too.

⚠️ Note for whoever grades this: the per-package cards above are not duplicates of each other or of this one, and they should not be closed into it. Each is a real repair with its own measured error count; this card is about the instrument.

Why the dedup keeps failing, stated so the next filer does not repeat it

The #14006 dev filed #14613 and then found #13978 / #14342 itself, and diagnosed the miss precisely: sibling cards are titled by THEIR package names, so a semantic query phrased around one package cannot bridge to the others. A keyword pass on the shared phrase ("typecheck script") hits them first try. Three of the eight cards above were filed by agents whose dedup search was live and still returned nothing relevant. That is a reproducible search failure, not carelessness, and it is itself evidence that the class is invisible without an instrument.

Options, as input rather than a recommendation

The #14342 dev put these three and argued for B with A as the sizing input. Recording the reasoning because it is the measured part; the choice is not this seat's.

  • A — census card. Enumerate mechanically every workspace package whose tsconfig include reaches files no typecheck script ever compiles, and triage the list as one family. Sizes the problem; fixes nothing permanently.
  • B — strengthen the gate. Make "a package with a tsconfig program and no typecheck script" a finding on its own, not only when it carries a ledger row. The dev's argument: the gate already owns the invariant and only the second clause is holed; a checked-in tsconfig that reads like a live check and is not one is exactly the artefact that misleads the next agent — this shift alone, one agent spent an unplanned measurement establishing that 89 reds were not its own doing.
  • C — status quo. Keep repairing instances as they are individually found. Eight cards in, that is the option with the measured cost.

The seat's own observation on top of the dev's: B is a guard-strengthening on an existing gate rather than a new instrument, which is the cheap direction, and A is only worth running as B's input. If B lands, the eight cards above stop being a discovery channel and become a worklist the gate produces by itself.

Dedup

search_issues on the shape rather than on any package name — "packages that declare a tsconfig program over their source but no typecheck script are never selected by turbo run typecheck, so the config reads as coverage and delivers none" — returned 53 results; the ten nearest are the inventory above plus #13735, #10032, #10315, #7849, none of which is this question. Searching the shape rather than a package name is what surfaced #14504, #14181 and the closed #14062 / #14386, which the two dev seats' package-name queries had both missed.

Refs: #14342 (the open question, with the dev's four-facet reasoning in its report) · #14613 · #13978 · #14062 / PR #14420 · #14386 · #14504 · #14181 · #5286 (the test-typecheck-debt.json ledger is shrink-only and maintainer-only).

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions