Skip to content

[finding] serve.ts names apps/objectos as the host-config example, but that app does not exist in this repo — two readers took it as a real in-repo case #14634

Description

@os-trump

Found while measuring #14397 (dev seat, session session_016yfqQh2dBgPAymYd7xipza, branch claude/issue-14397-os-dev-host-config-registrars). Filed unassigned for triage. ⛔ Out of scope for that card and not fixed by its PR (#14631), which touches only the registrar decision.

The drift

packages/cli/src/commands/serve.ts names apps/objectos as the worked example of a host/aggregator config, in the comment above the AppPlugin wrap:

      // To avoid double-registration when the host already wraps itself with
      // an AppPlugin (e.g. apps/objectos's dev-workspace stack), we skip if
      // any plugin in `plugins[]` is already an AppPlugin instance.

There is no apps/objectos in this repo. ls apps/ returns exactly one entry, docs. Re-check at origin/main:

git grep -n "objectos" -- packages/cli/src
ls apps/

Why it is worth a card rather than a shrug

It is not a cosmetic stale name — it is the only worked example the file offers for a boot shape that behaves differently from every other, and two independent readers took it as a real, checkable in-repo case:

The dev seat that took the measurement had to discover the app was absent and find a substitute before it could start. The repo does have real host configs — examples/app-showcase is one (plugins[] holds new ConnectorOpenApiPlugin(), new ConnectorMcpPlugin(...), new ConnectorRestPlugin(...), new ConnectorSlackPlugin(...), plus the marketplace and runtime-config plugins) and it declares all four ADR-0057 security collections, so it exercises the comment's exact concern.

A comment that names a path is a checkable claim; this one is checkable and false, and it points the next reader at a directory listing rather than at code. Naming an in-repo example instead would make the same point and stay true, and it would be greppable.

Scope of the drift, as measured

objectos appears in packages/cli/src only in prose, never in a path resolution or a code branch — so nothing executes differently because of it. This is a comment-accuracy finding, not a behaviour bug; the reason to fix it is that it already misdirected a triage decision and a dispatch.

Suggested disposition

Repoint the comment at an in-repo host config (examples/app-showcase), or drop the parenthetical and describe the SHAPE (a config whose plugins[] already holds an AppPlugin instance) without naming an app. Either is a one-line docs-class change. ⛔ Do not add an apps/objectos to satisfy the comment.

Refs: #14397 (the card whose measurement surfaced this), #14631 (its PR, which deliberately leaves the comment alone).

Generated by Claude Code

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions