Remove every @SuppressWarnings but Immutable's

Of the 110 annotations 105 hid nothing. 94 named their checks with
palantir-baseline's for-rollout: prefix, which plain Error Prone does
not take for the check's name: NullAway and the rest reported those
lines all along. Others named checks this build does not run
(TooManyArguments, ImmutablesStyle), IntelliJ inspections, or javac's
unchecked lint, which is off. Without UnicodeEscape's, its one finding
shows.

The five on Doc's and Level's memoized suppliers stay: Immutable is an
error, and the suppliers are mutable caches that the check rightly
rejects. They need their own change.

Author: abashev

gradle-open-java-format/src/main/java/com/palantir/javaformat/gradle/FormatDiff.java

@@ -129,7 +129,6 @@ private static Path gitTopLevelDir(Path dir) throws IOException, InterruptedExce
         return Paths.get(gitCommand(dir, "git", "rev-parse", "--show-toplevel"));
     }
 
-    @SuppressWarnings("for-rollout:DefaultCharset")
     private static String gitCommand(Path dir, String... args) throws IOException, InterruptedException {
         Process process =
                 new ProcessBuilder().command(args).directory(dir.toFile()).start();

gradle-open-java-format/src/main/java/com/palantir/javaformat/gradle/FormatterServiceLoader.java

@@ -69,7 +69,6 @@ public static synchronized FormatterService load(Collection<File> jars) {
         return LOADED.computeIfAbsent(key, _key -> loadUncached(jars));
     }
 
-    @SuppressWarnings("for-rollout:NullAway")
     private static FormatterService loadUncached(Collection<File> jars) {
         URL[] jarUris = jars.stream()
                 .map(file -> {

gradle-open-java-format/src/main/java/com/palantir/javaformat/gradle/PalantirJavaFormatProviderPlugin.java

@@ -25,7 +25,6 @@ public final class PalantirJavaFormatProviderPlugin implements Plugin<Project> {
 
     static final String CONFIGURATION_NAME = "palantirJavaFormat";
 
-    @SuppressWarnings({"for-rollout:GradleTypesAsFields", "for-rollout:NonAbstractGradleType"})
     @Override
     public void apply(Project rootProject) {
         Preconditions.checkState(
@@ -34,7 +33,6 @@ public void apply(Project rootProject) {
 
         rootProject.getPluginManager().apply(NativeImageFormatProviderPlugin.class);
 
-        @SuppressWarnings("for-rollout:ConfigurationAvoidanceRegistration")
         Configuration configuration = rootProject.getConfigurations().create(CONFIGURATION_NAME, conf -> {
             conf.setDescription("Internal configuration for resolving the open-java-format implementation");
             conf.setCanBeConsumed(false);

gradle-open-java-format/src/main/java/com/palantir/javaformat/gradle/spotless/NativePalantirJavaFormatStep.java

@@ -47,12 +47,10 @@ static class State implements Serializable {
 
         // Kept for state serialization purposes.
         // For more details, see PalantirJavaFormatStep.State#jarSignature
-        @SuppressWarnings({"unused", "FieldCanBeLocal"})
         private FileSignature execSignature;
 
         private final transient Supplier<File> execSupplier;
 
-        @SuppressWarnings("for-rollout:NullAway")
         State(Supplier<File> supplier) {
             this.execSupplier = supplier;
         }

open-java-format-idea-plugin/src/main/java/com/palantir/javaformat/intellij/PalantirJavaFormatSettings.java

@@ -37,28 +37,25 @@
 
 import static java.util.Optional.ofNullable;
 
-@SuppressWarnings("for-rollout:SameNameButDifferent")
 @State(
         name = "PalantirJavaFormatSettings",
         storages = {@Storage("open-java-format.xml")})
 public class PalantirJavaFormatSettings implements PersistentStateComponent<PalantirJavaFormatSettings.State> {
 
-    @SuppressWarnings("for-rollout:SameNameButDifferent")
     private State state = new State();
 
     static PalantirJavaFormatSettings getInstance(Project project) {
         return project.getService(PalantirJavaFormatSettings.class);
     }
 
-    @SuppressWarnings("for-rollout:SameNameButDifferent")
     @Nullable
     @Override
     public State getState() {
         return state;
     }
 
     @Override
-    public void loadState(@SuppressWarnings("for-rollout:SameNameButDifferent") State state) {
+    public void loadState(State state) {
         this.state = state;
     }
 
@@ -167,7 +164,6 @@ public void setImplementationClassPath(@Nullable List<String> value) {
                     .map(strings -> strings.stream().map(URI::create).collect(Collectors.toList()));
         }
 
-        @SuppressWarnings("for-rollout:NullAway")
         public List<String> getImplementationClassPath() {
             return implementationClassPath
                     .map(paths -> paths.stream().map(URI::toString).collect(Collectors.toList()))
@@ -185,7 +181,6 @@ public void setEnabled(@Nullable String enabledStr) {
             }
         }
 
-        @SuppressWarnings("for-rollout:NullAway")
         public String getEnabled() {
             return switch (enabled) {
                 case ENABLED -> "true";

open-java-format-idea-plugin/src/test/java/com/palantir/javaformat/intellij/PalantirJavaFormatFormattingServiceTest.java

@@ -127,7 +127,6 @@ private PsiFile createPsiFile(String path, String... contents) throws IOExceptio
     }
 
     private static final class DelegatingFormatter extends PalantirJavaFormatFormattingService {
-        @SuppressWarnings("DataFlowIssue")
         public DelegatingFormatter() {
             this.setPluginDescriptor(FormattingService.EP_NAME
                     .findExtension(PalantirJavaFormatFormattingService.class)

open-java-format-jdk-bootstrap/src/main/java/com/palantir/javaformat/bootstrap/BootstrappingFormatterService.java

@@ -86,7 +86,6 @@ private ImmutableList<Replacement> getFormatReplacementsInternal(String input, C
                 /* outputReplacements= */ true,
                 ranges.stream().map(RangeUtils::toStringRange).collect(Collectors.toList()));
 
-        @SuppressWarnings("for-rollout:NullAway")
         Optional<String> output =
                 FormatterCommandRunner.runWithStdin(command.toArgs(), input, Optional.of(jdkPath.getParent()));
         if (output.isEmpty() || output.get().isEmpty()) {

open-java-format/src/main/java/com/palantir/javaformat/Newlines.java

@@ -53,7 +53,6 @@ public static int hasNewlineAt(String input, int idx) {
     }
 
     /** Returns the terminating line break in the input, or {@code null} if the input does not end in a break. */
-    @SuppressWarnings("for-rollout:NullAway")
     public static String getLineEnding(String input) {
         for (String b : BREAKS) {
             if (input.endsWith(b)) {
@@ -160,7 +159,6 @@ private static final class LineIterator implements Iterator<String> {
         private final String input;
         private final Iterator<Integer> indices;
 
-        @SuppressWarnings("for-rollout:NullAway")
         private LineIterator(String input) {
             this.input = input;
             this.indices = lineOffsetIterator(input);

open-java-format/src/main/java/com/palantir/javaformat/OpsBuilder.java

@@ -50,15 +50,13 @@ public final class OpsBuilder {
     /** Return the actual size of the AST node at position, including comments. */
     public int actualSize(int position, int length) {
         Input.Token startToken = input.getPositionTokenMap().get(position);
-        @SuppressWarnings("for-rollout:NullAway")
         int start = startToken.getTok().getPosition();
         for (Input.Tok tok : startToken.getToksBefore()) {
             if (tok.isComment()) {
                 start = Math.min(start, tok.getPosition());
             }
         }
         Input.Token endToken = input.getPositionTokenMap().get(position + length - 1);
-        @SuppressWarnings("for-rollout:NullAway")
         int end = endToken.getTok().getPosition() + endToken.getTok().length();
         for (Input.Tok tok : endToken.getToksAfter()) {
             if (tok.isComment()) {
@@ -71,7 +69,6 @@ public int actualSize(int position, int length) {
     /** Return the start column of the token at {@code position}, including leading comments. */
     public Integer actualStartColumn(int position) {
         Input.Token startToken = input.getPositionTokenMap().get(position);
-        @SuppressWarnings("for-rollout:NullAway")
         int start = startToken.getTok().getPosition();
         int line0 = input.getLineNumber(start);
         for (Input.Tok tok : startToken.getToksBefore()) {

open-java-format/src/main/java/com/palantir/javaformat/doc/Comment.java

@@ -157,7 +157,6 @@ protected Range<Integer> computeRange() {
     public State computeBreaks(
             CommentsHelper commentsHelper, int maxWidth, State state, Obs.ExplorationNode observationNode) {
         String text = commentsHelper.rewrite(tok, maxWidth, state.column());
-        @SuppressWarnings("for-rollout:NullAway")
         int lastLineStart = Iterators.getLast(Newlines.lineOffsetIterator(text));
         int lastLineLength = text.length() - lastLineStart;
         // rewrite() indents every line after the first to state.column(), so after a comment that spans lines the