diff --git a/open-java-format-idea-plugin/src/main/java/com/palantir/javaformat/intellij/PalantirJavaFormatFormattingService.java b/open-java-format-idea-plugin/src/main/java/com/palantir/javaformat/intellij/PalantirJavaFormatFormattingService.java index 82f13ca31..58d53559f 100644 --- a/open-java-format-idea-plugin/src/main/java/com/palantir/javaformat/intellij/PalantirJavaFormatFormattingService.java +++ b/open-java-format-idea-plugin/src/main/java/com/palantir/javaformat/intellij/PalantirJavaFormatFormattingService.java @@ -150,7 +150,8 @@ public void run() { request.onTextReady(formattedText); } } catch (FormatterException e) { - logger.error( + // A syntax error in the file, not a fault of the plugin: an error would go to its error reports. + logger.warn( String.format( "Failed to format file %s", request.getContext().getContainingFile().getName()), @@ -163,8 +164,9 @@ public void run() { throw e; } catch (RuntimeException e) { // Typically the formatter's JVM failing to start or exiting with an error. Left alone, the IDE - // swallows it and Reformat looks as if it did nothing. - logger.warn("open-java-format could not run the formatter", e); + // swallows it and Reformat looks as if it did nothing. An error rather than a warning, so that it goes + // to the plugin's error reports on the JetBrains Marketplace (see errorHandler in plugin.xml). + logger.error("open-java-format could not run the formatter", e); request.onError( Notifications.GENERIC_ERROR_NOTIFICATION_GROUP, Notifications.formatterFailedMessage( diff --git a/open-java-format-idea-plugin/src/main/resources/META-INF/plugin.xml b/open-java-format-idea-plugin/src/main/resources/META-INF/plugin.xml index dbb6a570a..a4a5bf339 100644 --- a/open-java-format-idea-plugin/src/main/resources/META-INF/plugin.xml +++ b/open-java-format-idea-plugin/src/main/resources/META-INF/plugin.xml @@ -33,6 +33,11 @@ + +