From a3b83f35365b41be3fcd8f4278a1b32e8b781670 Mon Sep 17 00:00:00 2001 From: JP-Ellis Date: Fri, 20 Nov 2026 14:31:44 +1100 Subject: [PATCH 1/4] docs: use the emphasis-style rule name in disable comments The changelogs and the git-cliff templates that generate them disabled `emph-style`, which no linter defines. markdownlint ignored the unknown name without a warning, so the comment never took effect. The rule is `emphasis-style` (MD049). Assisted-by: Claude Code:claude-opus-5-5 --- CHANGELOG.md | 2 +- cliff.toml | 2 +- pact-python-ffi/CHANGELOG.md | 2 +- pact-python-ffi/cliff.toml | 2 +- 4 files changed, 4 insertions(+), 4 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index f896c2d55..e37089b24 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -3,7 +3,7 @@ All notable changes to this project will be documented in this file. - + ## [pact-python/4.2.0] _2026-10-23_ diff --git a/cliff.toml b/cliff.toml index 6f5f7f9d5..95a0327ab 100644 --- a/cliff.toml +++ b/cliff.toml @@ -8,7 +8,7 @@ header = """ All notable changes to this project will be documented in this file. - + """ diff --git a/pact-python-ffi/CHANGELOG.md b/pact-python-ffi/CHANGELOG.md index b575af712..a5d9c28cf 100644 --- a/pact-python-ffi/CHANGELOG.md +++ b/pact-python-ffi/CHANGELOG.md @@ -5,7 +5,7 @@ All notable changes to this project will be documented in this file. Note that this _only_ includes changes to the Python FFI interface. For changes to the Pact FFI itself, see the [Pact FFI changelog](https://github.com/pact-foundation/pact-reference/blob/master/rust/pact_ffi/CHANGELOG.md). - + ## [pact-python-ffi/0.5.12.1] _2026-10-23_ diff --git a/pact-python-ffi/cliff.toml b/pact-python-ffi/cliff.toml index dacd83159..2857f56d5 100644 --- a/pact-python-ffi/cliff.toml +++ b/pact-python-ffi/cliff.toml @@ -11,7 +11,7 @@ All notable changes to this project will be documented in this file. Note that this _only_ includes changes to the Python FFI interface. For changes to the Pact FFI itself, see the [Pact FFI changelog](https://github.com/pact-foundation/pact-reference/blob/master/rust/pact_ffi/CHANGELOG.md). - + """ From e7f5095c3ec7519653664591927bf674eaa1870d Mon Sep 17 00:00:00 2001 From: JP-Ellis Date: Fri, 20 Nov 2026 14:31:47 +1100 Subject: [PATCH 2/4] chore: replace markdownlint-cli2 with rumdl rumdl implements the markdownlint rule set in Rust and reads `markdownlint-disable` comments, so the inline directives stay as they are. `.rumdl.toml` carries over the markdownlint options through `rumdl import`, plus three settings: - `exclude` with `force_exclude` keeps the PR template out of the run when prek passes it by path. `rumdl import` dropped the `ignores` key. - MD076 (list item spacing, new in rumdl) is disabled. git-cliff writes changelog lists that mix tight and loose items. - MD057 (relative link targets exist) is ignored under the MkDocs docs trees, whose links point at pages generated at build time. Assisted-by: Claude Code:claude-opus-5-5 --- .markdownlint-cli2.yaml | 33 --------------------------------- .rumdl.toml | 38 ++++++++++++++++++++++++++++++++++++++ prek.toml | 6 +++--- 3 files changed, 41 insertions(+), 36 deletions(-) delete mode 100644 .markdownlint-cli2.yaml create mode 100644 .rumdl.toml diff --git a/.markdownlint-cli2.yaml b/.markdownlint-cli2.yaml deleted file mode 100644 index cad769c4a..000000000 --- a/.markdownlint-cli2.yaml +++ /dev/null @@ -1,33 +0,0 @@ ---- -ignores: - - .github/PULL_REQUEST_TEMPLATE.md - -config: - default: true - - # Do not enforce line length - line-length: false - - # Adjust list indentation for 4 spaces - list-marker-space: - ul_single: 3 - ul_multi: 3 - ol_single: 2 - ol_multi: 2 - - ul-indent: - indent: 4 - - # Require fenced code blocks - code-block-style: - style: fenced - - # Disable checking for reference links, as MkDocs generates additional ones that - # are not visible to MarkdownLint. - reference-links-images: false - - strong-style: - style: asterisk - - emphasis-style: - style: underscore diff --git a/.rumdl.toml b/.rumdl.toml new file mode 100644 index 000000000..732620b94 --- /dev/null +++ b/.rumdl.toml @@ -0,0 +1,38 @@ +#:schema https://raw.githubusercontent.com/rvben/rumdl/main/rumdl.schema.json + +[global] +flavor = "mkdocs" +exclude = [".github/PULL_REQUEST_TEMPLATE.md"] +# Pre-commit hooks pass file paths explicitly; apply `exclude` to them too. +force_exclude = true +disable = [ + "line-length", + # MkDocs generates reference links that are not visible to the linter. + "reference-links-images", + # Changelogs generated by git-cliff mix tight and loose list items. + "MD076", +] + +[per-file-ignores] +# Docs link to pages that MkDocs generates at build time. +"docs/**/*.md" = ["MD057"] +"pact-python-ffi/docs/**/*.md" = ["MD057"] + +[ul-indent] +indent = 4 +style = "fixed" + +[list-marker-space] +ul-single = 3 +ul-multi = 3 +ol-single = 2 +ol-multi = 2 + +[code-block-style] +style = "fenced" + +[emphasis-style] +style = "underscore" + +[strong-style] +style = "asterisk" diff --git a/prek.toml b/prek.toml index fbfe4172c..e5c6de558 100644 --- a/prek.toml +++ b/prek.toml @@ -57,9 +57,9 @@ rev = "v1.1.11" hooks = [{ id = "committed" }] [[repos]] -repo = "https://github.com/DavidAnson/markdownlint-cli2" -rev = "v0.23.2" -hooks = [{ id = "markdownlint-cli2" }] +repo = "https://github.com/rvben/rumdl-pre-commit" +rev = "v0.3.5" +hooks = [{ id = "rumdl-check" }] [[repos]] repo = "https://github.com/crate-ci/typos" From 5ee5c537ab79c69be94b17537d5933466a90ed04 Mon Sep 17 00:00:00 2001 From: JP-Ellis Date: Fri, 20 Nov 2026 14:31:50 +1100 Subject: [PATCH 3/4] chore: remove VS Code configuration The shared extension recommendations and test settings were tied to one editor. Contributors keep their own editor configuration locally. Assisted-by: Claude Code:claude-opus-5-5 --- .vscode/extensions.json | 17 ----------------- .vscode/settings.json | 11 ----------- 2 files changed, 28 deletions(-) delete mode 100644 .vscode/extensions.json delete mode 100644 .vscode/settings.json diff --git a/.vscode/extensions.json b/.vscode/extensions.json deleted file mode 100644 index 360cbadb8..000000000 --- a/.vscode/extensions.json +++ /dev/null @@ -1,17 +0,0 @@ -{ - "recommendations": [ - "bierner.github-markdown-preview", - "biomejs.biome", - "charliermarsh.ruff", - "davidanson.vscode-markdownlint", - "editorconfig.editorconfig", - "github.vscode-github-actions", - "github.vscode-pull-request-github", - "ms-python.debugpy", - "ms-python.mypy-type-checker", - "ms-python.python", - "redhat.vscode-yaml", - "yzhang.markdown-all-in-one", - "tombi-toml.tombi" - ] -} diff --git a/.vscode/settings.json b/.vscode/settings.json deleted file mode 100644 index e6415bfbd..000000000 --- a/.vscode/settings.json +++ /dev/null @@ -1,11 +0,0 @@ -{ - "python.testing.pytestArgs": [ - "--reruns=0", - "--no-cov", - "examples/", - "pact-python-ffi/tests/", - "tests/" - ], - "python.testing.unittestEnabled": false, - "python.testing.pytestEnabled": true -} From 472460ab7db7f1a35fb3f8b9c4f2eb3637d971ba Mon Sep 17 00:00:00 2001 From: JP-Ellis Date: Fri, 20 Nov 2026 14:31:51 +1100 Subject: [PATCH 4/4] chore(deps): update prek hooks Bumps biome, ruff, committed, typos and tombi to their latest releases with `prek autoupdate`. Biome 2.6 formats and lints Markdown and YAML. Its Markdown formatter breaks MkDocs front matter and admonition fences, and turns dunder names such as `__repr__` into bold text. rumdl and yamlfix already own those files, so `biome.json` turns both languages off. `biome migrate` updated the schema and replaced `recommended` with `preset`. Assisted-by: Claude Code:claude-opus-5-5 --- biome.json | 12 ++++++++++-- prek.toml | 10 +++++----- 2 files changed, 15 insertions(+), 7 deletions(-) diff --git a/biome.json b/biome.json index d4d0fb13d..a73288d93 100644 --- a/biome.json +++ b/biome.json @@ -1,5 +1,5 @@ { - "$schema": "https://biomejs.dev/schemas/2.0.4/schema.json", + "$schema": "https://biomejs.dev/schemas/2.6.8/schema.json", "assist": { "actions": { "source": { "organizeImports": "on" } @@ -8,10 +8,18 @@ "linter": { "enabled": true, "rules": { - "recommended": true + "preset": "recommended" } }, "formatter": { "useEditorconfig": true + }, + "markdown": { + "formatter": { "enabled": false }, + "linter": { "enabled": false } + }, + "yaml": { + "formatter": { "enabled": false }, + "linter": { "enabled": false } } } diff --git a/prek.toml b/prek.toml index e5c6de558..1e6aa03ff 100644 --- a/prek.toml +++ b/prek.toml @@ -37,12 +37,12 @@ hooks = [ [[repos]] repo = "https://github.com/biomejs/pre-commit" -rev = "v2.5.6" +rev = "v2.6.8" hooks = [{ id = "biome-check" }] [[repos]] repo = "https://github.com/astral-sh/ruff-pre-commit" -rev = "v0.16.1" +rev = "v0.17.6" [[repos.hooks]] id = "ruff-check" @@ -53,7 +53,7 @@ rev = "v0.16.1" [[repos]] repo = "https://github.com/crate-ci/committed" -rev = "v1.1.11" +rev = "v1.1.12" hooks = [{ id = "committed" }] [[repos]] @@ -63,7 +63,7 @@ hooks = [{ id = "rumdl-check" }] [[repos]] repo = "https://github.com/crate-ci/typos" -rev = "v1.48.0" +rev = "v1.52.2" [[repos.hooks]] id = "typos" @@ -71,7 +71,7 @@ rev = "v1.48.0" [[repos]] repo = "https://github.com/tombi-toml/tombi-pre-commit" -rev = "v1.2.6" +rev = "v1.11.3" hooks = [{ id = "tombi-format" }, { id = "tombi-lint" }] [[repos]]