From 3b972ac09557fb158e4bb7d808fa4e451d99efd3 Mon Sep 17 00:00:00 2001 From: Codex Date: Wed, 28 Oct 2026 12:14:37 -0400 Subject: [PATCH 1/2] docs: focus coding-agent guidance on repo boundaries --- .agents/skills/open-pr/SKILL.md | 4 ++-- AGENTS.md | 6 +++--- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/.agents/skills/open-pr/SKILL.md b/.agents/skills/open-pr/SKILL.md index 59523cbeae..04d292a902 100644 --- a/.agents/skills/open-pr/SKILL.md +++ b/.agents/skills/open-pr/SKILL.md @@ -20,7 +20,7 @@ git diff --stat "$base"..HEAD The PR describes **only** these commits and this diff. Work that arrived by merging `main`, reverted commits, and patch-equivalent cherry-picks are not this PR's claims. If a file in the diff has no commit on the branch explaining it, stop and ask. -Run `bun run check-types` when the change is non-trivial; never claim a check you did not run. +Run relevant local checks; reuse checks that already cover the change. CI runs the required suite. Never claim a check you did not run. ## 2. Body = the repo template @@ -40,7 +40,7 @@ git push -u origin HEAD gh pr view --json number,url,body 2>/dev/null # existing PR? ``` -- None → `gh pr create --title … --body "$(cat <<'EOF' … EOF)"`. +- None → write the description to a file, then `gh pr create --title … --body-file `. - Exists → `gh pr edit --body …`: rebuild "What" and "How to test" from the current branch, keep the media section and the reviewer's checklist ticks verbatim, keep any extra sections at the end. Change the title only if the scope changed. End the body with the attribution lines the session asks for, if any. diff --git a/AGENTS.md b/AGENTS.md index 1ae3fcc8f0..4d3e6ba95d 100644 --- a/AGENTS.md +++ b/AGENTS.md @@ -2,7 +2,7 @@ Public, open-source home of `@pascal-app/{core,viewer,editor,nodes,mcp,cli,ifc-converter}` and the standalone editor app. Consumed as npm packages and, in `pascalorg/private-editor`, as a git submodule. -**Read `DECISIONS.md` first**: what Pascal is, the architecture invariants (E-IDs), the testing rule (T-001), and what is explicitly delegated to you. Everything else here is a map. +Use this map to find the owner of a change, then consult the relevant invariants in `DECISIONS.md` and the linked subsystem docs. Implementation choices are delegated to you. ## Packages @@ -29,7 +29,7 @@ Public, open-source home of `@pascal-app/{core,viewer,editor,nodes,mcp,cli,ifc-c ## Commands -`bun run ci` is exactly what CI runs (check, i18n:check, skills:validate, check-types, test, build). Localization catalog and language-pack guidance lives in `i18n/README.md`. The git hooks (installed by `bun install`) are fast feedback: Biome on staged files, typecheck of the packages you changed. +Use the Bun version in `package.json`. Run focused checks for the changed behavior; `bun run ci` runs the full suite when needed. Localization guidance lives in `i18n/README.md`. Git hooks provide staged-file checks and typechecks for changed packages. ## Working agreements @@ -37,4 +37,4 @@ Public, open-source home of `@pascal-app/{core,viewer,editor,nodes,mcp,cli,ifc-c - No compatibility shims, dead code or speculative abstractions; comments only for a non-obvious *why*. - Old scenes must still load after your change (E-003). - Never cite private-repo plan paths from this repo (E-015). -- Claude Code, Codex and other local coding agents work within the user's requested scope. An agent may merge its own PR with green required CI on the current head, any GitHub-required reviews satisfied, and no unresolved P0/P1 comments. Honor requests to leave work for review or unmerged. No named bot, bot label or external approval service is required. Human authorization remains required for secrets or keys, billing or spend, new access, sign-ins or 2FA, destructive or access-widening production data changes, and anything sent externally under a person's name; do not ask again when already authorized. CI stays required: never weaken, skip or bypass checks or branch protection. +- Complete authorized work; honor review-only requests. Merge on green required CI and actual GitHub reviews, resolving P0/P1 findings. No fleet approval is needed. Reuse authorization; obtain it for secrets, spend, new access, sign-ins, destructive or access-widening data, and messages under a person's name. Preserve checks and branch protection. From 834247a047e4a5c99114aeab13611b6211175f89 Mon Sep 17 00:00:00 2001 From: Codex Date: Wed, 28 Oct 2026 12:27:11 -0400 Subject: [PATCH 2/2] fix: allow the PR skill to write its description file --- .agents/skills/open-pr/SKILL.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.agents/skills/open-pr/SKILL.md b/.agents/skills/open-pr/SKILL.md index 04d292a902..4dfe549c06 100644 --- a/.agents/skills/open-pr/SKILL.md +++ b/.agents/skills/open-pr/SKILL.md @@ -3,7 +3,7 @@ name: open-pr description: Open or update a pull request on pascalorg/editor from the current branch, describing only what the branch actually did. Use when the user asks to open/create a PR, push and PR, or ship a branch in the editor repo. metadata: internal: true -allowed-tools: Bash(git *) Bash(gh *) Read +allowed-tools: Bash(git *) Bash(gh *) Read Write --- Open (or refresh) a pull request against `pascalorg/editor` from the current branch.