Brace invalid variable names in AST export of interpolated strings

Also switch the AST export name tests to zend_test_compile_to_ast().

Author: jorgsowa

Zend/tests/assert/ast_export_del_in_names.phpt

@@ -304,7 +304,7 @@ assert(0 && ($a = function (): ?static {
     $x = "{$a}b";
     $x = "{$a}b";
     $x = " {$foo->bar} {${$foo->bar}} ";
-    $x = " ${'---'} ";
+    $x = " {${'---'}} ";
     foo();
     \foo();
     namespace\foo();

Zend/tests/assert/ast_export_invalid_var_names.phpt

@@ -0,0 +1,57 @@
+--TEST--
+AST export of names containing 0x7f
+--EXTENSIONS--
+zend_test
+--FILE--
+<?php
+
+$code = <<<'PHP'
+<?php
+C::{"\x7f"};
+C::{"a\x7f"};
+C::{"\x7fa"};
+$o::{"\x7f"};
+C::{"\x7f"}();
+$o::{"\x7f"}();
+${"\x7f"};
+${"a\x7f"};
+$o->{"\x7f"};
+$o?->{"\x7f"};
+$o->{"\x7f"}();
+$o?->{"\x7f"}();
+C::${"\x7f"};
+"x{${"\x7f"}}y";
+"x{$o->{"\x7f"}}y";
+"{$a}\x7f";
+C::{"\x80"};
+${"\xff"};
+$o->{"a\x80"};
+"{$a}\x80";
+PHP;
+
+$export = zend_test_compile_to_ast($code);
+echo addcslashes($export, "\x7f..\xff");
+eval("return;\n$export");
+
+?>
+--EXPECT--
+C::{'\177'};
+C::{'a\177'};
+C::{'\177a'};
+$o::{'\177'};
+C::{'\177'}();
+$o::{'\177'}();
+${'\177'};
+${'a\177'};
+$o->{'\177'};
+$o?->{'\177'};
+$o->{'\177'}();
+$o?->{'\177'}();
+C::${'\177'};
+"x{${'\177'}}y";
+"x{$o->{'\177'}}y";
+"$a\177";
+C::\200;
+$\377;
+$o->a\200;
+"{$a}\200";

Zend/tests/assert/expect_015.phpt

@@ -0,0 +1,49 @@
+--TEST--
+AST export of variable and property names that are not valid labels
+--EXTENSIONS--
+zend_test
+--FILE--
+<?php
+
+$code = <<<'PHP'
+<?php
+${'a b'};
+${''};
+${'1a'};
+${"it's"};
+$o->{'a b'};
+$o?->{'a b'};
+$o->{'a b'}();
+$o?->{'a b'}();
+C::${'a b'};
+C::{'a b'}();
+"x{${'a b'}}y";
+"x{$o->{'a b'}}y";
+"x ${'a b'} y";
+"x${1}y";
+${'foo'};
+$o->{'foo'};
+PHP;
+
+$export = zend_test_compile_to_ast($code);
+echo $export;
+eval("return;\n$export");
+
+?>
+--EXPECT--
+${'a b'};
+${''};
+${'1a'};
+${'it\'s'};
+$o->{'a b'};
+$o?->{'a b'};
+$o->{'a b'}();
+$o?->{'a b'}();
+C::${'a b'};
+C::{'a b'}();
+"x{${'a b'}}y";
+"x{$o->{'a b'}}y";
+"x {${'a b'}} y";
+"x{${1}}y";
+$foo;
+$o->foo;

Zend/tests/ast/ast_export_del_in_names.phpt

@@ -1497,6 +1497,10 @@ static ZEND_COLD void zend_ast_export_encaps_list(smart_str *str, char quote, ze
 			zend_ast_export_qstr(str, quote, Z_STR_P(zv));
 		} else if (ast->kind == ZEND_AST_VAR &&
 		           ast->child[0]->kind == ZEND_AST_ZVAL &&
+		           Z_TYPE_P(zend_ast_get_zval(ast->child[0])) == IS_STRING &&
+		           zend_ast_valid_var_name(
+		               Z_STRVAL_P(zend_ast_get_zval(ast->child[0])),
+		               Z_STRLEN_P(zend_ast_get_zval(ast->child[0]))) &&
 		           (i + 1 == list->children ||
 		            list->child[i + 1]->kind != ZEND_AST_ZVAL ||
 		            !zend_ast_var_needs_braces(