diff --git a/.github/dependabot.yml b/.github/dependabot.yml index 013f5f7..d75dc0c 100644 --- a/.github/dependabot.yml +++ b/.github/dependabot.yml @@ -1,7 +1,7 @@ version: 2 updates: # One grouped PR a week for every action bump. Major bumps of release-chain - # actions are reviewed and merged by hand (CORE-TOP card CR-135), never + # actions are reviewed and merged by hand, never # auto-merged. - package-ecosystem: github-actions directory: / diff --git a/.github/workflows/facts-descriptions.yml b/.github/workflows/facts-descriptions.yml index 1a6a693..a18b268 100644 --- a/.github/workflows/facts-descriptions.yml +++ b/.github/workflows/facts-descriptions.yml @@ -32,7 +32,7 @@ jobs: descriptions: if: github.ref == 'refs/heads/main' environment: descriptions - # owner 10-21 (msg 1562390657274748981): pineforge-release runs on GitHub-hosted runners; R6/rule-B exception for this repo + # pineforge-release runs on GitHub-hosted runners; standing exception for this repository runs-on: ubuntu-latest env: FACTS_DESCRIPTIONS_APPLY_ENABLED: ${{ vars.FACTS_DESCRIPTIONS_APPLY_ENABLED }} diff --git a/.github/workflows/facts-fanout.yml b/.github/workflows/facts-fanout.yml index e6da3bc..17c13eb 100644 --- a/.github/workflows/facts-fanout.yml +++ b/.github/workflows/facts-fanout.yml @@ -27,7 +27,7 @@ jobs: web: if: github.ref == 'refs/heads/main' environment: release-automation - # owner 10-21 (msg 1562390657274748981): pineforge-release runs on GitHub-hosted runners; R6/rule-B exception for this repo + # pineforge-release runs on GitHub-hosted runners; standing exception for this repository runs-on: ubuntu-latest env: FACTS_WEB_DISPATCH_ENABLED: ${{ vars.FACTS_WEB_DISPATCH_ENABLED }} @@ -95,7 +95,7 @@ jobs: license: if: github.ref == 'refs/heads/main' environment: release-automation - # owner 10-21 (msg 1562390657274748981): pineforge-release runs on GitHub-hosted runners; R6/rule-B exception for this repo + # pineforge-release runs on GitHub-hosted runners; standing exception for this repository runs-on: ubuntu-latest env: FACTS_CONSUMER_ROLE: license diff --git a/.github/workflows/facts-validate.yml b/.github/workflows/facts-validate.yml index 366c2b7..76b3487 100644 --- a/.github/workflows/facts-validate.yml +++ b/.github/workflows/facts-validate.yml @@ -17,7 +17,7 @@ concurrency: jobs: authz: name: authz - # Standard GitHub-hosted label (owner #1050); never a larger-runner label. + # Standard GitHub-hosted label; never a larger-runner label. runs-on: ubuntu-24.04 permissions: {} # No timeout-minutes: the owner's no-time-limits rule (check-no-time-limits refuses new ones). @@ -33,7 +33,7 @@ jobs: WR_HEAD_REPO: ${{ github.event.workflow_run.head_repository.full_name }} WR_ACTOR: ${{ github.event.workflow_run.triggering_actor.login }} GH_TOKEN: ${{ github.token }} # read-only use: one permission lookup for workflow_run - # Bot logins whose same-repository pull requests count as ours: dependabot[bot] (CI-DEPBOT A) + # Bot logins whose same-repository pull requests count as ours: dependabot[bot] # and the org's own GitHub App bot logins by name (space-separated), nothing else. ALLOWED_BOTS: "dependabot[bot] pineforge-app[bot]" run: | @@ -45,7 +45,7 @@ jobs: # events; none of them runs pull-request code. ;; workflow_run) - # LB-437: bind identity to the triggering run and its re-runner. + # Bind identity to the triggering run and its re-runner. # These two App bots are fixed canon policy; ALLOWED_BOTS is PR-only. [ -n "${WR_HEAD_REPO:-}" ] || fail "workflow_run head repository is missing" [ -n "${WR_ACTOR:-}" ] || fail "workflow_run triggering actor is missing" diff --git a/.github/workflows/handle-upstream.yml b/.github/workflows/handle-upstream.yml index 49e8764..94a4ed9 100644 --- a/.github/workflows/handle-upstream.yml +++ b/.github/workflows/handle-upstream.yml @@ -33,7 +33,7 @@ permissions: jobs: bump: - # owner 10-21 (msg 1562390657274748981): pineforge-release runs on GitHub-hosted runners; R6/rule-B exception for this repo + # pineforge-release runs on GitHub-hosted runners; standing exception for this repository runs-on: ubuntu-latest environment: release-automation steps: diff --git a/.github/workflows/publish.yml b/.github/workflows/publish.yml index 9aec389..9ba40ba 100644 --- a/.github/workflows/publish.yml +++ b/.github/workflows/publish.yml @@ -34,7 +34,7 @@ concurrency: jobs: tag-guard: - # owner 10-21 (msg 1562390657274748981): pineforge-release runs on GitHub-hosted runners; R6/rule-B exception for this repo + # pineforge-release runs on GitHub-hosted runners; standing exception for this repository runs-on: ubuntu-latest permissions: contents: read @@ -42,7 +42,7 @@ jobs: sha: ${{ steps.tag.outputs.sha }} tag: ${{ steps.tag.outputs.tag }} steps: - - name: Stop automatic apt upgrades (LB-504, until the release image is rebaked) + - name: Stop automatic apt upgrades (until the release image is rebaked) shell: bash run: | systemctl show -p ActiveState,SubState apt-daily-upgrade.service apt-daily.service || true @@ -84,7 +84,7 @@ jobs: prepare: needs: tag-guard if: github.ref == 'refs/heads/main' - # owner 10-21 (msg 1562390657274748981): pineforge-release runs on GitHub-hosted runners; R6/rule-B exception for this repo + # pineforge-release runs on GitHub-hosted runners; standing exception for this repository runs-on: ubuntu-latest env: PF_CI_LABELS: '["self-hosted","pf-ci","pf-ci-x64"]' @@ -94,7 +94,7 @@ jobs: exists: ${{ steps.candidate.outputs.exists }} tag: ${{ needs.tag-guard.outputs.tag }} steps: - - name: Stop automatic apt upgrades (LB-504, until the release image is rebaked) + - name: Stop automatic apt upgrades (until the release image is rebaked) shell: bash run: | systemctl show -p ActiveState,SubState apt-daily-upgrade.service apt-daily.service || true @@ -114,7 +114,7 @@ jobs: publish: needs: [tag-guard, prepare] if: needs.prepare.outputs.exists == 'false' - # owner 10-21 (msg 1562390657274748981): pineforge-release runs on GitHub-hosted runners; R6/rule-B exception for this repo + # pineforge-release runs on GitHub-hosted runners; standing exception for this repository runs-on: ubuntu-latest environment: release-automation env: @@ -125,7 +125,7 @@ jobs: outputs: prerelease: ${{ steps.pair.outputs.prerelease }} steps: - - name: Stop automatic apt upgrades (LB-504, until the release image is rebaked) + - name: Stop automatic apt upgrades (until the release image is rebaked) shell: bash run: | systemctl show -p ActiveState,SubState apt-daily-upgrade.service apt-daily.service || true @@ -694,7 +694,7 @@ jobs: failure-report: needs: [tag-guard, prepare, publish, notify-consumers] if: ${{ always() && !cancelled() && (needs.tag-guard.result != 'success' || contains(needs.*.result, 'failure')) }} - # owner 10-21 (msg 1562390657274748981): pineforge-release runs on GitHub-hosted runners; R6/rule-B exception for this repo + # pineforge-release runs on GitHub-hosted runners; standing exception for this repository runs-on: ubuntu-latest env: PF_CI_LABELS: '["self-hosted","pf-ci","pf-ci-x64"]' @@ -702,7 +702,7 @@ jobs: contents: read issues: write steps: - - name: Stop automatic apt upgrades (LB-504, until the release image is rebaked) + - name: Stop automatic apt upgrades (until the release image is rebaked) shell: bash run: | systemctl show -p ActiveState,SubState apt-daily-upgrade.service apt-daily.service || true diff --git a/.github/workflows/python-test.yml b/.github/workflows/python-test.yml index 36840db..587c89e 100644 --- a/.github/workflows/python-test.yml +++ b/.github/workflows/python-test.yml @@ -8,7 +8,7 @@ on: push: branches: [main, master] pull_request: - # LB-387: ready_for_review starts the suites skipped on draft PRs. + # ready_for_review starts the suites skipped on draft PRs. types: [opened, synchronize, reopened, ready_for_review] merge_group: @@ -23,7 +23,7 @@ concurrency: jobs: authz: name: authz - # Standard GitHub-hosted label (owner #1050); never a larger-runner label. + # Standard GitHub-hosted label; never a larger-runner label. runs-on: ubuntu-24.04 permissions: {} # No timeout-minutes: the owner's no-time-limits rule (check-no-time-limits refuses new ones). @@ -39,7 +39,7 @@ jobs: WR_HEAD_REPO: ${{ github.event.workflow_run.head_repository.full_name }} WR_ACTOR: ${{ github.event.workflow_run.triggering_actor.login }} GH_TOKEN: ${{ github.token }} # read-only use: one permission lookup for workflow_run - # Bot logins whose same-repository pull requests count as ours: dependabot[bot] (CI-DEPBOT A) + # Bot logins whose same-repository pull requests count as ours: dependabot[bot] # and the org's own GitHub App bot logins by name (space-separated), nothing else. ALLOWED_BOTS: "dependabot[bot] pineforge-app[bot]" run: | @@ -51,7 +51,7 @@ jobs: # events; none of them runs pull-request code. ;; workflow_run) - # LB-437: bind identity to the triggering run and its re-runner. + # Bind identity to the triggering run and its re-runner. # These two App bots are fixed canon policy; ALLOWED_BOTS is PR-only. [ -n "${WR_HEAD_REPO:-}" ] || fail "workflow_run head repository is missing" [ -n "${WR_ACTOR:-}" ] || fail "workflow_run triggering actor is missing" diff --git a/.github/workflows/release-finalize.yml b/.github/workflows/release-finalize.yml index 98e09e5..77b0395 100644 --- a/.github/workflows/release-finalize.yml +++ b/.github/workflows/release-finalize.yml @@ -28,7 +28,7 @@ jobs: concurrency: group: release-finalize cancel-in-progress: false - # owner 10-21 (msg 1562390657274748981): pineforge-release runs on GitHub-hosted runners; R6/rule-B exception for this repo + # pineforge-release runs on GitHub-hosted runners; standing exception for this repository runs-on: ubuntu-latest environment: release-automation permissions: @@ -39,7 +39,7 @@ jobs: deliveries: ${{ steps.delivery-output.outputs.deliveries }} compute_configuration_error: ${{ steps.ready.outputs.compute_configuration_error }} steps: - - name: Stop automatic apt upgrades (LB-504, until the release image is rebaked) + - name: Stop automatic apt upgrades (until the release image is rebaked) shell: bash run: | systemctl show -p ActiveState,SubState apt-daily-upgrade.service apt-daily.service || true @@ -118,7 +118,7 @@ jobs: notify-consumers: needs: finalize if: ${{ needs.finalize.result == 'success' && needs.finalize.outputs.deliveries != '[]' }} - # owner 10-21 (msg 1562390657274748981): pineforge-release runs on GitHub-hosted runners; R6/rule-B exception for this repo + # pineforge-release runs on GitHub-hosted runners; standing exception for this repository runs-on: ubuntu-latest environment: release-automation concurrency: @@ -135,7 +135,7 @@ jobs: # Private targets never enter matrix outputs, log messages or public receipts. TARGET_REPOSITORY: ${{ matrix.consumer == 'offline' && 'pineforge-backtest-mcp' || matrix.consumer == 'hosted' && secrets.RELEASE_HOSTED_MCP_REPOSITORY || matrix.consumer == 'application' && secrets.RELEASE_APPLICATION_REPOSITORY || matrix.consumer == 'web' && secrets.FACTS_WEB_REPOSITORY || matrix.consumer == 'data' && 'pineforge-data' || matrix.consumer == 'license' && 'pineforge-license' || matrix.consumer == 'compute' && secrets.RELEASE_COMPUTE_REPOSITORY || '' }} steps: - - name: Stop automatic apt upgrades (LB-504, until the release image is rebaked) + - name: Stop automatic apt upgrades (until the release image is rebaked) shell: bash run: | systemctl show -p ActiveState,SubState apt-daily-upgrade.service apt-daily.service || true diff --git a/.github/workflows/release-receipts.yml b/.github/workflows/release-receipts.yml index b3c69ec..f724fc9 100644 --- a/.github/workflows/release-receipts.yml +++ b/.github/workflows/release-receipts.yml @@ -16,7 +16,7 @@ concurrency: jobs: plan: - # owner 10-21 (msg 1562390657274748981): pineforge-release runs on GitHub-hosted runners; R6/rule-B exception for this repo + # pineforge-release runs on GitHub-hosted runners; standing exception for this repository runs-on: ubuntu-latest env: PF_CI_LABELS: '["self-hosted","pf-ci","pf-ci-x64"]' @@ -45,7 +45,7 @@ jobs: verify: needs: plan if: needs.plan.outputs.consumers != '[]' - # owner 10-21 (msg 1562390657274748981): pineforge-release runs on GitHub-hosted runners; R6/rule-B exception for this repo + # pineforge-release runs on GitHub-hosted runners; standing exception for this repository runs-on: ubuntu-latest environment: release-automation permissions: diff --git a/.github/workflows/release-reconcile.yml b/.github/workflows/release-reconcile.yml index 8f7dc1a..e015dcc 100644 --- a/.github/workflows/release-reconcile.yml +++ b/.github/workflows/release-reconcile.yml @@ -15,7 +15,7 @@ concurrency: jobs: producers: - # owner 10-21 (msg 1562390657274748981): pineforge-release runs on GitHub-hosted runners; R6/rule-B exception for this repo + # pineforge-release runs on GitHub-hosted runners; standing exception for this repository runs-on: ubuntu-latest environment: release-automation steps: diff --git a/.github/workflows/release-redeliver.yml b/.github/workflows/release-redeliver.yml index deee5da..1c2ac1e 100644 --- a/.github/workflows/release-redeliver.yml +++ b/.github/workflows/release-redeliver.yml @@ -26,7 +26,7 @@ permissions: jobs: redeliver: if: github.ref == 'refs/heads/main' - # owner 10-21 (msg 1562390657274748981): pineforge-release runs on GitHub-hosted runners; R6/rule-B exception for this repo + # pineforge-release runs on GitHub-hosted runners; standing exception for this repository runs-on: ubuntu-latest environment: release-automation # Share the normal delivery lock; two repairs cannot reuse an audit number. @@ -37,7 +37,7 @@ jobs: contents: write # append one neutral redelivery audit asset in this hub issues: write steps: - - name: Stop automatic apt upgrades (LB-504, until the release image is rebaked) + - name: Stop automatic apt upgrades (until the release image is rebaked) shell: bash run: | systemctl show -p ActiveState,SubState apt-daily-upgrade.service apt-daily.service || true diff --git a/.github/workflows/release-rollback.yml b/.github/workflows/release-rollback.yml index 76ed256..59cb523 100644 --- a/.github/workflows/release-rollback.yml +++ b/.github/workflows/release-rollback.yml @@ -21,7 +21,7 @@ concurrency: jobs: restore: - # owner 10-21 (msg 1562390657274748981): pineforge-release runs on GitHub-hosted runners; R6/rule-B exception for this repo + # pineforge-release runs on GitHub-hosted runners; standing exception for this repository runs-on: ubuntu-latest environment: release-automation steps: diff --git a/README.md b/README.md index 93f50cf..52744f1 100644 --- a/README.md +++ b/README.md @@ -197,7 +197,7 @@ Pushing a tag alone does not start publication. The release, facts-automation and PR-CI jobs use GitHub-hosted runners. The `authz` jobs use `runs-on: ubuntu-24.04`; the other jobs use `runs-on: ubuntu-latest`, including candidate preparation, receipt planning and failure reporting, with these CI runner assignments: `python-test.yml` jobs `changes`, `fingerprint-canonical`, `description-renderer`, `release-ready-replay` and `release-ready` use `runs-on: ubuntu-24.04` for every configured event, including pushes to `main` and `master`. `facts-validate.yml` job `validate` uses `runs-on: ubuntu-24.04` for pull requests and pushes to `main`. -Those other jobs have the standing R6/rule-B exception (owner decision 10-21, msg 1562390657274748981). +Those other jobs use `ubuntu-latest` as a standing exception for this repository. The [release runner policy](docs/release-chain.md#release-runner-isolation) lists the jobs and the class boundary. @@ -205,7 +205,7 @@ The rules live in `scripts/release_pair.py` (unit-tested in `tests/`). `tools/release-dry-run/` replays the current handler and readiness graph offline, including all three-component arrival orders, duplicate/lost delivery, missing prerequisites and negative controls. Run in CI or on the approved cloud host, -never on the Mac: +never on a laptop: ``` python3 -m unittest discover -s tests -p 'test_release_*.py' # the release rules diff --git a/docs/release-chain.md b/docs/release-chain.md index 31bcc8f..de5d6ac 100644 --- a/docs/release-chain.md +++ b/docs/release-chain.md @@ -8,8 +8,8 @@ or deploy consumers. ## Release runner isolation -Owner decision 10-21 (msg 1562390657274748981) sets these release and facts-automation -jobs to the literal `runs-on: ubuntu-latest`, a standing R6/rule-B exception +These release and facts-automation +jobs use the literal `runs-on: ubuntu-latest`, a standing exception for pineforge-release: | Workflow | Jobs | @@ -34,7 +34,7 @@ with Contents or Issues write access. The `publish.yml` reusable `pull_request` and `pull_request_target` workflows must never use this class. The PR jobs in `python-test.yml` and `facts-validate.yml` also use GitHub-hosted runners. Their `authz` jobs use `runs-on: ubuntu-24.04`; the other PR jobs use -`runs-on: ubuntu-latest` per the owner decision, with these CI runner assignments: +`runs-on: ubuntu-latest` by the same standing exception, with these CI runner assignments: `python-test.yml` jobs `changes`, `fingerprint-canonical`, `description-renderer`, `release-ready-replay` and `release-ready` use `runs-on: ubuntu-24.04` for every configured event, including pushes to `main` and `master`. @@ -475,7 +475,7 @@ malformed entry streams are invalid evidence. ## Consumer receipt contract v1 -This is the single consumer-to-hub contract for the six receipt lanes; +This is the single consumer-to-hub contract for the six receipt roles; delivery-only compute is excluded. Implement the artifact and callback in the consumer's trusted default-branch coordinator. No Python knowledge is required. The hub validates both complete examples below @@ -1252,7 +1252,7 @@ with a longer app default. Monitor these assets/issues, not green dispatch runs. ## Supervisor configuration -Do not enable a receipt role until its consumer lane has removed moving runtime +Do not enable a receipt role until its consumer has removed moving runtime defaults and installed PR/CI/E2E/deploy gates; the same holds for every role. Compute instead waits for its merged pair-validation receiver and explicit first-pair gate. Consumer App identities must not bypass @@ -1263,8 +1263,8 @@ suite inventory; only a verified documentation-only PR may skip suites. The hub's `python-test.yml` and `facts-validate.yml` PR checks use GitHub-hosted runners: `authz` uses `runs-on: ubuntu-24.04`; the other PR jobs use -`runs-on: ubuntu-latest` per owner decision 10-21 (msg 1562390657274748981), -a standing R6/rule-B exception for pineforge-release, without a `PF_CI_LABELS` +`runs-on: ubuntu-latest`, +a standing exception for pineforge-release, without a `PF_CI_LABELS` environment variable, with these CI runner assignments: `python-test.yml` jobs `changes`, `fingerprint-canonical`, `description-renderer`, `release-ready-replay` and `release-ready` use `runs-on: ubuntu-24.04` for every @@ -1347,7 +1347,7 @@ A member's own fork fails the canonical authz check. The existing `merge_group` trigger remains configured and passes the canonical authz script. macOS stays hosted (no hardware); this repository has no macOS jobs. Credential/release jobs -use `ubuntu-latest` per owner decision 10-21, including publication workflows. +use `ubuntu-latest` by the same standing exception, including publication workflows. | Name / setting | Scope | Purpose | |---|---|---| @@ -1470,7 +1470,7 @@ names. Do not use the example E2E/deploy inventories as production gates. ``` Supervisor must populate the **actual complete expected job names**, including -matrix expansions, from each reviewed consumer lane. A tiny example inventory +matrix expansions, from each reviewed consumer. A tiny example inventory must never be used to omit existing required checks. Rollout order for the application `post_merge` section: a receipt must carry @@ -1565,7 +1565,7 @@ readback. Newer aliases are left alone. Fixed tags, images, source assets and manifests are preserved. If no previous good alias exists, it reports incomplete repair rather than deleting an alias or inventing a good target. **A hub rollback sends no consumer signal.** Consumers may keep the rejected release while hub -aliases revert, so mixed versions are possible. Each consumer lane owns its +aliases revert, so mixed versions are possible. Each consumer owns its explicit rollback and served-state verification; coordinate those rollbacks separately. @@ -1576,11 +1576,11 @@ truthful hosted receipts and red cases for source trust, binding and candidate replacement, archive digests, PR/head/base/attempt mismatches and inventory changes, plus regressions for the original exact-SHA path. The existing `test_release_*.py` discovery includes it in CI. These tests are written for -CI/cloud execution and are not run on the Mac; local validation is limited to +CI/cloud execution and are not run on a laptop; local validation is limited to Python compilation and `git diff --check` (plus YAML parsing if a workflow changes). No test suite, Docker runtime/build, live dispatch, publication, token mint, -credential read or deployment is needed on the Mac to implement this lane. +credential read or deployment is needed on a laptop to implement this change. ## Running the image: scratch space (engine 1.7.0) diff --git a/facts/README.md b/facts/README.md index 0d41da1..134a8d7 100644 --- a/facts/README.md +++ b/facts/README.md @@ -198,16 +198,16 @@ into a permission-unavailable success. Missing setup reports without displaying secret values. Read-only comparisons use `github.token`; there is no fallback to the release App. -## TOP setup and migration checklist +## Release-owner setup and migration checklist -TOP alone provisions settings/secrets and enables application after independent +The release owner alone provisions settings/secrets and enables application after independent review and reviewed dry-run proof. Provisioning has been reported for the new descriptions App/environment; the executor does not inspect secrets or mint live tokens to verify it. Live environment/App proof, including the authorized -four-repository descriptions scope, remains pending. TOP reports that the old +four-repository descriptions scope, remains pending. The release owner reports that the old org App is Contents-only and that `release-automation` exists with target secrets. -TOP reports that the new App key is provisioned in `release-automation` and that -this release repository's private-key fallback has been removed. This is a TOP +The release owner reports that the new App key is provisioned in `release-automation` and that +this release repository's private-key fallback has been removed. This is a release-owner setup receipt, not an executor secret inspection. The first protected release's no-fallback proof remains separate; engine/codegen environment moves follow their own rollout. Never inspect or hash secret values to establish origin. @@ -224,7 +224,7 @@ their own rollout. Never inspect or hash secret values to establish origin. absent environment value can expose an inherited `true`. PRs have no App access. Dispatch with `dry_run=true` and review the immutable source receipt and every delta. This comparison does not mint a - token. A live App mint/apply proof needs TOP's separate authorization. + token. A live App mint/apply proof needs the release owner's separate authorization. 3. Configure `release-automation` with selected deployment **branch `main` and tag pattern `v*` only**. Confirm the new `PINEFORGE_APP_ID` and `PINEFORGE_APP_PRIVATE_KEY` are provisioned there, together with @@ -235,11 +235,11 @@ their own rollout. Never inspect or hash secret values to establish origin. rather than falling back to all repositories. Never put nonpublic identities in public YAML, artifacts or logs. 4. Verify the next protected release without the repository-level App-key - fallback, which TOP reports removed. A no-op mint does not prove the bump push or consumer mapping; + fallback, which the release owner reports removed. A no-op mint does not prove the bump push or consumer mapping; those need their applicable release proof. Tokens request Contents: write on only the job's repository, never Administration. Other repositories' key moves are separate work; scoped inputs alone do not remove inherited credentials. -5. After reviewed dry-run and separately authorized live proof, TOP may set +5. After reviewed dry-run and separately authorized live proof, the release owner may set `FACTS_DESCRIPTIONS_APPLY_ENABLED=true` in `descriptions`. Writes additionally require protected `refs/heads/main`, an authorized push/manual/schedule event, and effective `dry_run=false`. With rollout enabled, push/schedule reconcile @@ -249,7 +249,7 @@ their own rollout. Never inspect or hash secret values to establish origin. workflow's effective value is `false`. Do not delete the environment value: that can expose an inherited `true`. Keep the retired drift job retired. -These are TOP operator commands, not steps executed by the implementation lane. +These are release-owner operator commands, not steps executed by the implementation. Use the approved GitHub wrapper where one is required: ```sh @@ -290,7 +290,7 @@ GH_HOST=github.com gh api --hostname github.com 'repos/pineforge-4pass/pineforge ``` The executor handoff includes the exact bounded-time heartbeat command and its -failure/staleness handling for TOP. Full source-versus-served digest monitoring +failure/staleness handling for the release owner. Full source-versus-served digest monitoring with a **30-minute facts-change freshness threshold is pending stage 2**. The stage-1 run monitor is not served-state proof and unrelated main commits must not reset that future freshness clock. @@ -369,7 +369,7 @@ credential presence only and does not inspect or hash their values. Manual `dry_run` defaults to `true` and an explicitly requested `false` survives workflow expression evaluation. With the dispatch gate off, either value only -plans. Once TOP separately enables dispatch, either requested boolean is sent: +plans. Once the release owner separately enables dispatch, either requested boolean is sent: `true` asks the receiver to validate without publishing. Enabled push/schedule runs send `false`; disabled automatic runs plan with `true`. The receiver must have its own protected publication gate. The hub's enable flag grants no receiver @@ -394,7 +394,7 @@ receipt has `alert=true` even while rollout is deliberately off. All receipts keep `installed=false`. Missing receipts and failed uploads are missing telemetry, never a successful consumer health check. -TOP's read-only workflow heartbeat uses the approved `ghq` wrapper on `PATH` and +The release owner's read-only workflow heartbeat uses the approved `ghq` wrapper on `PATH` and requires an explicit path to the reviewed checkout. It bounds the GitHub query to 45 seconds and 2 MiB of stdout, and the status parser to 10 seconds and 32 KiB of stdout. Each budget starts before its command is created and covers @@ -791,12 +791,12 @@ returns a neutral JSON receipt. It alerts (exit 1) for absent/completed telemetr older than 30 minutes, a failed completed run in that window, or a noncompleted run older than 15 minutes. Malformed input exits 2. Exit 0 is `workflow-observed`, with `served_freshness=unverified`, not installation proof. This heartbeat checks -workflow runs; TOP must also read each neutral artifact, including setup alerts. +workflow runs; the release owner must also read each neutral artifact, including setup alerts. It cannot replace the receiver's source-versus-served digest check. That required 30-minute freshness clock starts at the facts-byte change, not an unrelated main commit, workflow creation time or a retry. -## TOP Stage 2 rollout checklist (leave dispatch off) +## Release-owner Stage 2 rollout checklist (leave dispatch off) 1. Land the reviewed receiver first. Confirm it accepts `facts-update`, validates exactly the three payload fields and authoritative current source, and gates @@ -815,7 +815,7 @@ commit, workflow creation time or a retry. `false`; an absent environment value can expose an inherited `true`. Inspect the disabled manual plan, immutable source, setup receipt and artifact before enabling anything. Do not restore the removed repository-level key fallback. -4. Follow TOP's separately authorized receiver rehearsal on the fixed throwaway +4. Follow the release owner's separately authorized receiver rehearsal on the fixed throwaway branch, preserving its source/receipt proof and exact Spot build. Branch-only proof is not deployment proof. Enable hub dispatch only after the receiver and its independent rollout controls are ready. For enabled manual @@ -828,7 +828,7 @@ commit, workflow creation time or a retry. GitHub check bound to its exact committed SHA, then independently verify served provenance and canonical bytes/digest. Surface deployment races and missing telemetry instead of attributing success to the wrong commit. -6. TOP's first authorized real main run must close source-versus-served proof +6. The release owner's first authorized real main run must close source-versus-served proof within 30 minutes of the facts-byte change. Confirm welcome-template runtime override/readback in the consumer rollout. Keep release no-key-fallback proof separate. To stop future hub minting/dispatch, set @@ -853,5 +853,5 @@ parser, validator, workflow shell and dispatch helper. Only external GitHub responses and token-action outcomes are simulated. Tests capture exact POST bytes, exercise disabled/missing setup, strict payloads and targets, source movement, repeated signals, failures/redaction, independent workflow wiring and -missing/stale telemetry. The implementation lane performs no live mint, dispatch, +missing/stale telemetry. The implementation performs no live mint, dispatch, consumer publication or deployment. diff --git a/scripts/repo_descriptions.py b/scripts/repo_descriptions.py index b33f145..c204b31 100644 --- a/scripts/repo_descriptions.py +++ b/scripts/repo_descriptions.py @@ -238,7 +238,7 @@ def main(argv=None): document = render(arguments.facts, arguments.policy) exit_code = check_live(document, arguments.gh) if arguments.command == "check" else 0 if arguments.command == "render" and arguments.format == "commands": - lines = ["# TOP review only; this program never applies descriptions.", + lines = ["# Review only; this program never applies descriptions.", "# facts_sha256=" + document["facts_sha256"], "# policy_sha256=" + document["policy_sha256"]] for row in document["repositories"]: diff --git a/tests/test_release_hpo_image.py b/tests/test_release_hpo_image.py index 372bf86..27db249 100644 --- a/tests/test_release_hpo_image.py +++ b/tests/test_release_hpo_image.py @@ -1334,7 +1334,7 @@ class PinnedLicenceDigestsTest(unittest.TestCase): PINNED = { "pineforge-hpo/LICENSE": "1aa95beed7fc0b368872fcd1bcf6a09a0f67ef3014b5e48ae21404cb647a1136", - # hpo 1.7.0 NOTICE: approved by L6 on 10-25 under the owner's HUB170-TAG = A; + # hpo 1.7.0 NOTICE: approved on 10-25; # the only change vs 1.6.3 is the bundled reader's path # (src/cli/json.hpp -> src/core/json.hpp). "pineforge-hpo/NOTICE": "fb088c51cdd2b82f2ee6488730de8334310796f124046df9679dc1e96f744d1b", diff --git a/tests/test_release_redeliver.py b/tests/test_release_redeliver.py index 3cd7936..527340c 100644 --- a/tests/test_release_redeliver.py +++ b/tests/test_release_redeliver.py @@ -1,5 +1,5 @@ #!/usr/bin/env python3 -"""Manual redelivery regressions; execute in CI, never on the operator's Mac. +"""Manual redelivery regressions; execute in CI, never on a laptop. The existing store fake keys every asset by release and exact name. Only HTTP transport is replaced: production code still serializes the real wire bytes. diff --git a/tests/test_release_workflows.py b/tests/test_release_workflows.py index a1e3236..d1277b9 100644 --- a/tests/test_release_workflows.py +++ b/tests/test_release_workflows.py @@ -278,7 +278,7 @@ class ReleaseTriggerWorkflowTest(unittest.TestCase): ), } APT_GUARD_STEP = { - "name": "Stop automatic apt upgrades (LB-504, until the release image is rebaked)", + "name": "Stop automatic apt upgrades (until the release image is rebaked)", "shell": "bash", "run": ("systemctl show -p ActiveState,SubState apt-daily-upgrade.service apt-daily.service || true\n" "if systemctl is-active --quiet apt-daily-upgrade.service || " @@ -354,7 +354,7 @@ def assert_publish(self, text): jobs = wf.get("jobs", {}) for identity in ("tag-guard", "prepare", "publish", "failure-report"): self.assertEqual((jobs.get(identity, {}).get("steps") or [{}])[0], self.APT_GUARD_STEP, - identity + " must stop the apt timers before anything else (LB-504)") + identity + " must stop the apt timers before anything else") for identity in ("tag-guard", "prepare", "publish", "notify-consumers", "failure-report"): self.assertIn(identity, jobs) self.assertEqual(next(iter(jobs)), "tag-guard") @@ -382,7 +382,7 @@ def assert_publish(self, text): "run": self.VALIDATE_RUN, }, "validate before any tagged checkout, secret, or repository code") for identity, job in jobs.items(): - # owner 10-21 (msg 1562390657274748981): pineforge-release runs on GitHub-hosted runners; R6/rule-B exception for this repo + # pineforge-release runs on GitHub-hosted runners; standing exception for this repository if identity != "notify-consumers": self.assertEqual(job.get("runs-on"), "ubuntu-latest", identity) if identity != "tag-guard": @@ -726,10 +726,10 @@ def test_publish_refuses_bad_triggers_and_each_broken_input_boundary_on_real_tex (" persist-credentials: false\n", " persist-credentials: true\n", 4), (" fetch-depth: 0\n", " fetch-depth: 1\n", 2), (" ref: main\n", " ref: ${{ inputs.tag }}\n", 2), - # 2 tag consumers + the 4 apt guards (LB-504); every removal must still break a pin + # 2 tag consumers + the 4 apt guards; every removal must still break a pin (" shell: bash\n", "", 6), (" if: needs.tag-guard.result == 'success'\n", "", 2), - # owner 10-21 (msg 1562390657274748981): all four publish jobs must refuse the release array. + # All four publish jobs must refuse the release array. (" runs-on: ubuntu-latest\n", ' runs-on: ["self-hosted","pf-ci","pf-ci-release"]\n', 4), ): self.assertEqual(text.count(before), count, "each real tag consumer must be mutated") @@ -1042,7 +1042,7 @@ def assert_refusal(self, text): job = (wf.get("jobs") or {}).get("failure-report") or {} steps = job.get("steps") or [] self.assertGreater(len(steps), 1, "failure reporting must start with the apt guard and a refusal") - # LB-504: the apt guard is steps[0]; the refusal is the first real step after it, before any checkout. + # The apt guard is steps[0]; the refusal is the first real step after it, before any checkout. self.assertEqual(steps[0], ReleaseTriggerWorkflowTest.APT_GUARD_STEP, "the apt guard must be the first step") step = steps[1] self.assertEqual(step.get("name"), "Refuse unverified release tag", "the refusal must follow the apt guard") @@ -2878,16 +2878,16 @@ def test_no_workflow_uses_pf_ci_release_and_pin_refuses_each_reintroduction(self self.assert_no_release_runner_labels(mutant) def test_release_finalize_stops_the_apt_timers_before_anything_else(self): - # LB-504: apt-daily-upgrade.timer re-execs systemd 20-25 minutes after + # apt-daily-upgrade.timer re-execs systemd 20-25 minutes after # boot and kills the runner, and the finalizer runs hourly on - # ubuntu-latest (owner 10-21). Both of its jobs must stop the timers before any + # ubuntu-latest. Both of its jobs must stop the timers before any # checkout, secret or repository code. jobs = _workflow("release-finalize.yml")["jobs"] for identity in ("finalize", "notify-consumers"): with self.subTest(job=identity): self.assertEqual((jobs.get(identity, {}).get("steps") or [{}])[0], ReleaseTriggerWorkflowTest.APT_GUARD_STEP, - identity + " must stop the apt timers before anything else (LB-504)") + identity + " must stop the apt timers before anything else") def test_runner_pin_refuses_wrong_labels_other_pools_and_fallbacks_on_every_job(self): original = self.release_workflows() @@ -2954,7 +2954,7 @@ class PrTierWorkflowTest(unittest.TestCase): "facts-validate.yml": {"validate"}, } HOSTED_ONLY_RUNNERS = {"authz": "ubuntu-24.04", "release-rules": "ubuntu-latest"} - # owner 10-21 (msg 1562390657274748981): pineforge-release runs on GitHub-hosted runners; R6/rule-B exception for this repo + # pineforge-release runs on GitHub-hosted runners; standing exception for this repository HOSTED_JOBS = { ("python-test.yml", "authz"), ("python-test.yml", "changes"), @@ -2991,12 +2991,12 @@ class PrTierWorkflowTest(unittest.TestCase): "github.event.pull_request.head.repo.full_name == github.repository") AUTHZ_RUNNER_LINE = " runs-on: ubuntu-24.04" AUTHZ_POOL_RUNNER_LINE = ' runs-on: ["self-hosted", "pf-ci", "pf-ci-x64"]' - # Literal current ci-labels.md hosted authz (owner #1050, LB-437). + # Literal current ci-labels.md hosted authz. # Keep this independent of the workflows: every byte, including comments, # permissions and both permission lookups, is pinned. AUTHZ_TEXT = """ authz: name: authz - # Standard GitHub-hosted label (owner #1050); never a larger-runner label. + # Standard GitHub-hosted label; never a larger-runner label. runs-on: ubuntu-24.04 permissions: {} # No timeout-minutes: the owner's no-time-limits rule (check-no-time-limits refuses new ones). @@ -3012,7 +3012,7 @@ class PrTierWorkflowTest(unittest.TestCase): WR_HEAD_REPO: ${{ github.event.workflow_run.head_repository.full_name }} WR_ACTOR: ${{ github.event.workflow_run.triggering_actor.login }} GH_TOKEN: ${{ github.token }} # read-only use: one permission lookup for workflow_run - # Bot logins whose same-repository pull requests count as ours: dependabot[bot] (CI-DEPBOT A) + # Bot logins whose same-repository pull requests count as ours: dependabot[bot] # and the org's own GitHub App bot logins by name (space-separated), nothing else. ALLOWED_BOTS: "dependabot[bot] pineforge-app[bot]" run: | @@ -3024,7 +3024,7 @@ class PrTierWorkflowTest(unittest.TestCase): # events; none of them runs pull-request code. ;; workflow_run) - # LB-437: bind identity to the triggering run and its re-runner. + # Bind identity to the triggering run and its re-runner. # These two App bots are fixed canon policy; ALLOWED_BOTS is PR-only. [ -n "${WR_HEAD_REPO:-}" ] || fail "workflow_run head repository is missing" [ -n "${WR_ACTOR:-}" ] || fail "workflow_run triggering actor is missing" diff --git a/tools/release-dry-run/README.md b/tools/release-dry-run/README.md index beed94c..28bdf24 100644 --- a/tools/release-dry-run/README.md +++ b/tools/release-dry-run/README.md @@ -5,7 +5,7 @@ The default entry point now runs the candidate → finalizer → completion graph: ```bash -# Run in CI or on the approved cloud host, never on the Mac. +# Run in CI or on the approved cloud host, never on a laptop. python3 tools/release-dry-run/dry_run.py --ready -v python3 tools/release-dry-run/dry_run.py --ready -k ArrivalReplay ``` @@ -105,8 +105,8 @@ Requirements: bash 4.4 or later first on `PATH` (GitHub's runners have bash 5; macOS's `/bin/bash` 3.2 is refused), git 2.32 or later, jq, node 20 or later, and Python 3.9 or later with PyYAML. -For this campaign, every replay and regression check runs on an AWS Spot EC2 -host, never on the Mac or an on-demand instance. Use a lane-owned output and +In this project, every replay and regression check runs on an AWS Spot EC2 +host, never on a laptop or an on-demand instance. Use a separate output and cache directory; keep build/test transcripts internal. The commands below are run on that host, with no production credentials copied to it: