Skip to content

Click 8.4.0 breaks type checks #1218

Description

@tbarsballe

Expected behavior
Prior to May 17, type checks on the repo succeeded

Actual behavior (describe the problem)
After May 17, type checks failed, due to the new release of click 8.4.0, with the following errors:

planet/cli/types.py:27: error: Return type "list[str]" of "convert" incompatible with return type "str" in supertype "click.types.StringParamType"  [override]
planet/cli/types.py:27: error: Return type "list[str]" of "convert" incompatible with return type "str" in supertype "click.types.ParamType"  [override]
planet/cli/types.py:49: error: Return type "list[float]" of "convert" incompatible with return type "str" in supertype "click.types.StringParamType"  [override]
planet/cli/types.py:49: error: Return type "list[float]" of "convert" incompatible with return type "str" in supertype "click.types.ParamType"  [override]

Related Issues
First noticed in #1215

Workaround
Force click<=8.4.0

Environment Information
Observed in multiple environments: local (MacOS), CI.

Installation Method
From source

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions