From 6b0bd60f9beea4cedd2aebfd4ddf3326e3a7af96 Mon Sep 17 00:00:00 2001 From: Henry Schreiner Date: Thu, 19 Nov 2026 10:37:44 -0500 Subject: [PATCH] ci: use target_compile_definitions for smart holder test define CMake 4.5 warns on add_compile_definitions (non-target-directive), which -Werror=dev makes fatal. Assisted-by: ClaudeCode:claude-opus-5-5 --- tests/test_cmake_build/CMakeLists.txt | 5 ----- tests/test_with_catch/CMakeLists.txt | 13 ++++++++----- 2 files changed, 8 insertions(+), 10 deletions(-) diff --git a/tests/test_cmake_build/CMakeLists.txt b/tests/test_cmake_build/CMakeLists.txt index 21d92f8cf7..9e73f20067 100644 --- a/tests/test_cmake_build/CMakeLists.txt +++ b/tests/test_cmake_build/CMakeLists.txt @@ -60,11 +60,6 @@ function(pybind11_add_build_test name) add_dependencies(test_cmake_build test_build_${name}) endfunction() -if(PYBIND11_TEST_SMART_HOLDER) - add_compile_definitions( - -DPYBIND11_RUN_TESTING_WITH_SMART_HOLDER_AS_DEFAULT_BUT_NEVER_USE_IN_PRODUCTION_PLEASE) -endif() - possibly_uninitialized(PYTHON_MODULE_EXTENSION Python_INTERPRETER_ID) pybind11_add_build_test(subdirectory_function) diff --git a/tests/test_with_catch/CMakeLists.txt b/tests/test_with_catch/CMakeLists.txt index e6a9f67aa7..69cdd6fba2 100644 --- a/tests/test_with_catch/CMakeLists.txt +++ b/tests/test_with_catch/CMakeLists.txt @@ -28,11 +28,6 @@ endif() find_package(Threads REQUIRED) -if(PYBIND11_TEST_SMART_HOLDER) - add_compile_definitions( - -DPYBIND11_RUN_TESTING_WITH_SMART_HOLDER_AS_DEFAULT_BUT_NEVER_USE_IN_PRODUCTION_PLEASE) -endif() - add_executable(test_with_catch catch.cpp test_args_convert_vector.cpp test_argument_vector.cpp test_interpreter.cpp test_subinterpreter.cpp) pybind11_enable_warnings(test_with_catch) @@ -61,4 +56,12 @@ foreach(config ${CMAKE_CONFIGURATION_TYPES}) endforeach() add_dependencies(cpptest external_module) +if(PYBIND11_TEST_SMART_HOLDER) + foreach(target test_with_catch external_module) + target_compile_definitions( + ${target} + PRIVATE PYBIND11_RUN_TESTING_WITH_SMART_HOLDER_AS_DEFAULT_BUT_NEVER_USE_IN_PRODUCTION_PLEASE) + endforeach() +endif() + add_dependencies(check cpptest)