Bug report
Bug description:
Keyword-typo SyntaxError suggestions depend on whether CPython processes the same source using the file tokenizer or the string tokenizer.
Create t.py containing:
a=b=c=d=e=f=g=h=i=0
def fn():
retrun TrueRunning the file directly:
uses the file-tokenizer path and produces the helpful diagnostic:
File ".../t.py", line 3
retrun True
^^^^^^
SyntaxError: invalid syntax. Did you mean 'return'?
Running the same file as a module:
uses the string-tokenizer path and produces:
File ".../t.py", line 3
retrun True
^^^^
SyntaxError: invalid syntax
The same discrepancy is visible in the default PyREPL-based REPL.
Pasting the complete block as one input:
a=b=c=d=e=f=g=h=i=0
def fn():
retrun Trueproduces the generic error:
File "<python-input-0>", line 3
retrun True
^^^^
SyntaxError: invalid syntax
Entering and submitting the assignment separately, followed by the function:
produces:
File "<python-input-2>", line 2
retrun True
^^^^^^
SyntaxError: invalid syntax. Did you mean 'return'?
I would expect the same source code to produce the same keyword suggestion regardless of whether it is:
- executed as a file with
python t.py;
- loaded as a module with
python -m t;
- pasted into PyREPL as one block; or
- entered into PyREPL statement by statement.
This appears related to the keyword-typo suggestions added in #132449.
traceback.TracebackException._find_keyword_typos() treats the two source paths differently:
- When the source is loaded from the filename, tokens outside the reported error line are skipped before consuming the token-search budget.
- When the source is included directly in the
SyntaxError metadata, all non-keyword NAME tokens in the extracted source fragment consume that budget.
The search is limited to ten such tokens. In this example, a through i account for nine tokens and fn is the tenth, so the string-source path stops before examining retrun. The file-source path skips those earlier lines and finds the typo.
One possible approach would be to prioritize tokens on the reported error line for both source paths, and only then search the surrounding source fragment. That would preserve the existing work limit while avoiding this tokenizer-dependent result.
CPython versions tested on:
CPython main branch, 3.15, 3.14
Operating systems tested on:
macOS
Bug report
Bug description:
Keyword-typo
SyntaxErrorsuggestions depend on whether CPython processes the same source using the file tokenizer or the string tokenizer.Create
t.pycontaining:Running the file directly:
$ python t.pyuses the file-tokenizer path and produces the helpful diagnostic:
Running the same file as a module:
$ python -m tuses the string-tokenizer path and produces:
The same discrepancy is visible in the default PyREPL-based REPL.
Pasting the complete block as one input:
produces the generic error:
Entering and submitting the assignment separately, followed by the function:
produces:
I would expect the same source code to produce the same keyword suggestion regardless of whether it is:
python t.py;python -m t;This appears related to the keyword-typo suggestions added in #132449.
traceback.TracebackException._find_keyword_typos()treats the two source paths differently:SyntaxErrormetadata, all non-keywordNAMEtokens in the extracted source fragment consume that budget.The search is limited to ten such tokens. In this example,
athroughiaccount for nine tokens andfnis the tenth, so the string-source path stops before examiningretrun. The file-source path skips those earlier lines and finds the typo.One possible approach would be to prioritize tokens on the reported error line for both source paths, and only then search the surrounding source fragment. That would preserve the existing work limit while avoiding this tokenizer-dependent result.
CPython versions tested on:
CPython main branch, 3.15, 3.14
Operating systems tested on:
macOS