From bf4ed7d97577c545af640353b3ce61d2818f801f Mon Sep 17 00:00:00 2001 From: Jakub Piasecki Date: Wed, 19 Aug 2026 01:38:53 -0700 Subject: [PATCH] Cover `react/networking:networking` with Stable API guards Summary: Classifies `react/networking:networking` as a private target under the C++ stable API three-tier visibility model. Adds `#include ` to both of the module's exported headers (`NetworkReporter.h`, `NetworkTypes.h`), and wires the guard dependency into BUCK, CMake, and the podspec. The guards are inert unless a consumer defines `RN_STRICT_API`, so there is no behavior change. Changelog: [Internal] Differential Revision: D116591313 --- .../react-native/ReactCommon/react/networking/CMakeLists.txt | 1 + .../react-native/ReactCommon/react/networking/NetworkReporter.h | 2 ++ .../react-native/ReactCommon/react/networking/NetworkTypes.h | 2 ++ .../ReactCommon/react/networking/React-networking.podspec | 1 + 4 files changed, 6 insertions(+) diff --git a/packages/react-native/ReactCommon/react/networking/CMakeLists.txt b/packages/react-native/ReactCommon/react/networking/CMakeLists.txt index d3776fad9ee4..c3037cf5f78f 100644 --- a/packages/react-native/ReactCommon/react/networking/CMakeLists.txt +++ b/packages/react-native/ReactCommon/react/networking/CMakeLists.txt @@ -19,6 +19,7 @@ target_link_libraries(react_networking folly_runtime jsinspector_network jsinspector_tracing + react_cxxstableapi react_performance_timeline react_timing) diff --git a/packages/react-native/ReactCommon/react/networking/NetworkReporter.h b/packages/react-native/ReactCommon/react/networking/NetworkReporter.h index 841a592c1c6d..8543afd715ca 100644 --- a/packages/react-native/ReactCommon/react/networking/NetworkReporter.h +++ b/packages/react-native/ReactCommon/react/networking/NetworkReporter.h @@ -7,6 +7,8 @@ #pragma once +#include + #include "NetworkTypes.h" #include diff --git a/packages/react-native/ReactCommon/react/networking/NetworkTypes.h b/packages/react-native/ReactCommon/react/networking/NetworkTypes.h index d79256d017b0..65b27379dd0f 100644 --- a/packages/react-native/ReactCommon/react/networking/NetworkTypes.h +++ b/packages/react-native/ReactCommon/react/networking/NetworkTypes.h @@ -7,6 +7,8 @@ #pragma once +#include + #include #include #include diff --git a/packages/react-native/ReactCommon/react/networking/React-networking.podspec b/packages/react-native/ReactCommon/react/networking/React-networking.podspec index 2331d3c9ecaf..bb903c4e04dd 100644 --- a/packages/react-native/ReactCommon/react/networking/React-networking.podspec +++ b/packages/react-native/ReactCommon/react/networking/React-networking.podspec @@ -45,6 +45,7 @@ Pod::Spec.new do |s| add_dependency(s, "React-jsinspectortracing", :framework_name => 'jsinspector_moderntracing') s.dependency "React-performancetimeline" s.dependency "React-timing" + s.dependency "React-cxxstableapi" add_rn_third_party_dependencies(s) add_rncore_dependency(s)