From 45723c4fb080e7abdb3110aa44dd5eec6d0925d5 Mon Sep 17 00:00:00 2001 From: Ammaar Ahmed Date: Thu, 19 Nov 2026 09:17:49 +0500 Subject: [PATCH] Added node traits for regular & lifecycle nodes Signed-off-by: Ammaar Ahmed --- rclcpp/include/rclcpp/node_traits.hpp | 57 +++++++++++++++++++ rclcpp/test/rclcpp/test_interface_traits.cpp | 21 +++++++ rclcpp_lifecycle/test/test_lifecycle_node.cpp | 11 ++++ 3 files changed, 89 insertions(+) create mode 100644 rclcpp/include/rclcpp/node_traits.hpp diff --git a/rclcpp/include/rclcpp/node_traits.hpp b/rclcpp/include/rclcpp/node_traits.hpp new file mode 100644 index 0000000000..7e70444d54 --- /dev/null +++ b/rclcpp/include/rclcpp/node_traits.hpp @@ -0,0 +1,57 @@ +// Copyright 2026 Open Source Robotics Foundation, Inc. +// +// Licensed under the Apache License, Version 2.0 (the "License"); +// you may not use this file except in compliance with the License. +// You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, software +// distributed under the License is distributed on an "AS IS" BASIS, +// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +// See the License for the specific language governing permissions and +// limitations under the License. + +#ifndef RCLCPP__NODE_TRAITS_HPP_ +#define RCLCPP__NODE_TRAITS_HPP_ + +#include + +/** \file + * Compile-time checks for node class inheritance. + * + * Both traits ignore const, volatile, and references. Raw and smart pointers + * are checked as their own types. Private, protected, and ambiguous bases count. + * A non-union class argument must be complete unless it is the trait's base class. + */ + +namespace rclcpp_lifecycle +{ +class LifecycleNode; +} // namespace rclcpp_lifecycle + +namespace rclcpp +{ +class Node; + +/// True for rclcpp::Node and classes derived from it. +template +struct is_node : std::is_base_of> +{}; + +/// Convenience variable for is_node::value. +template +inline constexpr bool is_node_v = is_node::value; + +/// True for rclcpp_lifecycle::LifecycleNode and classes derived from it. +template +struct is_lifecycle_node : std::is_base_of> +{}; + +/// Convenience variable for is_lifecycle_node::value. +template +inline constexpr bool is_lifecycle_node_v = is_lifecycle_node::value; + +} // namespace rclcpp + +#endif // RCLCPP__NODE_TRAITS_HPP_ diff --git a/rclcpp/test/rclcpp/test_interface_traits.cpp b/rclcpp/test/rclcpp/test_interface_traits.cpp index bf079adb75..32f5fb4842 100644 --- a/rclcpp/test/rclcpp/test_interface_traits.cpp +++ b/rclcpp/test/rclcpp/test_interface_traits.cpp @@ -17,6 +17,8 @@ #include #include +#include "rclcpp/node_traits.hpp" + #include "rclcpp/contexts/default_context.hpp" #include "rclcpp/node_interfaces/node_base_interface_traits.hpp" #include "rclcpp/node_interfaces/node_base.hpp" @@ -46,6 +48,25 @@ class WrongNode } }; +namespace +{ +class DerivedNode : public rclcpp::Node +{}; +} // namespace + +TEST(TestNodeTraits, is_node) { + static_assert(rclcpp::is_node::value); + static_assert(rclcpp::is_node_v); + static_assert(rclcpp::is_node_v); + static_assert(!rclcpp::is_node_v); + static_assert(!rclcpp::is_node_v); + static_assert(!rclcpp::is_node_v); + static_assert(!rclcpp::is_node_v); + + // LifecycleNode remains forward-declared in this package. + static_assert(!rclcpp::is_lifecycle_node::value); +} + template::value >::type * = nullptr> diff --git a/rclcpp_lifecycle/test/test_lifecycle_node.cpp b/rclcpp_lifecycle/test/test_lifecycle_node.cpp index c69219d965..f2396870e5 100644 --- a/rclcpp_lifecycle/test/test_lifecycle_node.cpp +++ b/rclcpp_lifecycle/test/test_lifecycle_node.cpp @@ -37,6 +37,7 @@ #include "rclcpp/exceptions.hpp" #include "rclcpp/node.hpp" #include "rclcpp/node_options.hpp" +#include "rclcpp/node_traits.hpp" #include "rclcpp/parameter.hpp" #include "rclcpp/parameter_value.hpp" #include "rclcpp/utilities.hpp" @@ -152,6 +153,16 @@ class EmptyLifecycleNode : public rclcpp_lifecycle::LifecycleNode {} }; +TEST(TestNodeTraits, is_lifecycle_node) { + static_assert(rclcpp::is_lifecycle_node::value); + static_assert(rclcpp::is_lifecycle_node_v); + static_assert(rclcpp::is_lifecycle_node_v); + static_assert(!rclcpp::is_lifecycle_node_v); + static_assert(!rclcpp::is_lifecycle_node_v>); + static_assert(!rclcpp::is_lifecycle_node_v); + static_assert(!rclcpp::is_node_v); +} + struct GoodMood { using CallbackReturnT =