From 6ef96560119a617809ed17ced3a5045bbe470800 Mon Sep 17 00:00:00 2001 From: "Lahiff, Andrew" Date: Fri, 4 Sep 2026 12:15:03 +0100 Subject: [PATCH 1/3] Bug fix - need to return None if attributes/filters is None, not 'null' --- simvue/client.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/simvue/client.py b/simvue/client.py index a5633212..7e7a4cdd 100644 --- a/simvue/client.py +++ b/simvue/client.py @@ -279,8 +279,8 @@ def get_runs( _runs = Run.get( count=count_limit, offset=start_index, - attributes=json.dumps(attributes), - filters=json.dumps(filters), + attributes=json.dumps(attributes) if attributes is not None else None, + filters=json.dumps(filters) if filters is not None else None, return_basic=True, return_system=system_info, return_timing=timing_info, From cd0026174e420f74a43ab2b590f758ea74ecb82b Mon Sep 17 00:00:00 2001 From: "Lahiff, Andrew" Date: Fri, 4 Sep 2026 12:33:59 +0100 Subject: [PATCH 2/3] Update fake data to match stricter requirements imposed by the server --- tests/unit/test_s3_storage.py | 18 +++++++++--------- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/tests/unit/test_s3_storage.py b/tests/unit/test_s3_storage.py index ee957b31..59cd0a8a 100644 --- a/tests/unit/test_s3_storage.py +++ b/tests/unit/test_s3_storage.py @@ -18,11 +18,11 @@ def test_create_s3_online() -> None: disable_check=True, is_tenant_useable=False, is_default=False, - region_name="fictionsville", + region_name="eu-fiction-1", access_key_id="dummy_key", secret_access_key="not_a_key", ca_cert="invalid_ca_cert", - bucket="dummy_bucket", + bucket="dummy-bucket", is_enabled=False ) _storage.commit() @@ -34,8 +34,8 @@ def test_create_s3_online() -> None: assert _storage.to_dict() assert _storage.name == _uuid assert _storage.config.endpoint_url == "https://not-a-real-url.io/" - assert _storage.config.region_name == "fictionsville" - assert _storage.config.bucket == "dummy_bucket" + assert _storage.config.region_name == "eu-fiction-1" + assert _storage.config.bucket == "dummy-bucket" assert _storage.created assert dict(Storage.get()) _storage.delete() @@ -51,7 +51,7 @@ def test_create_s3_offline(offline_cache_setup) -> None: name=_uuid, endpoint_url="https://not-a-real-url.io", disable_check=True, - region_name="fictionsville", + region_name="eu-fiction-1", access_key_id="dummy_key", secret_access_key="not_a_key", bucket="dummy_bucket", @@ -65,8 +65,8 @@ def test_create_s3_offline(offline_cache_setup) -> None: _local_data = json.load(in_f) assert _local_data.get("name") == _uuid assert _local_data.get("config").get("endpoint_url") == "https://not-a-real-url.io/" - assert _local_data.get("config").get("region_name") == "fictionsville" - assert _local_data.get("config").get("bucket") == "dummy_bucket" + assert _local_data.get("config").get("region_name") == "eu-fiction-1" + assert _local_data.get("config").get("bucket") == "dummy-bucket" assert _local_data.get("is_enabled") == False assert not _local_data.get("status", None) assert not _local_data.get("user", None) @@ -82,8 +82,8 @@ def test_create_s3_offline(offline_cache_setup) -> None: assert _online_storage.name == _uuid assert _online_storage.is_enabled == False assert _online_storage.config.endpoint_url == "https://not-a-real-url.io/" - assert _online_storage.config.region_name == "fictionsville" - assert _online_storage.config.bucket == "dummy_bucket" + assert _online_storage.config.region_name == "eu-fiction-1" + assert _online_storage.config.bucket == "dummy-bucket" _online_storage.read_only(False) _online_storage.delete() From ecfb9a5800fcf90588ddb0c15626bf8460a30545 Mon Sep 17 00:00:00 2001 From: "Lahiff, Andrew" Date: Fri, 4 Sep 2026 12:48:28 +0100 Subject: [PATCH 3/3] Forgot to correct this instance of dummy_bucket --- tests/unit/test_s3_storage.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/unit/test_s3_storage.py b/tests/unit/test_s3_storage.py index 59cd0a8a..6a3413d9 100644 --- a/tests/unit/test_s3_storage.py +++ b/tests/unit/test_s3_storage.py @@ -54,7 +54,7 @@ def test_create_s3_offline(offline_cache_setup) -> None: region_name="eu-fiction-1", access_key_id="dummy_key", secret_access_key="not_a_key", - bucket="dummy_bucket", + bucket="dummy-bucket", is_default=False, is_tenant_useable=False, is_enabled=False,