chore: size the 0.156.0 release memory exception to the measured regressions (#1086)

Author: kvlonge

scripts/release_performance/constants.py

@@ -86,23 +86,23 @@
         name="lineage hub downstream",
         project=INSPECTION_PROJECT,
         sqb_args=("lineage", SHARED_DIAMOND_HUB, "--direction", "downstream"),
+        max_rss_ratio=1.75,
     ),
     BenchmarkCommand(
         name="lineage rollup upstream",
         project=INSPECTION_PROJECT,
         sqb_args=("lineage", SHARED_DIAMOND_ROLLUP, "--direction", "upstream"),
+        max_rss_ratio=1.75,
     ),
     BenchmarkCommand(
         name="lineage column trace",
         project=INSPECTION_PROJECT,
         sqb_args=("lineage", f"{SHARED_DIAMOND_ROLLUP}.amount", "--direction", "upstream"),
-        max_rss_ratio=2.0,
     ),
     BenchmarkCommand(
         name="dag --json",
         project=INSPECTION_PROJECT,
         sqb_args=("dag", "--json"),
-        max_rss_ratio=1.5,
     ),
     BenchmarkCommand(
         name="scope --json",
@@ -118,7 +118,6 @@
     ),
     BenchmarkCommand(
         name="compile (one-model edit)",
-        max_rss_ratio=1.35,
         project=INSPECTION_PROJECT,
         sqb_args=("compile", "--json"),
         edits_model=True,
@@ -128,6 +127,7 @@
         name="dense compile (warm cache)",
         project=DENSE_PROJECT,
         sqb_args=("compile", "--json"),
+        max_rss_ratio=1.45,
         max_time_ratio=MAX_COMPILE_TIME_RATIO,
     ),
     BenchmarkCommand(

tests/e2e/scripts/release_performance/test_compare_release_performance.py

@@ -39,9 +39,10 @@
                 "| `plan --json` |",
                 "| `build (empty warehouse)` |",
                 "| `lineage column trace` |",
-                "Peak RSS limit for `lineage column trace`: 2.00x "
-                "(+100%; temporary memory exception).",
-                "Peak RSS limit for `dag --json`: 1.50x (+50%; temporary memory exception).",
+                "Peak RSS limit for `lineage hub downstream`: 1.75x "
+                "(+75%; temporary memory exception).",
+                "Peak RSS limit for `dense compile (warm cache)`: 1.45x "
+                "(+45%; temporary memory exception).",
                 "Benchmark projects are generated per side",
                 "**Result: ",
             ),
@@ -121,9 +122,9 @@ def test_given_two_installations_when_comparing_release_performance_then_reports
     ]
     for command in recorded["commands"]:
         assert command["max_rss_ratio"] == {
-            "lineage column trace": 2.0,
-            "dag --json": 1.5,
-            "compile (one-model edit)": 1.35,
+            "lineage hub downstream": 1.75,
+            "lineage rollup upstream": 1.75,
+            "dense compile (warm cache)": 1.45,
         }.get(command["name"])
 
 

tests/unit/scripts/release_performance/_helpers/test_verdict.py

@@ -290,9 +290,9 @@ def test_given_configured_command_when_judging_time_then_its_own_limit_applies(
             description=f"{command.name} enforces its RSS allowance and time limits",
             command=command,
             expected_rss_ratio={
-                "lineage column trace": 2.0,
-                "dag --json": 1.5,
-                "compile (one-model edit)": 1.35,
+                "lineage hub downstream": 1.75,
+                "lineage rollup upstream": 1.75,
+                "dense compile (warm cache)": 1.45,
             }.get(command.name, 1.25),
         )
         for command in BENCHMARK_COMMANDS