Skip to content

Commit a688a67

Browse files
kvlongekvlonge
committed
test(native): count native SQL test planning and record baselines after the planning port
1 parent 86e97b6 commit a688a67

6 files changed

Lines changed: 389 additions & 41 deletions

File tree

‎scripts/compiler_differential/native_fallbacks.toml‎

Lines changed: 38 additions & 38 deletions
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@ engine = "native"
2525
stage = "attachments"
2626
site = "attachments.native"
2727
kind = "cursor_intrinsic_rejections"
28-
counts = { example = 160, failure = 164, fixture = 156, seed = 961 }
28+
counts = { example = 160, failure = 170, fixture = 156, seed = 961 }
2929

3030
[[entry]]
3131
engine = "native"
@@ -39,7 +39,7 @@ engine = "native"
3939
stage = "attachments"
4040
site = "attachments.native"
4141
kind = "omitted_select_scans"
42-
counts = { example = 24, failure = 18, fixture = 32, seed = 193 }
42+
counts = { example = 24, failure = 21, fixture = 32, seed = 193 }
4343

4444
[[entry]]
4545
engine = "native"
@@ -88,7 +88,7 @@ engine = "native"
8888
stage = "declaration_scopes"
8989
site = "declaration_scopes.native"
9090
kind = "scope_indexes"
91-
counts = { example = 12, failure = 221, fixture = 12, seed = 44 }
91+
counts = { example = 12, failure = 224, fixture = 12, seed = 44 }
9292

9393
[[entry]]
9494
engine = "native"
@@ -109,7 +109,7 @@ engine = "native"
109109
stage = "discovery"
110110
site = "discovery.native"
111111
kind = "model_file_listings"
112-
counts = { example = 12, failure = 286, fixture = 12, seed = 50 }
112+
counts = { example = 12, failure = 289, fixture = 12, seed = 50 }
113113

114114
[[entry]]
115115
engine = "native"
@@ -165,14 +165,14 @@ engine = "native"
165165
stage = "model_config"
166166
site = "model_config.native"
167167
kind = "config_builds"
168-
counts = { example = 56, failure = 298, fixture = 64, seed = 890 }
168+
counts = { example = 56, failure = 302, fixture = 64, seed = 890 }
169169

170170
[[entry]]
171171
engine = "native"
172172
stage = "model_config"
173173
site = "model_config.native"
174174
kind = "validations"
175-
counts = { example = 56, failure = 365, fixture = 60, seed = 1091 }
175+
counts = { example = 56, failure = 372, fixture = 60, seed = 1091 }
176176

177177
[[entry]]
178178
engine = "native"
@@ -186,21 +186,21 @@ engine = "native"
186186
stage = "model_config"
187187
site = "model_config.python_templates"
188188
kind = "config"
189-
counts = { example = 12, failure = 111, fixture = 8, seed = 36 }
189+
counts = { example = 12, failure = 114, fixture = 8, seed = 36 }
190190

191191
[[entry]]
192192
engine = "native"
193193
stage = "model_config"
194194
site = "model_config.python_templates"
195195
kind = "connection"
196-
counts = { example = 18, failure = 113, fixture = 9, seed = 63 }
196+
counts = { example = 18, failure = 116, fixture = 9, seed = 63 }
197197

198198
[[entry]]
199199
engine = "native"
200200
stage = "model_config"
201201
site = "model_config.python_templates"
202202
kind = "effective_vars"
203-
counts = { example = 29, failure = 236, fixture = 15, seed = 121 }
203+
counts = { example = 29, failure = 239, fixture = 15, seed = 121 }
204204

205205
[[entry]]
206206
engine = "native"
@@ -228,7 +228,7 @@ engine = "native"
228228
stage = "model_loop"
229229
site = "model_loop.cursor_intrinsic_validation"
230230
kind = "deferred"
231-
counts = { example = 56, failure = 395, fixture = 64, seed = 1100 }
231+
counts = { example = 56, failure = 402, fixture = 64, seed = 1100 }
232232

233233
[[entry]]
234234
engine = "native"
@@ -249,14 +249,14 @@ engine = "native"
249249
stage = "model_loop"
250250
site = "model_loop.native"
251251
kind = "declaration_expansions"
252-
counts = { example = 56, failure = 406, fixture = 64, seed = 1100 }
252+
counts = { example = 56, failure = 413, fixture = 64, seed = 1100 }
253253

254254
[[entry]]
255255
engine = "native"
256256
stage = "model_loop"
257257
site = "model_loop.native"
258258
kind = "variable_substitutions"
259-
counts = { example = 56, failure = 448, fixture = 72, seed = 1157 }
259+
counts = { example = 56, failure = 455, fixture = 72, seed = 1157 }
260260

261261
[[entry]]
262262
engine = "native"
@@ -277,7 +277,7 @@ engine = "native"
277277
stage = "reference_extraction"
278278
site = "reference_extraction.native"
279279
kind = "reference_scans"
280-
counts = { example = 250, failure = 448, fixture = 249, seed = 1523 }
280+
counts = { example = 250, failure = 463, fixture = 249, seed = 1523 }
281281

282282
[[entry]]
283283
engine = "native-preview"
@@ -298,7 +298,7 @@ engine = "native-preview"
298298
stage = "attachments"
299299
site = "attachments.native"
300300
kind = "cursor_intrinsic_rejections"
301-
counts = { example = 160, failure = 164, fixture = 156, seed = 961 }
301+
counts = { example = 160, failure = 170, fixture = 156, seed = 961 }
302302

303303
[[entry]]
304304
engine = "native-preview"
@@ -312,7 +312,7 @@ engine = "native-preview"
312312
stage = "attachments"
313313
site = "attachments.native"
314314
kind = "omitted_select_scans"
315-
counts = { example = 24, failure = 18, fixture = 32, seed = 193 }
315+
counts = { example = 24, failure = 21, fixture = 32, seed = 193 }
316316

317317
[[entry]]
318318
engine = "native-preview"
@@ -340,14 +340,14 @@ engine = "native-preview"
340340
stage = "contracts"
341341
site = "contracts.native"
342342
kind = "contract_validations"
343-
counts = { example = 9, failure = 106, fixture = 6, seed = 25 }
343+
counts = { example = 9, failure = 109, fixture = 6, seed = 25 }
344344

345345
[[entry]]
346346
engine = "native-preview"
347347
stage = "contracts"
348348
site = "contracts.native"
349349
kind = "promotion_checks"
350-
counts = { example = 12, failure = 106, fixture = 8, seed = 33 }
350+
counts = { example = 12, failure = 109, fixture = 8, seed = 33 }
351351

352352
[[entry]]
353353
engine = "native-preview"
@@ -375,7 +375,7 @@ engine = "native-preview"
375375
stage = "declaration_scopes"
376376
site = "declaration_scopes.native"
377377
kind = "scope_indexes"
378-
counts = { example = 12, failure = 221, fixture = 12, seed = 44 }
378+
counts = { example = 12, failure = 224, fixture = 12, seed = 44 }
379379

380380
[[entry]]
381381
engine = "native-preview"
@@ -396,14 +396,14 @@ engine = "native-preview"
396396
stage = "discovery"
397397
site = "discovery.native"
398398
kind = "model_file_listings"
399-
counts = { example = 12, failure = 286, fixture = 12, seed = 50 }
399+
counts = { example = 12, failure = 289, fixture = 12, seed = 50 }
400400

401401
[[entry]]
402402
engine = "native-preview"
403403
stage = "lineage_facts"
404404
site = "lineage_facts.native"
405405
kind = "lineage_graphs"
406-
counts = { example = 9, failure = 106, fixture = 6, seed = 22 }
406+
counts = { example = 9, failure = 109, fixture = 6, seed = 22 }
407407

408408
[[entry]]
409409
engine = "native-preview"
@@ -466,14 +466,14 @@ engine = "native-preview"
466466
stage = "model_analysis"
467467
site = "model_analysis.native"
468468
kind = "expression_shapes"
469-
counts = { example = 4, failure = 111, fixture = 4, seed = 100 }
469+
counts = { example = 4, failure = 114, fixture = 4, seed = 100 }
470470

471471
[[entry]]
472472
engine = "native-preview"
473473
stage = "model_analysis"
474474
site = "model_analysis.native"
475475
kind = "model_analyses"
476-
counts = { example = 56, failure = 214, fixture = 52, seed = 686 }
476+
counts = { example = 56, failure = 221, fixture = 52, seed = 686 }
477477

478478
[[entry]]
479479
engine = "native-preview"
@@ -494,14 +494,14 @@ engine = "native-preview"
494494
stage = "model_config"
495495
site = "model_config.native"
496496
kind = "config_builds"
497-
counts = { example = 56, failure = 298, fixture = 64, seed = 890 }
497+
counts = { example = 56, failure = 302, fixture = 64, seed = 890 }
498498

499499
[[entry]]
500500
engine = "native-preview"
501501
stage = "model_config"
502502
site = "model_config.native"
503503
kind = "validations"
504-
counts = { example = 56, failure = 365, fixture = 60, seed = 1091 }
504+
counts = { example = 56, failure = 372, fixture = 60, seed = 1091 }
505505

506506
[[entry]]
507507
engine = "native-preview"
@@ -515,21 +515,21 @@ engine = "native-preview"
515515
stage = "model_config"
516516
site = "model_config.python_templates"
517517
kind = "config"
518-
counts = { example = 12, failure = 111, fixture = 8, seed = 36 }
518+
counts = { example = 12, failure = 114, fixture = 8, seed = 36 }
519519

520520
[[entry]]
521521
engine = "native-preview"
522522
stage = "model_config"
523523
site = "model_config.python_templates"
524524
kind = "connection"
525-
counts = { example = 18, failure = 113, fixture = 9, seed = 63 }
525+
counts = { example = 18, failure = 116, fixture = 9, seed = 63 }
526526

527527
[[entry]]
528528
engine = "native-preview"
529529
stage = "model_config"
530530
site = "model_config.python_templates"
531531
kind = "effective_vars"
532-
counts = { example = 29, failure = 236, fixture = 15, seed = 121 }
532+
counts = { example = 29, failure = 239, fixture = 15, seed = 121 }
533533

534534
[[entry]]
535535
engine = "native-preview"
@@ -557,7 +557,7 @@ engine = "native-preview"
557557
stage = "model_loop"
558558
site = "model_loop.cursor_intrinsic_validation"
559559
kind = "deferred"
560-
counts = { example = 56, failure = 395, fixture = 64, seed = 1100 }
560+
counts = { example = 56, failure = 402, fixture = 64, seed = 1100 }
561561

562562
[[entry]]
563563
engine = "native-preview"
@@ -578,14 +578,14 @@ engine = "native-preview"
578578
stage = "model_loop"
579579
site = "model_loop.native"
580580
kind = "declaration_expansions"
581-
counts = { example = 56, failure = 406, fixture = 64, seed = 1100 }
581+
counts = { example = 56, failure = 413, fixture = 64, seed = 1100 }
582582

583583
[[entry]]
584584
engine = "native-preview"
585585
stage = "model_loop"
586586
site = "model_loop.native"
587587
kind = "variable_substitutions"
588-
counts = { example = 56, failure = 448, fixture = 72, seed = 1157 }
588+
counts = { example = 56, failure = 455, fixture = 72, seed = 1157 }
589589

590590
[[entry]]
591591
engine = "native-preview"
@@ -606,39 +606,39 @@ engine = "native-preview"
606606
stage = "project_assembly"
607607
site = "project_assembly.assembly"
608608
kind = "deferred"
609-
counts = { example = 12, failure = 111, fixture = 8, seed = 36 }
609+
counts = { example = 12, failure = 114, fixture = 8, seed = 36 }
610610

611611
[[entry]]
612612
engine = "native-preview"
613613
stage = "reference_extraction"
614614
site = "reference_extraction.native"
615615
kind = "reference_scans"
616-
counts = { example = 250, failure = 448, fixture = 249, seed = 1523 }
616+
counts = { example = 250, failure = 463, fixture = 249, seed = 1523 }
617617

618618
[[entry]]
619619
engine = "native-preview"
620620
stage = "semantic_checks"
621621
site = "semantic_checks.native"
622622
kind = "semantic_completions"
623-
counts = { example = 12, failure = 108, fixture = 8, seed = 36 }
623+
counts = { example = 12, failure = 111, fixture = 8, seed = 36 }
624624

625625
[[entry]]
626626
engine = "native-preview"
627627
stage = "sql_test_glue"
628628
site = "sql_test_glue.assembly"
629629
kind = "deferred"
630-
counts = { example = 12, failure = 108, fixture = 8, seed = 36 }
630+
counts = { example = 12, failure = 111, fixture = 8, seed = 36 }
631631

632632
[[entry]]
633633
engine = "native-preview"
634634
stage = "sql_test_glue"
635-
site = "sql_test_glue.planning"
636-
kind = "deferred"
637-
counts = { example = 1, failure = 3, fixture = 1, seed = 9 }
635+
site = "sql_test_glue.native"
636+
kind = "sql_test_plans"
637+
counts = { example = 1, failure = 4, fixture = 1, seed = 9 }
638638

639639
[[entry]]
640640
engine = "python"
641641
stage = "discovery"
642642
site = "discovery.native"
643643
kind = "model_file_listings"
644-
counts = { example = 12, failure = 286, fixture = 12, seed = 50 }
644+
counts = { example = 12, failure = 289, fixture = 12, seed = 50 }

‎src/sqlbuild/cli/commands/_helpers/compile/target_writer.py‎

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -577,7 +577,9 @@ def _plan_static_test_artifacts(
577577
) as lifecycle:
578578
native_planning: bool = native_stage_enabled(NativeStage.SQL_TEST_GLUE)
579579
plan_artifacts: Callable[..., tuple[NativeSqlTestArtifact, ...]] = (
580-
plan_native_sql_test_artifacts if native_planning else plan_and_render_sql_test_artifacts
580+
plan_native_sql_test_artifacts
581+
if native_planning
582+
else plan_and_render_sql_test_artifacts
581583
)
582584
native_artifacts: tuple[NativeSqlTestArtifact, ...] = plan_artifacts(
583585
project=project,

‎tests/e2e/scripts/compiler_differential/test_native_fallback_gate.py‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -155,8 +155,8 @@ def test_given_recorded_allow_list_when_native_defers_more_or_less_then_the_gate
155155
expected_lines=(
156156
"Native fallback allow-list: native-preview sql_test_glue sql_test_glue.assembly "
157157
f"deferred (fixture): {_FALLBACK_WITHOUT_ANSWERS}",
158-
"Native fallback allow-list: native-preview sql_test_glue sql_test_glue.planning "
159-
f"deferred (fixture): {_FALLBACK_WITHOUT_ANSWERS}",
158+
"Native fallback allow-list: native-preview sql_test_glue sql_test_glue.native "
159+
f"sql_test_plans (fixture): {_ANSWER_VANISHED}",
160160
"Native fallback allow-list: 2 problems",
161161
),
162162
),

‎tests/goldens/compiler/failure/sql-test-glue-inverted-window.json‎

Lines changed: 36 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,36 @@
1+
{
2+
"commands": [
3+
{
4+
"label": "compile",
5+
"exit_code": 1,
6+
"diagnostics": [
7+
{
8+
"phase": "compile",
9+
"severity": "error",
10+
"code": "P001",
11+
"message": "SQL test 'inverted_window' in 'tests/unit/test_customer_totals.sql': cursor_start '20' must be before the exclusive cursor_end '10' for model 'windowed_orders'"
12+
}
13+
]
14+
}
15+
],
16+
"compiled": {
17+
"models/marts/customer_totals.sql": [
18+
"SELECT customer_id, SUM(amount) AS total_amount",
19+
"FROM __ref(\"stg_orders\")",
20+
"GROUP BY customer_id",
21+
""
22+
],
23+
"models/marts/windowed_orders.sql": [
24+
"SELECT order_id, amount",
25+
"FROM __source(\"raw_orders\")",
26+
"WHERE order_id >= __cursor_start() AND order_id < __cursor_end()",
27+
""
28+
],
29+
"models/staging/stg_orders.sql": [
30+
"SELECT order_id, customer_id, amount, status",
31+
"FROM __source(\"raw_orders\")",
32+
""
33+
]
34+
},
35+
"manifest": null
36+
}

0 commit comments

Comments
 (0)