fix(duckshop): list unit-test mock columns in declared order and plan unit tests in CI

Author: kvlonge

benchmarks/duckshop/README.md

@@ -162,6 +162,10 @@ earlier ones:
   same results on every run: added SKUs are sorted, the weekday average utilisation is an exact
   decimal sum over a count, the busiest slot of equally busy ones is the earliest, and the top
   exception code of equally frequent ones is the first in alphabetical order.
+- The mocks of `stg_wishlist_items`, `stg_purchase_order_lines` and `int_loyalty_tier_changes` in
+  three unit tests list their columns in the models' declared order, which unit-test planning
+  requires for a `SELECT *` reader. Only compiled tests change; compiled models are the same, so
+  model benchmarks stay comparable.
 
 ## Status
 

benchmarks/duckshop/project/tests/unit/intermediate/customers/test_int_wishlist_demand__counts_purchases_made_after_wishlisting.sql

@@ -2,25 +2,25 @@ TEST (name "int_wishlist_demand__counts_purchases_made_after_wishlisting");
 
 WITH __ref__stg_wishlist_items AS (
   SELECT
+    'W1#1' AS wishlist_item_key,
     'W1' AS wishlist_id,
     'C1' AS customer_id,
-    'W1#1' AS wishlist_item_key,
     'DUCK-1' AS sku,
     '2026-03-01 00:00:00 +00:00'::TIMESTAMPTZ AS added_at,
     NULL AS item_position
   UNION ALL
   SELECT
+    'W2#1',
     'W2',
     'C1',
-    'W2#1',
     'DUCK-1',
     '2026-03-02 00:00:00 +00:00'::TIMESTAMPTZ,
     NULL
   UNION ALL
   SELECT
+    'W3#1',
     'W3',
     'C2',
-    'W3#1',
     'DUCK-1',
     '2026-03-05 00:00:00 +00:00'::TIMESTAMPTZ,
     NULL

benchmarks/duckshop/project/tests/unit/intermediate/inventory/test_int_purchase_order_lines_received__measures_fill_and_lateness_in_warehouse_time.sql

@@ -32,19 +32,19 @@ WITH __ref__stg_po_receipts AS (
 
 __ref__stg_purchase_order_lines AS (
   SELECT
-    'PO1' AS po_id,
-    NULL AS currency_code,
     'PO1#1' AS po_line_key,
+    'PO1' AS po_id,
     'DUCK-1' AS sku,
     10 AS ordered_qty,
-    NULL AS unit_cost_minor
+    NULL AS unit_cost_minor,
+    NULL AS currency_code
   UNION ALL
   SELECT
-    'PO1',
-    NULL,
     'PO1#2',
+    'PO1',
     'DUCK-2',
     5,
+    NULL,
     NULL
 ),
 

benchmarks/duckshop/project/tests/unit/marts/core/test_dim_customers__combines_profile_value_consent_and_loyalty.sql

@@ -115,23 +115,23 @@ __ref__int_customer_consent_state AS (
 
 __ref__int_loyalty_tier_changes AS (
   SELECT
+    'LA1:1' AS tier_change_key,
     NULL AS loyalty_account_id,
     'C1' AS customer_id,
+    1 AS change_sequence,
     'DUCKLING' AS tier_code,
     NULL AS previous_tier_code,
-    'LA1:1' AS tier_change_key,
-    1 AS change_sequence,
     NULL AS changed_at,
     NULL AS direction,
     NULL AS days_in_previous_tier
   UNION ALL
   SELECT
+    'LA1:2',
     NULL,
     'C1',
+    2,
     'GOLDEN_DUCK',
     NULL,
-    'LA1:2',
-    2,
     NULL,
     NULL,
     NULL

tests/e2e/src/sqlbuild/cli/commands/main/compile/_test_types.py

@@ -1255,6 +1255,16 @@ class BenchmarkProjectCompileTestCase:
     expected_warnings: int
 
 
+@dataclass(frozen=True)
+class BenchmarkProjectTestPlanTestCase:
+    """A benchmark project whose unit tests must plan without a warehouse connection."""
+
+    description: str
+    project_dir: Path
+    expected_final_line_prefix: str
+    expected_final_line_suffix: str
+
+
 @dataclass(frozen=True)
 class BenchmarkCoreCopyCompileTestCase:
     """A script that copies a benchmark project without an area, and the copy's compiled output.

tests/e2e/src/sqlbuild/cli/commands/main/compile/test_duckshop_benchmark_compile.py

@@ -14,6 +14,7 @@
 from tests.e2e.src.sqlbuild.cli.commands.main.compile._test_types import (
     BenchmarkCoreCopyCompileTestCase,
     BenchmarkProjectCompileTestCase,
+    BenchmarkProjectTestPlanTestCase,
 )
 from tests.e2e.src.sqlbuild.cli.commands.shared.helpers import REPO_ROOT, run_sqb
 
@@ -63,6 +64,40 @@ def test_given_benchmark_project_when_compiling_then_reports_no_errors_or_warnin
     assert summary["tests"] > 0
 
 
+@pytest.mark.parametrize(
+    "test_case",
+    [
+        BenchmarkProjectTestPlanTestCase(
+            description="duckshop",
+            project_dir=REPO_ROOT / "benchmarks" / "duckshop" / "project",
+            expected_final_line_prefix="Test plan inspection complete: ",
+            expected_final_line_suffix=" selected, 0 errors.",
+        )
+    ],
+    ids=lambda case: case.description,
+)
+def test_given_benchmark_project_when_inspecting_test_plan_then_every_unit_test_plans(
+    test_case: BenchmarkProjectTestPlanTestCase, tmp_path: Path
+) -> None:
+    """Mock fixtures are checked against declared columns only when tests are planned."""
+    project_dir: Path = tmp_path / test_case.description
+    shutil.copytree(
+        test_case.project_dir,
+        project_dir,
+        ignore=shutil.ignore_patterns(*_LOCAL_ONLY_PATHS),
+    )
+
+    result: subprocess.CompletedProcess[str] = run_sqb(
+        command=("--no-color", "test", "--inspect"),
+        project_dir=project_dir,
+    )
+
+    assert result.returncode == 0, result.stdout + result.stderr
+    final_line: str = result.stdout.strip().splitlines()[-1]
+    assert final_line.startswith(test_case.expected_final_line_prefix), result.stdout
+    assert final_line.endswith(test_case.expected_final_line_suffix), result.stdout
+
+
 @pytest.mark.parametrize(
     "test_case",
     [
@@ -73,7 +108,7 @@ def test_given_benchmark_project_when_compiling_then_reports_no_errors_or_warnin
             expected_errors=0,
             expected_warnings=0,
             expected_compiled_checksum=(
-                "1ff1d0955ea3839b3c969707fd47ca9a4d7d7216753759d23911836f6ea5879d"
+                "7661e2ad98b33b8230c9df9c6c780e959cb7e18398b14a2cef36e12d19bd0bb6"
             ),
         )
     ],