fix(dbt): give dbt-appropriate remediation when a missing origin needs confirmation

Author: kvlonge

src/sqlbuild/.agents/skills/sqlbuild/references/docs/concepts/project-configuration.md

@@ -235,7 +235,7 @@ missing_migration_origin = "deny"
 
 `sqlbuild_local.toml` can override the value for a target.
 
-The policy covers only origins with no build history in the target. A model origin that SQLBuild built in this target but can no longer see, because of permissions or because it was dropped outside SQLBuild, always stops the build with `M102`. Column origins have no such history, so `M109` always follows the policy. `sqb dbt run` and `sqb dbt build` apply the policy too, without a confirmation flag: they ask on a terminal and stop otherwise.
+The policy covers only origins with no build history in the target. A model origin that SQLBuild built in this target but can no longer see, because of permissions or because it was dropped outside SQLBuild, always stops the build with `M102`. Column origins have no such history, so `M109` always follows the policy. `sqb dbt run` and `sqb dbt build` apply the policy too, but have no confirmation flag: they ask on a terminal and stop otherwise. In non-interactive dbt runs, build the affected models with `sqb build --allow-missing-migration-origin` and leave them out of the dbt selection, or set the target's `missing_migration_origin` to `allow`.
 
 ### Clone policies
 

src/sqlbuild/cli/commands/_helpers/build_planning/confirmation.py

@@ -10,7 +10,7 @@
 def confirm_typed_action(
     *,
     action: str,
-    flag: str,
+    non_interactive_help: str,
     warning: str,
     expected: str,
     input_stream: TextIO,
@@ -23,7 +23,7 @@ def confirm_typed_action(
         raise CliUserError(
             f"{action} requires confirmation",
             code=code,
-            help=f"Pass {flag} to confirm in non-interactive runs.",
+            help=non_interactive_help,
         )
     _ = output_stream.write(f"{warning}\n\n")
     _ = output_stream.write(f"Type `{expected}` to continue: ")

src/sqlbuild/cli/commands/_helpers/build_planning/plan_policies.py

@@ -19,6 +19,7 @@
 from sqlbuild.cli.commands._helpers.build_planning.table_type import (
     enforce_table_type_downgrade_policy,
 )
+from sqlbuild.cli.commands.constants import MISSING_ORIGIN_BUILD_HELP
 from sqlbuild.cli.commands.exceptions import CliUserError
 from sqlbuild.cli.commands.models import BuildCommandRequest, BuildInvocation
 from sqlbuild.compiler.migrations.types import ColumnMigrationDecision, MigrationDecision
@@ -49,6 +50,7 @@ def enforce_build_plan_policies(
     enforce_migration_plan_policies(
         plan=plan,
         allow_missing_migration_origin=request.allow_missing_migration_origin,
+        non_interactive_help=MISSING_ORIGIN_BUILD_HELP,
         input_stream=sys.stdin,
         output_stream=sys.stdout,
     )
@@ -83,6 +85,7 @@ def enforce_migration_plan_policies(
     *,
     plan: PlanOutput,
     allow_missing_migration_origin: bool,
+    non_interactive_help: str,
     input_stream: TextIO,
     output_stream: TextIO,
 ) -> None:
@@ -93,6 +96,7 @@ def enforce_migration_plan_policies(
     _confirm_missing_origins(
         plan=plan,
         allow_missing_migration_origin=allow_missing_migration_origin,
+        non_interactive_help=non_interactive_help,
         input_stream=input_stream,
         output_stream=output_stream,
     )
@@ -182,6 +186,7 @@ def _confirm_missing_origins(
     *,
     plan: PlanOutput,
     allow_missing_migration_origin: bool,
+    non_interactive_help: str,
     input_stream: TextIO,
     output_stream: TextIO,
 ) -> None:
@@ -203,7 +208,7 @@ def _confirm_missing_origins(
     listed: str = ", ".join(f"'{name}'" for name in names)
     confirm_typed_action(
         action=f"building {listed} without its missing migrate_from origin",
-        flag="--allow-missing-migration-origin",
+        non_interactive_help=non_interactive_help,
         warning=f"The migrate_from origin of {listed} does not exist in this target; nothing "
         "will be migrated.",
         expected=(

src/sqlbuild/cli/commands/_helpers/dbt/sqlbuild_work.py

@@ -17,6 +17,7 @@
     BuildProgressCallbacks,
     format_build_footer,
 )
+from sqlbuild.cli.commands.constants import MISSING_ORIGIN_DBT_HELP
 from sqlbuild.cli.commands.models import DbtSqlbuildWorkContext
 from sqlbuild.cli.progress.classes.connection_progress_reporter import ConnectionProgressReporter
 from sqlbuild.cli.progress.main._execution_header import format_execution_header
@@ -56,6 +57,7 @@ def execute_sqlbuild_build_work(
     enforce_migration_plan_policies(
         plan=plan_output,
         allow_missing_migration_origin=False,
+        non_interactive_help=MISSING_ORIGIN_DBT_HELP,
         input_stream=sys.stdin,
         output_stream=output_stream,
     )

src/sqlbuild/cli/commands/constants.py

@@ -103,4 +103,12 @@
 QUERY_DIFF_INCOMPLETE_PREPARATION_CODES: frozenset[str] = frozenset(
     {"C229", "C230", "C231", "C232", "C233", "C234", "C235", "C240", "C244"}
 )
+MISSING_ORIGIN_BUILD_HELP: str = (
+    "Pass --allow-missing-migration-origin to confirm in non-interactive runs."
+)
+MISSING_ORIGIN_DBT_HELP: str = (
+    "sqb dbt has no confirmation flag: confirm on an interactive terminal, build the affected "
+    "models with sqb build --allow-missing-migration-origin and leave them out of this dbt "
+    "selection, or set the target's missing_migration_origin to 'allow'."
+)
 QUERY_DIFF_INCOMPLETE_EXECUTION_CODES: frozenset[str] = frozenset({"C237", "C238", "C239"})

tests/e2e/src/sqlbuild/cli/commands/main/dbt/test_execute.py

@@ -551,12 +551,12 @@ def test_given_failing_dbt_model_when_running_command_then_dependent_sqlbuild_is
         DbtMissingOriginE2ETestCase(
             description="dbt build refuses a missing origin that needs confirmation",
             command=("dbt", "build", "--select", "tag:sqb_only"),
-            expected_output="--allow-missing-migration-origin",
+            expected_output="build the affected models with sqb build --allow-missing-migration-origin",
         ),
         DbtMissingOriginE2ETestCase(
             description="dbt run refuses a missing origin that needs confirmation",
             command=("dbt", "run", "--select", "local_only"),
-            expected_output="--allow-missing-migration-origin",
+            expected_output="build the affected models with sqb build --allow-missing-migration-origin",
         ),
     ],
     ids=lambda case: case.description,
@@ -575,4 +575,5 @@ def test_given_missing_origin_requiring_confirmation_when_running_dbt_then_refus
 
     assert result.returncode == 1, result.stdout + result.stderr
     assert test_case.expected_output in result.stdout + result.stderr
+    assert "Pass --allow-missing-migration-origin" not in result.stdout + result.stderr
     assert not table_exists(db_path=project_dir / "dbt_interop.duckdb", table_name="local_only")

website/src/content/docs/docs/concepts/project-configuration.mdx

@@ -212,7 +212,7 @@ missing_migration_origin = "deny"
 
 `sqlbuild_local.toml` can override the value for a target.
 
-The policy covers only origins with no build history in the target. A model origin that SQLBuild built in this target but can no longer see, because of permissions or because it was dropped outside SQLBuild, always stops the build with `M102`. Column origins have no such history, so `M109` always follows the policy. `sqb dbt run` and `sqb dbt build` apply the policy too, without a confirmation flag: they ask on a terminal and stop otherwise.
+The policy covers only origins with no build history in the target. A model origin that SQLBuild built in this target but can no longer see, because of permissions or because it was dropped outside SQLBuild, always stops the build with `M102`. Column origins have no such history, so `M109` always follows the policy. `sqb dbt run` and `sqb dbt build` apply the policy too, but have no confirmation flag: they ask on a terminal and stop otherwise. In non-interactive dbt runs, build the affected models with `sqb build --allow-missing-migration-origin` and leave them out of the dbt selection, or set the target's `missing_migration_origin` to `allow`.
 
 ### Clone policies