Repository navigation
Commit e160823
authored
fix(compiler)!: reject unknown config keys and keep scenario SQL as authored (#906)
* fix(compiler)!: reject unknown MODEL, model-default and source keys
MODEL() headers, [defaults], [path_defaults.*] and sources/*.yml silently
ignored unknown keys, so a typo or a removed setting had no effect. Every
statement header (MODEL, FUNCTION, AUDIT, TEST, HOOK, SCENARIO, @udf) now
shares one unsupported-keys error that names the key with its file and
line and suggests the nearest supported key. Custom materialization
values stay inside the free-form config block.
BREAKING CHANGE: unknown keys in MODEL() headers, project defaults, path
defaults and sources files now fail compilation.
* perf(compiler): keep per-diagnostic work linear in diagnostic-heavy models
One model with thousands of diagnostics compiled in quadratic time:
locating each unknown column rescanned the authored SQL natively, and
diagnostic recovery and explanation rebuilt per-model column sets,
lineage lists, line splits and binary-expression scans for every
diagnostic. Index each once per model and look positions up by
bisect or hash. A one-model scaling guard compares 1k and 4k
diagnostics.
* fix(format): keep comma spacing before adjacent string literals
When the layout oracle rewrote a substituted region, for example DuckDB
'north' 'east' printed as CONCAT('north', 'east'), the token after the
region took the oracle's spacing after the CONCAT( it introduced, so
`replace, 'north'` became `replace,'north'` and lost its line break. The
spacing now comes from the oracle's own copy of the authored token that
precedes it.
* fix(dbt): apply sqb build plan safety policies on dbt run and build
sqb dbt run and build enforced only the missing-origin and retention
decrease policies before executing SQLBuild work, so a
table_type_downgrade, snapshot full-refresh or max_models policy could
be bypassed through the dbt interop path. Both commands now share the
sqb build gate sequence. sqb dbt has no allow flags: a policy that needs
confirmation prompts on a terminal and otherwise refuses with guidance
naming the matching sqb build flag or policy setting.
* fix(scenario): run scenario fixture and check SQL as authored
Scenario expected, assertion, helper and fixture SQL was parsed and
regenerated with the generic dialect to swap relation markers, so
dialect syntax was rewritten or rejected (S506) and the executed SQL
differed from what was authored. Markers are now replaced in the
authored text, skipping comments and quoted text under the project
adapter's lexical rules, also for --local replay: backslash escapes on
Snowflake, BigQuery and Databricks, E'...' strings on DuckDB and
Postgres, nested block comments where the dialect nests them, and
BigQuery '#' and Snowflake '//' line comments. A marker the scenario
cannot resolve, or SQL with an unclosed string or comment, fails
planning with S511 naming the scenario file instead of being left in
the executed SQL. Local replay no longer regenerates SQL captured from
DuckDB.1 parent 44c2d30 commit e160823
107 files changed
Lines changed: 3256 additions & 719 deletions
File tree
- crates/sqlbuild-rules-native/src
- compiler
- _helpers/model_headers
- tests
- semantic_validation
- _helpers
- tests
- sql_lint
- _helpers
- tests
- scripts/cold_compile_performance/_helpers
- src/sqlbuild
- .agents/skills/sqlbuild/references/docs
- cli
- concepts
- models
- adapters
- bigquery/classes
- databricks/classes
- postgres/classes
- snowflake/classes
- sqlserver/classes
- adapter/contract/classes
- cli/commands
- _helpers
- build_planning
- dbt
- scenario_execution
- compiler
- compile/_helpers
- attachment
- diagnostics
- discovery
- _helpers
- integrations
- python
- sql
- validation
- yml
- planner
- _helpers
- resolve
- scenario
- main/scenarios
- sql_analysis
- _helpers
- main
- executor
- pipeline/_helpers
- scenario
- _helpers/local
- integrations/dbt/_helpers/pipeline
- tests
- e2e/src/sqlbuild/cli/commands/main
- compile
- dbt
- format
- scenario
- integration/src/sqlbuild/cli/commands/main
- unit/src/sqlbuild
- cli/commands/_helpers/build_planning
- compiler
- compile
- discovery/_helpers
- planner/_helpers
- sql_analysis/_helpers
- executor
- pipeline/_helpers
- scenario/_helpers
- website/src/content/docs/docs
- cli
- concepts
- models
Some content is hidden
Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
116 | 116 | | |
117 | 117 | | |
118 | 118 | | |
| 119 | + | |
119 | 120 | | |
120 | 121 | | |
121 | 122 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
438 | 438 | | |
439 | 439 | | |
440 | 440 | | |
| 441 | + | |
| 442 | + | |
| 443 | + | |
| 444 | + | |
441 | 445 | | |
442 | 446 | | |
443 | 447 | | |
| |||
470 | 474 | | |
471 | 475 | | |
472 | 476 | | |
473 | | - | |
| 477 | + | |
| 478 | + | |
| 479 | + | |
| 480 | + | |
| 481 | + | |
474 | 482 | | |
475 | 483 | | |
476 | 484 | | |
| |||
518 | 526 | | |
519 | 527 | | |
520 | 528 | | |
| 529 | + | |
| 530 | + | |
| 531 | + | |
| 532 | + | |
| 533 | + | |
| 534 | + | |
| 535 | + | |
| 536 | + | |
| 537 | + | |
| 538 | + | |
| 539 | + | |
| 540 | + | |
| 541 | + | |
| 542 | + | |
| 543 | + | |
| 544 | + | |
| 545 | + | |
| 546 | + | |
| 547 | + | |
| 548 | + | |
| 549 | + | |
521 | 550 | | |
522 | 551 | | |
523 | 552 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
144 | 144 | | |
145 | 145 | | |
146 | 146 | | |
| 147 | + | |
| 148 | + | |
| 149 | + | |
| 150 | + | |
| 151 | + | |
| 152 | + | |
| 153 | + | |
| 154 | + | |
| 155 | + | |
| 156 | + | |
| 157 | + | |
| 158 | + | |
| 159 | + | |
| 160 | + | |
| 161 | + | |
| 162 | + | |
| 163 | + | |
| 164 | + | |
| 165 | + | |
| 166 | + | |
| 167 | + | |
| 168 | + | |
| 169 | + | |
| 170 | + | |
| 171 | + | |
| 172 | + | |
| 173 | + | |
| 174 | + | |
| 175 | + | |
| 176 | + | |
| 177 | + | |
| 178 | + | |
| 179 | + | |
| 180 | + | |
| 181 | + | |
| 182 | + | |
| 183 | + | |
| 184 | + | |
| 185 | + | |
| 186 | + | |
| 187 | + | |
147 | 188 | | |
148 | 189 | | |
149 | 190 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | 1 | | |
2 | | - | |
| 2 | + | |
| 3 | + | |
3 | 4 | | |
4 | 5 | | |
5 | 6 | | |
| |||
18 | 19 | | |
19 | 20 | | |
20 | 21 | | |
| 22 | + | |
| 23 | + | |
| 24 | + | |
| 25 | + | |
| 26 | + | |
21 | 27 | | |
22 | 28 | | |
23 | 29 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
8 | 8 | | |
9 | 9 | | |
10 | 10 | | |
11 | | - | |
| 11 | + | |
12 | 12 | | |
13 | 13 | | |
14 | 14 | | |
| |||
42 | 42 | | |
43 | 43 | | |
44 | 44 | | |
| 45 | + | |
45 | 46 | | |
46 | 47 | | |
47 | 48 | | |
| |||
59 | 60 | | |
60 | 61 | | |
61 | 62 | | |
62 | | - | |
63 | | - | |
64 | | - | |
65 | | - | |
66 | | - | |
67 | | - | |
68 | | - | |
69 | | - | |
70 | | - | |
71 | | - | |
72 | | - | |
73 | | - | |
74 | | - | |
75 | | - | |
76 | | - | |
| 63 | + | |
| 64 | + | |
77 | 65 | | |
78 | 66 | | |
79 | 67 | | |
| |||
116 | 104 | | |
117 | 105 | | |
118 | 106 | | |
| 107 | + | |
| 108 | + | |
| 109 | + | |
| 110 | + | |
| 111 | + | |
| 112 | + | |
| 113 | + | |
| 114 | + | |
| 115 | + | |
| 116 | + | |
| 117 | + | |
| 118 | + | |
| 119 | + | |
| 120 | + | |
| 121 | + | |
| 122 | + | |
| 123 | + | |
| 124 | + | |
| 125 | + | |
| 126 | + | |
| 127 | + | |
| 128 | + | |
| 129 | + | |
| 130 | + | |
| 131 | + | |
| 132 | + | |
| 133 | + | |
| 134 | + | |
| 135 | + | |
| 136 | + | |
| 137 | + | |
| 138 | + | |
| 139 | + | |
| 140 | + | |
| 141 | + | |
| 142 | + | |
| 143 | + | |
| 144 | + | |
| 145 | + | |
| 146 | + | |
| 147 | + | |
| 148 | + | |
| 149 | + | |
| 150 | + | |
| 151 | + | |
| 152 | + | |
| 153 | + | |
119 | 154 | | |
120 | 155 | | |
121 | 156 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
65 | 65 | | |
66 | 66 | | |
67 | 67 | | |
| 68 | + | |
68 | 69 | | |
69 | 70 | | |
70 | 71 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | 1 | | |
2 | 2 | | |
| 3 | + | |
| 4 | + | |
3 | 5 | | |
4 | 6 | | |
5 | 7 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
| 22 | + | |
| 23 | + | |
| 24 | + | |
| 25 | + | |
| 26 | + | |
| 27 | + | |
| 28 | + | |
| 29 | + | |
| 30 | + | |
| 31 | + | |
| 32 | + | |
| 33 | + | |
| 34 | + | |
| 35 | + | |
| 36 | + | |
| 37 | + | |
| 38 | + | |
| 39 | + | |
| 40 | + | |
| 41 | + | |
| 42 | + | |
| 43 | + | |
| 44 | + | |
| 45 | + | |
| 46 | + | |
| 47 | + | |
| 48 | + | |
| 49 | + | |
| 50 | + | |
| 51 | + | |
| 52 | + | |
| 53 | + | |
| 54 | + | |
| 55 | + | |
| 56 | + | |
| 57 | + | |
| 58 | + | |
| 59 | + | |
| 60 | + | |
| 61 | + | |
| 62 | + | |
| 63 | + | |
| 64 | + | |
| 65 | + | |
| 66 | + | |
| 67 | + | |
| 68 | + | |
| 69 | + | |
| 70 | + | |
| 71 | + | |
| 72 | + | |
| 73 | + | |
| 74 | + | |
| 75 | + | |
| 76 | + | |
| 77 | + | |
| 78 | + | |
| 79 | + | |
| 80 | + | |
| 81 | + | |
| 82 | + | |
| 83 | + | |
| 84 | + | |
| 85 | + | |
| 86 | + | |
| 87 | + | |
| 88 | + | |
| 89 | + | |
| 90 | + | |
| 91 | + | |
| 92 | + | |
| 93 | + | |
| 94 | + | |
| 95 | + | |
| 96 | + | |
| 97 | + | |
| 98 | + | |
| 99 | + | |
| 100 | + | |
| 101 | + | |
| 102 | + | |
| 103 | + | |
| 104 | + | |
| 105 | + | |
| 106 | + | |
| 107 | + | |
| 108 | + | |
| 109 | + | |
| 110 | + | |
| 111 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
24 | 24 | | |
25 | 25 | | |
26 | 26 | | |
| 27 | + | |
| 28 | + | |
| 29 | + | |
| 30 | + | |
| 31 | + | |
| 32 | + | |
| 33 | + | |
| 34 | + | |
| 35 | + | |
| 36 | + | |
| 37 | + | |
| 38 | + | |
| 39 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
554 | 554 | | |
555 | 555 | | |
556 | 556 | | |
557 | | - | |
| 557 | + | |
| 558 | + | |
| 559 | + | |
| 560 | + | |
558 | 561 | | |
559 | 562 | | |
560 | 563 | | |
| |||
0 commit comments