fix(ui): end the Sync now wait on any new sync report

A requested sync that fails the same way as before now ends the wait too.

Author: kvlonge

crates/sqlbuild-orchestration/src/platform/_helpers/recent_health.rs

@@ -9,7 +9,7 @@ use crate::store::main::decode_row::decode_row;
 use crate::store::main::query::query;
 use crate::store::models::{ControlTransaction, Parameter};
 
-/// At most 100, newest first, from every retained day (a sync follows only runs) plus each instance's last check-in.
+/// At most 100, newest first, from the health retention window (a sync follows only runs) plus instance check-ins.
 pub(crate) async fn recent_health(
     transaction: ControlTransaction,
     location_id: Uuid,

ui/src/lib/api/http-locations.test.ts

@@ -73,7 +73,7 @@ describe('warehouseSyncOf', () => {
 			sync('2026-11-08T12:01:00Z', 'catalog', null),
 			sync('2026-11-08T12:00:00Z', 'statistics', 'delivery')
 		]);
-		expect(result).toEqual({ lastSyncedAt: '2026-11-08T12:02:00Z', lastError: 'catalog: failed while reading the warehouse' });
+		expect(result).toEqual({ lastSyncedAt: '2026-11-08T12:02:00Z', lastError: 'catalog: failed while reading the warehouse', lastReportedAt: '2026-11-08T12:03:00Z' });
 	});
 
 	it("gives each table its newest sync, the time it last synced cleanly, and where the state tables are read from", () => {

ui/src/lib/api/http-locations.ts

@@ -167,6 +167,7 @@ export function warehouseSyncOf(observations: Wire['LocationHealthObservation'][
 	const failing = [...newest.values()].flatMap((s) => (s.report.health.failure ? [`${s.report.health.table}: failed while ${SYNC_STAGE[s.report.health.failure]}`] : []));
 	return {
 		lastSyncedAt: syncs.find((s) => !s.report.health.failure)?.received_at ?? null,
-		lastError: failing.length ? failing.sort().join('\n') : null
+		lastError: failing.length ? failing.sort().join('\n') : null,
+		lastReportedAt: syncs[0].received_at
 	};
 }

ui/src/lib/api/mock/mock-client.ts

@@ -338,7 +338,8 @@ export class MockApiClient implements ApiClient {
 		this.#require('connection.test');
 		const sync = this.#sync(scope);
 		setTimeout(() => {
-			Object.assign(sync, { lastSyncedAt: new Date().toISOString(), lastError: null });
+			const now = new Date().toISOString();
+			Object.assign(sync, { lastSyncedAt: now, lastError: null, lastReportedAt: now });
 			this.changes.emit(`warehouse_sync:${scope.locationId}`);
 		}, 1500);
 		return this.#reply(undefined);

ui/src/lib/api/types.ts

@@ -66,6 +66,8 @@ export type WarehouseSync = {
 	lastSyncedAt: Iso | null;
 	/** Why the latest sync failed; null when it succeeded. */
 	lastError: string | null;
+	/** When the newest sync report arrived, failed or not; a new one means a requested sync has finished. */
+	lastReportedAt?: Iso | null;
 };
 
 /** The one target a location is deployed against, e.g. `prod` on Snowflake. */

ui/src/lib/components/platform/warehouse-sync-now.svelte

@@ -20,7 +20,7 @@
 	let requested = $state<{ at: number; seen: string } | null>(null);
 	let failure = $state<string | null>(null);
 	const last = $derived(sync.data ?? null);
-	const reportOf = (report: typeof last) => `${report?.lastSyncedAt ?? ''}|${report?.lastError ?? ''}`;
+	const reportOf = (report: typeof last) => `${report?.lastReportedAt ?? ''}|${report?.lastSyncedAt ?? ''}|${report?.lastError ?? ''}`;
 	const pending = $derived(requested !== null && reportOf(last) === requested.seen && app.now - requested.at < 5 * 60_000);
 
 	async function request() {