From 4c139a0335fa8ffd6d1c5d6a6285fa2ea18d0ba6 Mon Sep 17 00:00:00 2001 From: Kevin Longe <273747162+kvlonge@users.noreply.github.com> Date: Thu, 8 Oct 2026 19:40:03 +0100 Subject: [PATCH] ci: widen the release comparison's one-model edit limit to cover runner noise --- .github/workflows/release-performance.yml | 2 +- scripts/release_performance/constants.py | 2 +- .../scripts/release_performance/_helpers/test_verdict.py | 6 +++--- 3 files changed, 5 insertions(+), 5 deletions(-) diff --git a/.github/workflows/release-performance.yml b/.github/workflows/release-performance.yml index 1b86ea65f2..aaf705d6ed 100644 --- a/.github/workflows/release-performance.yml +++ b/.github/workflows/release-performance.yml @@ -63,7 +63,7 @@ jobs: run: uv sync --locked --all-groups --all-extras - name: Build candidate wheel run: uv build --wheel --out-dir "${RUNNER_TEMP}/candidate" - # Temporary: one-model edit compiles use MAX_EDIT_COMPILE_TIME_RATIO (1.25x) because an edited + # Temporary: one-model edit compiles use MAX_EDIT_COMPILE_TIME_RATIO (1.35x) because an edited # model recompiles uncached; tighten it back to 1.15x once native rendering is the default. - name: Compare candidate and previous release on this runner env: diff --git a/scripts/release_performance/constants.py b/scripts/release_performance/constants.py index c3c7497e6f..9efc600af8 100644 --- a/scripts/release_performance/constants.py +++ b/scripts/release_performance/constants.py @@ -12,7 +12,7 @@ MAX_CPU_RATIO: float = 1.25 MAX_RSS_RATIO: float = 1.25 MAX_COMPILE_TIME_RATIO: float = 1.15 -MAX_EDIT_COMPILE_TIME_RATIO: float = 1.25 +MAX_EDIT_COMPILE_TIME_RATIO: float = 1.35 MIN_WALL_REGRESSION_SECONDS: float = 0.5 MIN_CPU_REGRESSION_SECONDS: float = 0.5 MIN_RSS_REGRESSION_BYTES: int = 32 * 1024 * 1024 diff --git a/tests/unit/scripts/release_performance/_helpers/test_verdict.py b/tests/unit/scripts/release_performance/_helpers/test_verdict.py index f8a6865933..37e0a03104 100644 --- a/tests/unit/scripts/release_performance/_helpers/test_verdict.py +++ b/tests/unit/scripts/release_performance/_helpers/test_verdict.py @@ -229,19 +229,19 @@ def test_given_command_minimum_version_when_checking_versions_then_explains_skip ConfiguredTimeLimitTestCase( description="a dense one-model edit within the edit limit passes", command="dense compile (one-model edit)", - wall_ratio=1.232, + wall_ratio=1.289, expected_regressed=False, ), ConfiguredTimeLimitTestCase( description="a one-model edit within the edit limit passes", command="compile (one-model edit)", - wall_ratio=1.24, + wall_ratio=1.34, expected_regressed=False, ), ConfiguredTimeLimitTestCase( description="a dense one-model edit beyond the edit limit fails", command="dense compile (one-model edit)", - wall_ratio=1.26, + wall_ratio=1.36, expected_regressed=True, ), ConfiguredTimeLimitTestCase(