Skip to content

Commit 5ca1484

Browse files
committed
audit: playground run display PR #137 at 17beff1, approved
1 parent b64ede2 commit 5ca1484

1 file changed

Lines changed: 26 additions & 0 deletions

File tree

Lines changed: 26 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,26 @@
1+
[review]
2+
schema = "sqlquack.recorder-change-review.v1"
3+
decision = "D321"
4+
related = ["D94"]
5+
pull_request = 137
6+
branch = "fix/playground-run-display"
7+
commit = "17beff177"
8+
base = "8f8b12e31"
9+
merge_base = "8f8b12e31"
10+
previous_review = "product-d321-playground-pr132-8f8b12e3.toml"
11+
reviewed_at = "2026-11-06T23:35:52Z"
12+
round = 1
13+
verdict = "approved"
14+
checked = [
15+
"one commit on #132 at 8f8b12e3, website/ only (playground.js, spans.js, lib.rs, playground.test.mjs); no converter, policy, case or baseline file",
16+
"the Run header takes the statement's own names from DESCRIBE of the converted SQL and reads values by column position, so two columns named ORDER_ID keep their names and values; DESCRIBE only binds the statement, it does not run it, and when it fails or its column count differs from the wrapper's the header falls back to the wrapper's names, so a mismatch can only show the old names, never shift values under the wrong header",
17+
"run_failure now ends a quoted tag at the last quote on its line, so a tagged message holding an apostrophe (Can't parse ...) reads back whole; an untagged or unquoted message is unchanged, and DuckDB's own errors still return {}; this closes the non-blocking note of record 698b87bb",
18+
"the decoded error still comes only from the sqlquack:<errno> tag and SNOWFLAKE_ERRORS, so the 'Snowflake raises this error' note keeps its basis",
19+
"the author's tests (a TO_DATE format mismatch decoded as 100097 with the full message and its raise span, and a two-ORDER_ID table) and the browser DuckDB-WASM check are recorded as reported, not rerun",
20+
]
21+
22+
[review.files_sha256]
23+
"website/wasm/src/lib.rs" = "858d242a6b0d3fc37f71606263531fa3eef23320f05e2e7fad8569fd9311e1d0"
24+
"website/public/playground/playground.js" = "d7afad8e33aa86237d7fd6c65fde741729f2c0481e4f3498c7deaf9e1872c739"
25+
"website/public/playground/spans.js" = "d90562c5805668e75f2d6bcff58e58ded9ccdc55a5c03ff43f2ddfde6ba7dc01"
26+
"website/tests/playground.test.mjs" = "42bdb48b9058a7aec346552f4a34c801e1a9f79b59cfa32d11ea4e67d9892227"

0 commit comments

Comments
 (0)