fix(diagnostics): keep node names and guessed aliases out of the unaliased column message

The SQ0009 label named the internal node kind, such as `j_s_o_n_extract`,
and its help suggested an alias guessed from the text under the span.
For a path that was only its first name, and for a literal a quoted copy
of the literal. The label now reads plainly, and a literal or path gets
the help to add an alias without a guessed name.

Author: kvlonge

crates/sqlquack-convert/src/snowflake/conversion/_helpers/queries/query.rs

@@ -4,7 +4,8 @@ use serde_json::{Map, Value, json};
 use sqlquack_blocks::blocks::main::quoted_identifier::quoted_identifier;
 use sqlquack_diagnostics::classification::models::{Construct, ConstructFamily};
 use sqlquack_diagnostics::diagnostics::constants::{
-    REPEATED_RESULT_NAME, UNALIASED_OUTPUT_NAME_CONSTRUCT,
+    REPEATED_RESULT_NAME, UNALIASED_OUTPUT_NAME_CONSTRUCT, UNALIASED_QUOTED_NAME,
+    UNALIASED_TEXT_NAME,
 };
 use sqlquack_diagnostics::provenance::constants::QUERY_CONSTRUCT;
 use sqlquack_diagnostics::provenance::models::ShapeArgument;
@@ -34,6 +35,7 @@ use crate::snowflake::conversion::_helpers::support::tree::{
     function_construct, identifier_name, list, node_construct, node_kind, payload_object,
     require_understood,
 };
+use crate::snowflake::conversion::constants::UNALIASED_QUOTED_KINDS;
 use crate::snowflake::conversion::constants::WINDOW_MARKER;
 use crate::snowflake::conversion::constants::{
     ALIAS, COMMENT, COMMON_TABLE, DISTINCT, GENERATOR_SEQUENCE_COLUMN, GROUP_BY, HAVING,
@@ -694,7 +696,10 @@ fn convert_projection(
                     location: site.context.locator.locate_written(item),
                     ..missing(
                         Construct::new(ConstructFamily::Syntax, UNALIASED_OUTPUT_NAME_CONSTRUCT),
-                        format!("Snowflake names this `{kind}` column after its text"),
+                        match UNALIASED_QUOTED_KINDS.contains(&kind) {
+                            true => UNALIASED_QUOTED_NAME.to_owned(),
+                            false => UNALIASED_TEXT_NAME.to_owned(),
+                        },
                     )
                 }),
             }

crates/sqlquack-convert/src/snowflake/conversion/constants.rs

@@ -1384,3 +1384,6 @@ pub(crate) const CORRELATED_DERIVED: &str =
 pub(crate) const AMBIGUOUS_SUFFIX: &str = "is ambiguous";
 /// A JSON-held VARIANT as a sort key, in ARRAY_SORT's recorded order of kinds.
 pub const VARIANT_ORDER_KEY: &str = "rule.variant_order_key";
+
+/// The select item kinds whose Snowflake name keeps quotes or a path: literals and paths into semi-structured values.
+pub(crate) const UNALIASED_QUOTED_KINDS: &[&str] = &["j_s_o_n_extract", "literal", "subscript"];

crates/sqlquack-diagnostics/src/diagnostics/constants.rs

@@ -12,6 +12,13 @@ pub const CASE_ONLY_MATCH_HELP: &str = "Snowflake folds unquoted names to upper
     quote the name in the SQL to keep its case";
 /// The words of an unresolved name's reason when two result columns share a name.
 pub const REPEATED_RESULT_NAME: &str = "repeats an earlier result column's name";
+/// The label of an unaliased item Snowflake names after its text.
+pub const UNALIASED_TEXT_NAME: &str = "Snowflake names this column after its text";
+/// The label of an unaliased literal or path, whose Snowflake name keeps its quotes or path, so no alias is suggested.
+pub const UNALIASED_QUOTED_NAME: &str =
+    "Snowflake names this column after its full text, quotes and path included";
+/// The help for an unaliased literal or path.
+pub const UNALIASED_QUOTED_NAME_HELP: &str = "add an alias, which names the column in both engines";
 /// The help for such a name, replacing SQ0004's own.
 pub const REPEATED_RESULT_NAME_HELP: &str =
     "give each result column its own alias, such as `SELECT 1 AS first, 1 AS second`";

crates/sqlquack-diagnostics/src/diagnostics/main/diagnose.rs

@@ -10,8 +10,8 @@ use crate::diagnostics::constants::{
     CASE_ONLY_MATCH, CASE_ONLY_MATCH_HELP, CONVERSION_BUDGET, DIVERGENCE_REFUSED,
     FUNCTION_OPERAND_HELP, GUARD_PREFIX, JINJA_HELP, MISSING_RULE, NOT_EXPRESSIBLE, PARSE_FIDELITY,
     REPEATED_RESULT_NAME, REPEATED_RESULT_NAME_HELP, SUGGESTED_NAME_MAX_CHARS, TYPE_CONDITION,
-    UNALIASED_OUTPUT_NAME, UNPARSED_PREFIX, UNRESOLVED_NAME, ZONED_LOCAL_TIME,
-    ZONED_LOCAL_TIME_HELP, ZONED_LOCAL_TIME_NOTE,
+    UNALIASED_OUTPUT_NAME, UNALIASED_QUOTED_NAME, UNALIASED_QUOTED_NAME_HELP, UNPARSED_PREFIX,
+    UNRESOLVED_NAME, ZONED_LOCAL_TIME, ZONED_LOCAL_TIME_HELP, ZONED_LOCAL_TIME_NOTE,
 };
 use crate::diagnostics::models::Diagnostic;
 use crate::refusals::models::{Refusal, RefusalCategory};
@@ -52,7 +52,9 @@ pub fn diagnose(refusals: &[Refusal], source: &str) -> Vec<Diagnostic> {
         {
             diagnostic.help = Some(FUNCTION_OPERAND_HELP.to_owned());
         }
-        if code == UNALIASED_OUTPUT_NAME
+        if code == UNALIASED_OUTPUT_NAME && refusal.reason.contains(UNALIASED_QUOTED_NAME) {
+            diagnostic.help = Some(UNALIASED_QUOTED_NAME_HELP.to_owned());
+        } else if code == UNALIASED_OUTPUT_NAME
             && let Some(name) = diagnostic
                 .span
                 .and_then(|span| suggested_name(source, span.start, span.end))

crates/sqlquack/tests/cli/test_convert.rs

@@ -1566,7 +1566,7 @@ fn given_refused_sql_when_converting_then_text_and_json_carry_the_same_coded_dia
             expected_text: concat!(
                 "error[SQ0009]: This column needs an alias, because SQLQuack can't be sure of the name ",
                 "Snowflake gives it\n --> <stdin>:1:18\n  |\n1 | SELECT 'a' AS a, UPPER('é')\n",
-                "  |                  ^^^^^^^^^^ Snowflake names this `function` column after its text\n",
+                "  |                  ^^^^^^^^^^ Snowflake names this column after its text\n",
                 "  |\n  = help: add an alias, such as `AS total`, which names the column in both engines\n",
                 "sqlquack convert: refused, 1 refusal\n",
             ),

crates/sqlquack/tests/cli/test_output_names.rs

@@ -489,8 +489,8 @@ fn given_a_refused_result_name_when_converting_then_the_diagnostic_underlines_th
             expected_text: concat!(
                 "error[SQ0009]: This column needs an alias, because SQLQuack can't be sure of the name ",
                 "Snowflake gives it\n --> <stdin>:1:18\n  |\n1 | SELECT order_id, 'it''s' FROM orders\n",
-                "  |                  ^^^^^^^ Snowflake names this `literal` column after its text\n",
-                "  |\n  = help: add an alias, such as `AS \"'IT''S'\"`, which names the column in both engines\n",
+                "  |                  ^^^^^^^ Snowflake names this column after its full text, quotes and ",
+                "path included\n  |\n  = help: add an alias, which names the column in both engines\n",
                 "sqlquack convert: refused, 1 refusal\n",
             ),
             expected_span: ("SQ0009", 17, 24),