chore(syntax-receipts): place errno 1002 syntax error messages as syntax

Errno 1002 (SQLSTATE 42601) was refused as having no established phase.
Snowflake raises it from the parser for some malformed statements, with a
message that itself starts with "syntax error", such as ALTER WAREHOUSE ...
ADD TABLES with no table list: "syntax error line At least one table name
is required for ADD TABLES operations ...". Errno 1002 is now a syntax
error only when its message starts with "syntax error"; any other 1002
message stays refused.

Author: kvlonge

docs/syntax-coverage.md

@@ -176,6 +176,7 @@ that edits or removes a committed one.
      is refused unless the errno is a reviewed one, which is a `semantic_error`.
   4. Errno 1003 under the `SQL compilation error` prefix is a `syntax_error`. Any other errno
      under that prefix is a `semantic_error`, a compilation error after parsing.
+     Errno 1002 is a `syntax_error` only when its message itself starts with `syntax error`.
   5. Any other error is refused unless its errno is a reviewed one, which is a `semantic_error`.
 
   A reviewed errno is one whose message shows that Snowflake parsed the statement and then

scripts/syntax_receipts/_helpers/receipts.py

@@ -11,11 +11,13 @@
     MISSING_OBJECT,
     MISSING_OBJECT_MESSAGE,
     OTHER_REASON,
+    PARSER_SYNTAX_ERRNO,
     REASON_BY_ERRNO,
     RECEIPT_FORMAT,
     REVIEWED_SEMANTIC_ERRNOS,
     RUNTIME_ERRNO_FLOOR,
     SYNTAX_ERRNO,
+    SYNTAX_MESSAGE_PREFIX,
     SYNTAX_OR_ACCESS_SQLSTATE_CLASS,
     UNCATEGORIZED_PHASES,
     UNCAUGHT_PREFIX,
@@ -46,6 +48,8 @@ def classify(
     compiled: bool = message.lower().startswith(COMPILATION_PREFIX.lower())
     if errno == SYNTAX_ERRNO and compiled:
         return "syntax_error", "errno 1003 SQL compilation syntax error"
+    if errno == PARSER_SYNTAX_ERRNO and message.lower().startswith(SYNTAX_MESSAGE_PREFIX):
+        return "syntax_error", "errno 1002 parser syntax error"
     if errno is not None and compiled:
         return "semantic_error", f"errno {errno} compilation error after parsing"
     if errno in REVIEWED_SEMANTIC_ERRNOS:

scripts/syntax_receipts/constants.py

@@ -7,6 +7,8 @@
     {"accepted", "syntax_error", "semantic_error", "runtime_error", "unsupported_feature"}
 )
 SYNTAX_ERRNO: int = 1003
+PARSER_SYNTAX_ERRNO: int = 1002
+SYNTAX_MESSAGE_PREFIX: str = "syntax error"
 UNSUPPORTED_ERRNO: int = 2
 COMPILATION_PREFIX: str = "SQL compilation error"
 UNCAUGHT_PREFIX: str = "Uncaught exception of type"

tests/unit/scripts/syntax_receipts/test_import_runs.py

@@ -194,6 +194,23 @@
             message="External table identifier cannot be empty",
             expected_classification=None,
         ),
+        ClassifyTestCase(
+            description="errno 1002 whose message says syntax error is a syntax error",
+            errno=1002,
+            sqlstate="42601",
+            message=(
+                "syntax error line At least one table name is required for ADD TABLES operations"
+                " at position {1} unexpected '{2}'."
+            ),
+            expected_classification=("syntax_error", "errno 1002 parser syntax error"),
+        ),
+        ClassifyTestCase(
+            description="errno 1002 with any other message is not established",
+            errno=1002,
+            sqlstate="42601",
+            message="Invalid argument for the operation.",
+            expected_classification=None,
+        ),
         ClassifyTestCase(
             description="a syntax error without the compilation prefix is not established",
             errno=1003,