|
| 1 | +[review] |
| 2 | +schema = "sqlquack.recorder-change-review.v1" |
| 3 | +decision = "D301" |
| 4 | +related = ["D334", "D343", "D316"] |
| 5 | +pull_request = 135 |
| 6 | +branch = "land/basics-regression" |
| 7 | +commit = "f1944aa5f4074f202316aeeaaa6265d61bd683cf" |
| 8 | +base = "fc15d512c240487b318d3b00802097d70663f7e6" |
| 9 | +merge_base = "fc15d512c240487b318d3b00802097d70663f7e6" |
| 10 | +previous_review = "b64ede29c1571d0afe5a8efddd4ad3b1690aef6a" |
| 11 | +reviewed_at = "2026-11-07T01:39:37Z" |
| 12 | +round = 4 |
| 13 | +verdict = "approved" |
| 14 | +checked = [ |
| 15 | + "a9e5755a's tree equals git merge-tree of 0076e8e7 and fc15d512, so the merge with main is clean and adds nothing of its own.", |
| 16 | + "f1944aa5 changes four files: corpora/basics/queries.toml, corpora/everyday/queries.toml, corpora/everyday-models/queries.toml and scripts/basics_corpus/constants.py. No converter, test or receipt file changes, and both snowflake-receipts.json files are untouched.", |
| 17 | + "basics: 60 lines added and 0 removed. They are the 10 appended last_days entries (5 spellings each of the CURRENT_DATE and CURRENT_TIMESTAMP() filters), all pinned refused under both policies. No earlier entry moved.", |
| 18 | + "everyday: 20 expectations change, 14 refused to translated and 6 changed refusals. everyday-models: 29 change, 15 refused to translated and 14 changed refusals. None goes from translated to refused.", |
| 19 | + "The newly translated queries are the clock reads (SQ0008 fn:CURRENT_DATE / fn:CURRENT_TIMESTAMP) and the unread semi-structured columns (SQ0008 node:column) that #133 converts on main.", |
| 20 | +] |
| 21 | + |
| 22 | +[[review.finding]] |
| 23 | +kind = "expected_follow_up" |
| 24 | +blocking = false |
| 25 | +detail = "Three last_days spellings with `select /* c */` are pinned as refused SQ0002 node:select, which is the D327 comment refusal. When #134 lands they will change outcome. Under D334 a refused-to-translated change is only reported, but a change to a different refusal code fails the test, so re-record after #134 if that happens." |
| 26 | + |
| 27 | +[review.files_sha256] |
| 28 | +"corpora/basics/queries.toml" = "c0cf64ef526343ef6600ea29ddc98dc315cf6450676bb754d978027d354fb62c" |
| 29 | +"corpora/everyday/queries.toml" = "6672a3bf930df849b17d886af37b59f8d9ca970627ad89a916c4d9f31f01ae8b" |
| 30 | +"corpora/everyday-models/queries.toml" = "93ae10e36154393ed433d68827c6ab9a3b6bdf97a86a0c50374411235332b93e" |
| 31 | +"scripts/basics_corpus/constants.py" = "e4daf3526eb78ad7d9b5cfb87063adc7535298bbf029af75753481d6cb59e6d3" |
0 commit comments