From 5907b28ae9aeca8b040b8e8c695cfeeefb8c195f Mon Sep 17 00:00:00 2001 From: Rohit Goswami Date: Thu, 19 Nov 2026 02:56:15 +0000 Subject: [PATCH] test(proc): cover relative slash paths in resolveExecutable `proc.resolveExecutable` resolves a name that holds a slash against the current working directory, and the existing test passes absolute slash paths alone. The new test `resolveExecutable handles relative slash paths` in `src/proc.zig` builds `./` paths to the `makeExecFixture` files relative to the working directory and leaves the working directory unchanged. It checks that the relative path to `tool.sh` resolves to the absolute fixture path and that the relative path to `plain.txt` returns null. --- ...-resolve-executable-relative-slash.misc.md | 1 + src/proc.zig | 25 +++++++++++++++++++ 2 files changed, 26 insertions(+) create mode 100644 changelog.d/+proc-resolve-executable-relative-slash.misc.md diff --git a/changelog.d/+proc-resolve-executable-relative-slash.misc.md b/changelog.d/+proc-resolve-executable-relative-slash.misc.md new file mode 100644 index 0000000..c028154 --- /dev/null +++ b/changelog.d/+proc-resolve-executable-relative-slash.misc.md @@ -0,0 +1 @@ +`proc.resolveExecutable` tests cover relative slash paths for executable and non-executable files. diff --git a/src/proc.zig b/src/proc.zig index c3eed69..eb43d04 100644 --- a/src/proc.zig +++ b/src/proc.zig @@ -781,3 +781,28 @@ test "resolveExecutable resolves slash paths and PATH lookup" { try std.testing.expectEqual(@as(?[]u8, null), try resolveExecutable(gpa, dir_path, null)); try std.testing.expectEqual(@as(?[]u8, null), try resolveExecutable(gpa, "not-present-tool", fixture.base)); } + +test "resolveExecutable handles relative slash paths" { + const gpa = std.testing.allocator; + const fixture = try makeExecFixture(gpa, "resolve-relative"); + defer gpa.free(fixture.plain_path); + defer gpa.free(fixture.exe_path); + defer gpa.free(fixture.base); + defer fsx.deleteTree(gpa, fsx.cwd, fixture.base) catch {}; + + var cwd_buf: [sys.path_max:0]u8 = undefined; + const here = try fsx.realpath(fsx.cwd, ".", &cwd_buf); + const exe_rel = try std.fs.path.relativeAlloc(gpa, here, null, here, fixture.exe_path); + defer gpa.free(exe_rel); + const rel_exe = try std.fs.path.join(gpa, &.{ ".", exe_rel }); + defer gpa.free(rel_exe); + const resolved = (try resolveExecutable(gpa, rel_exe, null)).?; + defer gpa.free(resolved); + try std.testing.expectEqualStrings(fixture.exe_path, resolved); + + const plain_rel = try std.fs.path.relativeAlloc(gpa, here, null, here, fixture.plain_path); + defer gpa.free(plain_rel); + const rel_plain = try std.fs.path.join(gpa, &.{ ".", plain_rel }); + defer gpa.free(rel_plain); + try std.testing.expectEqual(@as(?[]u8, null), try resolveExecutable(gpa, rel_plain, null)); +}