From b85e3caaea8ce90ed3975c6c40a9bcef92ff9526 Mon Sep 17 00:00:00 2001 From: Tom Martensen Date: Fri, 20 Nov 2026 08:47:58 +0100 Subject: [PATCH 1/3] chore: switch to org shared quay secrets for pushing and reading roxie's image --- .github/workflows/build-roxie-image.yml | 4 ++-- .github/workflows/docker-build.yml | 4 ++-- .github/workflows/e2e-tests-kind.yml | 4 ++-- .github/workflows/e2e-tests.yml | 7 ------- 4 files changed, 6 insertions(+), 13 deletions(-) diff --git a/.github/workflows/build-roxie-image.yml b/.github/workflows/build-roxie-image.yml index 4f6ff512..57caf721 100644 --- a/.github/workflows/build-roxie-image.yml +++ b/.github/workflows/build-roxie-image.yml @@ -39,8 +39,8 @@ jobs: uses: docker/login-action@v4.6.0 with: registry: ${{ env.REGISTRY }} - username: ${{ secrets.REGISTRY_USERNAME }} - password: ${{ secrets.REGISTRY_TOKEN }} + username: ${{ secrets.QUAY_RHACS_ENG_RW_USERNAME }} + password: ${{ secrets.QUAY_RHACS_ENG_RW_PASSWORD }} - name: Get build metadata id: build-meta diff --git a/.github/workflows/docker-build.yml b/.github/workflows/docker-build.yml index 00f382b3..ff490976 100644 --- a/.github/workflows/docker-build.yml +++ b/.github/workflows/docker-build.yml @@ -40,8 +40,8 @@ jobs: uses: docker/login-action@v4.6.0 with: registry: ${{ env.REGISTRY }} - username: ${{ secrets.REGISTRY_USERNAME }} - password: ${{ secrets.REGISTRY_TOKEN }} + username: ${{ secrets.QUAY_RHACS_ENG_RW_USERNAME }} + password: ${{ secrets.QUAY_RHACS_ENG_RW_PASSWORD }} - name: Get build metadata id: build-meta diff --git a/.github/workflows/e2e-tests-kind.yml b/.github/workflows/e2e-tests-kind.yml index 42a4aef6..0fbfe7b6 100644 --- a/.github/workflows/e2e-tests-kind.yml +++ b/.github/workflows/e2e-tests-kind.yml @@ -33,8 +33,8 @@ jobs: uses: docker/login-action@v4.6.0 with: registry: ${{ env.REGISTRY }} - username: ${{ secrets.REGISTRY_USERNAME }} - password: ${{ secrets.REGISTRY_TOKEN }} + username: ${{ secrets.QUAY_RHACS_ENG_RO_USERNAME }} + password: ${{ secrets.QUAY_RHACS_ENG_RO_PASSWORD }} - name: Extract roxie binary from image run: | diff --git a/.github/workflows/e2e-tests.yml b/.github/workflows/e2e-tests.yml index e3f7f13b..24a41bb6 100644 --- a/.github/workflows/e2e-tests.yml +++ b/.github/workflows/e2e-tests.yml @@ -42,13 +42,6 @@ jobs: - name: Fix repository ownership run: git config --global --add safe.directory "$GITHUB_WORKSPACE" - - name: Log in to Quay.io - uses: docker/login-action@v4.6.0 - with: - registry: ${{ env.REGISTRY }} - username: ${{ secrets.REGISTRY_USERNAME }} - password: ${{ secrets.REGISTRY_TOKEN }} - - name: Extract roxie binary from image run: | docker create --name roxie-extract "${{ inputs.image }}" From 92756dc37b7cedcf2aea71f142da3a665646a8b9 Mon Sep 17 00:00:00 2001 From: Tom Martensen Date: Fri, 20 Nov 2026 09:04:21 +0100 Subject: [PATCH 2/3] remove ineffective INFRACTL env var --- .github/workflows/e2e-tests.yml | 1 - 1 file changed, 1 deletion(-) diff --git a/.github/workflows/e2e-tests.yml b/.github/workflows/e2e-tests.yml index 24a41bb6..d7ea5435 100644 --- a/.github/workflows/e2e-tests.yml +++ b/.github/workflows/e2e-tests.yml @@ -30,7 +30,6 @@ jobs: CLUSTER_NAME: ${{ inputs.cluster-name }} KUBECONFIG: /github/home/artifacts/kubeconfig INFRA_TOKEN: ${{ secrets.INFRA_TOKEN }} - INFRACTL: bin/infractl -k -e localhost:8443 ROXIE_RESOURCE_PROFILE: "small" steps: - name: Checkout From b1b232a1f4332dabaa7da781b1f74dc8b02018f4 Mon Sep 17 00:00:00 2001 From: Tom Martensen Date: Fri, 20 Nov 2026 09:22:47 +0100 Subject: [PATCH 3/3] remove superfluous docker login (roxie repo is public) --- .github/workflows/e2e-tests-kind.yml | 7 ------- 1 file changed, 7 deletions(-) diff --git a/.github/workflows/e2e-tests-kind.yml b/.github/workflows/e2e-tests-kind.yml index 0fbfe7b6..6478450d 100644 --- a/.github/workflows/e2e-tests-kind.yml +++ b/.github/workflows/e2e-tests-kind.yml @@ -29,13 +29,6 @@ jobs: go-version-file: go.mod cache: true - - name: Log in to Quay.io - uses: docker/login-action@v4.6.0 - with: - registry: ${{ env.REGISTRY }} - username: ${{ secrets.QUAY_RHACS_ENG_RO_USERNAME }} - password: ${{ secrets.QUAY_RHACS_ENG_RO_PASSWORD }} - - name: Extract roxie binary from image run: | docker create --name roxie-extract "${{ inputs.image }}"