From aec9ebb7bcf16ea83b496f49b080ee024c2b3def Mon Sep 17 00:00:00 2001 From: willymv <94822136+willymv@users.noreply.github.com> Date: Fri, 6 Nov 2026 13:18:27 +1100 Subject: [PATCH 1/3] Add modern chunk statuses to litStates array --- .../main/java/org/dynmap/common/chunk/GenericMapChunkCache.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/DynmapCore/src/main/java/org/dynmap/common/chunk/GenericMapChunkCache.java b/DynmapCore/src/main/java/org/dynmap/common/chunk/GenericMapChunkCache.java index e6e3565a8..bb25268a5 100644 --- a/DynmapCore/src/main/java/org/dynmap/common/chunk/GenericMapChunkCache.java +++ b/DynmapCore/src/main/java/org/dynmap/common/chunk/GenericMapChunkCache.java @@ -1193,7 +1193,7 @@ public boolean setChunkDataTypes(boolean blockdata, boolean biome, boolean highe return true; } - private static final String litStates[] = { "light", "spawn", "heightmaps", "full" }; + private static final String litStates[] = { "light", "spawn", "heightmaps", "full", "minecraft:light", "minecraft:spawn", "minecraft:heightmaps", "minecraft:full"}; /** * Resolve a block state from its palette name and property string ("prop=value,prop=value", may be empty). From 2616c6bbda2cab4b1f5a64f52fb1ef5352f56333 Mon Sep 17 00:00:00 2001 From: willymv <94822136+willymv@users.noreply.github.com> Date: Fri, 6 Nov 2026 15:12:08 +1100 Subject: [PATCH 2/3] Add check for Paper's Starlight in chunk data --- .../java/org/dynmap/common/chunk/GenericMapChunkCache.java | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/DynmapCore/src/main/java/org/dynmap/common/chunk/GenericMapChunkCache.java b/DynmapCore/src/main/java/org/dynmap/common/chunk/GenericMapChunkCache.java index bb25268a5..ebef025ed 100644 --- a/DynmapCore/src/main/java/org/dynmap/common/chunk/GenericMapChunkCache.java +++ b/DynmapCore/src/main/java/org/dynmap/common/chunk/GenericMapChunkCache.java @@ -1280,6 +1280,7 @@ public GenericChunk parseChunkFromNBT(GenericNBTCompound orignbt) { int version = orignbt.getInt("DataVersion"); boolean lit = nbt.getBoolean("isLightOn"); boolean hasLitState = false; + boolean hasPaperStarlight = orignbt.contains("starlight.light_version"); if (status != null) { for (String litState : litStates) { if (status.equals(litState)) { @@ -1495,7 +1496,7 @@ else if (old2d != null) { sbld.reset(); } // Assume skylight is only trustworthy in a lit state - if ((!hasLitState) || (!lit)) { + if ((!hasLitState) || (!lit && !hasPaperStarlight)) { hasLight = false; } // If no light, do simple generate From 1c4ccb317ab37aabc6bf69e6bd7d9ca3d615a0c3 Mon Sep 17 00:00:00 2001 From: willymv <94822136+willymv@users.noreply.github.com> Date: Thu, 19 Nov 2026 13:20:57 +1100 Subject: [PATCH 3/3] Move Starlight data check into lit boolean during chunk nbt parsing --- .../java/org/dynmap/common/chunk/GenericMapChunkCache.java | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/DynmapCore/src/main/java/org/dynmap/common/chunk/GenericMapChunkCache.java b/DynmapCore/src/main/java/org/dynmap/common/chunk/GenericMapChunkCache.java index ebef025ed..d571f36fe 100644 --- a/DynmapCore/src/main/java/org/dynmap/common/chunk/GenericMapChunkCache.java +++ b/DynmapCore/src/main/java/org/dynmap/common/chunk/GenericMapChunkCache.java @@ -1278,9 +1278,8 @@ public GenericChunk parseChunkFromNBT(GenericNBTCompound orignbt) { if (nbt == null) return null; String status = nbt.getString("Status"); int version = orignbt.getInt("DataVersion"); - boolean lit = nbt.getBoolean("isLightOn"); + boolean lit = nbt.getBoolean("isLightOn") || orignbt.contains("starlight.light_version"); // Chunks with Starlight data always have isLightOn as false. Affects chunks from Paper and Fabric servers with the Starlight mod. boolean hasLitState = false; - boolean hasPaperStarlight = orignbt.contains("starlight.light_version"); if (status != null) { for (String litState : litStates) { if (status.equals(litState)) { @@ -1496,7 +1495,7 @@ else if (old2d != null) { sbld.reset(); } // Assume skylight is only trustworthy in a lit state - if ((!hasLitState) || (!lit && !hasPaperStarlight)) { + if ((!hasLitState) || (!lit)) { hasLight = false; } // If no light, do simple generate