Skip to content

docs(authz-playground): show the conditions fix and the boundary-hour fix - #18

Merged
kanywst merged 3 commits into
mainfrom
docs/authz-playground-conditions
Oct 24, 2026
Merged

kanywst merged 3 commits into
mainfrom
docs/authz-playground-conditions

Conversation

@kanywst

@kanywst kanywst commented Oct 24, 2026

Copy link
Copy Markdown
Member

The playground was redesigned and gained a fifth engine, the Zanzibar model with an OpenFGA condition (0-draft/authz-playground#29, #30). This replaces the two screenshots of the old page with the new timing chart and the classic and conditional ReBAC graphs, adds a short passage on the conditional model and its cost, and says how the boundary-hour gap described under What broke was closed.

… fix

The playground now leads with a timing chart and has a fifth engine, the
Zanzibar model with an OpenFGA condition. Swap the old map and projection
screenshots for the chart and the two ReBAC graphs, describe the conditional
model and what it costs, and say how the boundary-hour gap was closed.
@coderabbitai

coderabbitai Bot commented Oct 24, 2026 •

Copy link
Copy Markdown

Important

  • 🔍 Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: aac8ec6f-160e-4ecc-875f-ca8406abf404
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Comment thread articles/authz-playground.md
@claude

claude Bot commented Oct 24, 2026

Copy link
Copy Markdown

Findings on articles/authz-playground.md. The inline comment covers the fifth-row claims and the missing ?v= hashes. These two sit on lines outside the diff hunks:

  • Stale numbers, line 31: "Eight of 72 requests split" was computed with 4 sampled hours. The new text at line 58 says enumeration now samples 8 hours (03, 08, 09, 10, 14, 17, 18, 22), so the total should be 144 and the split count should change. "All fourteen tests passed" (line 56) also needs a check now that a boundary test was added.
  • Four vs five, lines 2 and 18: the frontmatter title and description, and the intro "four of them... all four", still say four engines. The body now describes a fifth row, and "the other three" at line 31 is ambiguous. Either present the fifth row as a ReBAC variant or update the framing.

The raw main-branch URLs 404 until merge, which failed the link check.
Relative paths are what devto-cli rewrites on publish, and the ?v= hashes
make the CDN fetch the new images.
@kanywst

kanywst commented Oct 24, 2026

Copy link
Copy Markdown
Member Author

On the two points outside the diff: "Eight of 72 requests split" is still what the page reports. The on-page map samples 08, 09, 17 and 18 (3 users x 3 actions x 2 documents x 4 hours = 72); the 8-hour enumeration is the test harness, not the map. "All fourteen tests passed" describes the suite at the time of the bug, which is the point of that paragraph. On four vs five: the fifth row is introduced as the same Zanzibar model with a condition, and "the other three" in that paragraph refers to Cedar, Rego and Casbin, which are the three it contrasts with. The title stays, since the article is about the four engines and the fifth is that fix.

@claude

claude Bot commented Oct 24, 2026

Copy link
Copy Markdown

Relative image paths and the cache-bust query strings match the README asset rules. Two factual-consistency problems remain in articles/authz-playground.md:

  • Line 31: "Eight of 72 requests split" is probably stale now that the enumeration samples 08, 09, 17 and 18. "The other three" is also ambiguous next to the new fifth row.
  • Line 18 and the title: they still say four engines, while the PR adds a fifth row and changes "all four" to "every engine" further down.

I did not check the new images' contents. There is no JA version of this article.


![The classic model and the conditional one, asked the same question at 08:00](./assets/authz-playground/graphs.png?v=39f61897)

Add a document and Casbin needs its policy table regenerated, while ReBAC just gains a tuple and the model never moves.

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This sentence compared the four engines' policy shapes and leaned on the proj.png side-by-side image ("The same rules side by side…"). Both the lead-in and the image are gone. It now sits under the graphs image, which shows only the classic and conditional ReBAC models at 08:00, so the Casbin remark has nothing to point at. Either restore a comparison or fold the sentence into the surrounding prose.

@claude

claude Bot commented Oct 24, 2026

Copy link
Copy Markdown

Content findings on articles/authz-playground.md, all from the four-to-five-engine change:

  • Lines 2, 4 and 18: the title, description and "gave four of them… all four at once" still say four engines, while the body now adds a fifth row (Zanzibar with an OpenFGA condition). Reconcile them, or say explicitly that the fifth is a ReBAC variant. The article is published (id: 4637146), so a title change is visible on dev.to.
  • Line 31: "the other three" and "Eight of 72 requests split" were computed for four engines and the old 03/10/14/22 sample. This PR adds a fifth engine and the 08/09/17/18 hours. Re-verify both numbers against the current playground.
  • Line 46 (inline comment): the Casbin/ReBAC sentence lost its side-by-side image and lead-in, so it now sits under an unrelated graphs image.

No EN/JA parity issue, since there is no JA file in the tree. The relative image paths with ?v= hashes follow the README convention.

@kanywst
kanywst merged commit 6311dcf into main Oct 24, 2026
3 checks passed
@kanywst
kanywst deleted the docs/authz-playground-conditions branch October 24, 2026 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant