Repository navigation
docs: add platform matrix, surface Go 1.22 requirement earlier - #3
Merged
Merged
Conversation
Based on feedback from bravo-ledger via the Reponite review campaign. The process subcommand's Linux/macOS scope was only mentioned mid-page; - New Platform support table after Install makes it findable before someone picks the wrong command. Go 1.22 minimum now appears near source install too, not just at the bottom of the Install section.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based on feedback from bravo-ledger via the Reponite review campaign. The process subcommand's Linux/macOS scope was only mentioned mid-page;
What this PR does
Related issue
Closes #
Type
How I tested it
New condition type PRs only
Skip this section if you're not adding a subcommand.
poller.Condition(Kind,Target,Describe,SuccessMessage,Check)Checkreturns transient "not yet" states as(state, false, nil);err != nilis reserved for fatal failuresCheckrespectsctx— a long-running evaluation cancels when the poller's deadline fires, without orphaning child processesCheckare documented in a comment and match the tip logicKindininternal/tips— or is deliberately empty, per speccmd/<name>.gowires the condition throughbuildPoller+finishnewAllCmddispatch (isConditionKeyword,buildSubCondition) includes the new keywordCondition:/Last state:/ optional detail /Tip:--jsonoutput carriescondition,target,success,elapsed_ms,timeout_ms,last_state,attemptscmd/covering success, timeout, and bad-args (exit 2)README.mdanddocs/ci-cd.mdupdated with the new subcommandGeneral checklist
make lintpasses (vet + gofmt clean)make testpassesmake racepasses, required if the PR touchesinternal/pollerorcmd/all.gofeat:,fix:,docs:,test:,refactor:,chore:,ci:)README.mdandinternal/exitcode